feat: Support listing and selecting skills via $ or /skills #7506

xl-openai · 2025-12-03T00:07:17Z

List/Select skills with $-mention or /skills

github-actions · 2025-12-03T00:07:28Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-03T00:11:38Z

codex-rs/tui/src/bottom_pane/mod.rs

 mod footer;
 mod list_selection_view;
 mod prompt_args;
+mod skill_popup;


Added skill_popup module missing implementation

The new mod skill_popup; and SkillPopup references introduce a required module, but there is no skill_popup.rs (nor a directory module) anywhere under codex-rs/tui/src/bottom_pane, so the crate no longer compiles (file not found for module skill_popup). A repo-wide search for skill_popup.rs turns up nothing, so every build will fail at module resolution until the file is added or the import is removed.

Useful? React with 👍 / 👎.

xl-openai · 2025-12-03T00:13:30Z

@codex review again.

chatgpt-codex-connector · 2025-12-03T00:23:25Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

pakrym-oai · 2025-12-03T00:45:08Z

codex-rs/core/prompt.md

 - Do not use one-letter variable names unless explicitly requested.
 - NEVER output inline citations like "【F:README.md†L5-L14】" in your outputs. The CLI is not able to render these so they will just be broken in the UI. Instead, if you output valid filepaths, users will be able to click on them to open the files in their editor.

+## Skill mentions


Can we inject this as part of the skills list message or condition on the skills feature being enabled?

pakrym-oai · 2025-12-03T00:46:09Z

codex-rs/tui/src/app.rs

    // One-shot suppression of the next world-writable scan after user confirmation.
    skip_world_writable_scan_once: bool,
+
+    pub(crate) skills: Vec<SkillMetadata>,


can skills be Optional<> and that be a signal that they are enabled? Don't feel strongly.

pakrym-oai · 2025-12-03T00:46:52Z

codex-rs/tui/src/slash_command.rs

            SlashCommand::Quit | SlashCommand::Exit => "exit Codex",
            SlashCommand::Diff => "show git diff (including untracked files)",
            SlashCommand::Mention => "mention a file",
+            SlashCommand::Skills => "Use skills to improve how Codex performs specific tasks",


nit: casing

pakrym-oai · 2025-12-03T00:49:16Z

codex-rs/tui/src/slash_command.rs

 pub enum SlashCommand {
    // DO NOT ALPHA-SORT! Enum order is presentation order in the popup, so
    // more frequently used commands should be listed first.
+    Skills,


Do we want skills before models and approvals?

pakrym-oai · 2025-12-03T00:49:34Z

codex-rs/tui/src/slash_command.rs

            | SlashCommand::Logout => false,
            SlashCommand::Diff
            | SlashCommand::Mention
+            | SlashCommand::Skills


Do we filter out the slash command when skills are not available?

xl-openai · 2025-12-03T03:26:36Z

I have read the CLA Document and I hereby sign the CLA

xl-openai · 2025-12-03T03:37:28Z

@codex review again

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-03T03:53:15Z

codex-rs/tui/src/bottom_pane/skill_popup.rs

+                    match_indices: indices
+                        .map(|v| v.into_iter().map(|i| i.saturating_add(1)).collect()),


Fix skill popup match highlight offset

The skill popup offsets the fuzzy-match indices by one even though the rendered skill label has no leading prefix. When filtering skills via $ or /skills, the highlighted characters are shifted right and no longer correspond to the matched letters, which makes the fuzzy results misleading. Use the indices from fuzzy_match directly so highlighting aligns with the displayed skill names.

Useful? React with 👍 / 👎.

pakrym-oai · 2025-12-03T06:08:26Z

codex-rs/tui/src/bottom_pane/command_popup.rs

+        } else {
+            built_in_slash_commands()
+                .into_iter()
+                .filter(|(_, cmd)| *cmd != SlashCommand::Skills)


can we simplify

Suggested change

.filter(|(_, cmd)| *cmd != SlashCommand::Skills)

.filter(|(_, cmd)| skills_enabled || *cmd != SlashCommand::Skills)

and remove the if

but also, should we use the existing is_visible method for this?

is_visible only handles debug-only commands; teaching it about the skills flag would mean threading skills_enabled through its callers

pakrym-oai

Consider using is_visible to hide the command,

xl-openai · 2025-12-03T22:48:21Z

@codex review again

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-03T22:59:21Z

codex-rs/tui/src/bottom_pane/chat_composer.rs

+                let selected = popup.selected_skill().map(|skill| skill.name.clone());
+                if let Some(name) = selected {
+                    self.insert_selected_skill(&name);
+                }
+                self.active_popup = ActivePopup::None;


Avoid hijacking $ tokens as skill mentions

handle_key_event_with_skill_popup consumes Enter/Tab by inserting the currently selected skill and returning InputResult::None rather than submitting whenever the skill popup is active. Because the popup opens for any $-prefixed token (via current_skill_token in sync_popups), typing a normal shell command like echo $HOME with skills enabled triggers the popup and pressing Enter replaces $HOME with the first skill instead of sending the message. This blocks submitting messages containing $… unless the user manually dismisses the popup first.

Useful? React with 👍 / 👎.

It’s a valid concern but a functional trade-off

xl-openai requested review from gverma-openai and pakrym-oai December 3, 2025 00:07

chatgpt-codex-connector bot reviewed Dec 3, 2025

View reviewed changes

xl-openai force-pushed the xl/skills branch from 8f5d673 to a0c00b5 Compare December 3, 2025 00:13

pakrym-oai reviewed Dec 3, 2025

View reviewed changes

feat: Support listing and selecting skills via $ or /skills

df06dd7

xl-openai force-pushed the xl/skills branch from a0c00b5 to df06dd7 Compare December 3, 2025 00:47

pakrym-oai reviewed Dec 3, 2025

View reviewed changes

Fix comments.

407b4da

github-actions bot added a commit that referenced this pull request Dec 3, 2025

@xl-openai has signed the CLA in #7506

ea2a071

chatgpt-codex-connector bot reviewed Dec 3, 2025

View reviewed changes

pakrym-oai reviewed Dec 3, 2025

View reviewed changes

pakrym-oai approved these changes Dec 3, 2025

View reviewed changes

xl-openai added 3 commits December 3, 2025 11:09

Address more comments

51948bd

Merge branch 'main' into xl/skills

dd7286a

Solve merge conflict.

f3ae1a8

chatgpt-codex-connector bot reviewed Dec 3, 2025

View reviewed changes

xl-openai merged commit 9a50a04 into main Dec 3, 2025
26 checks passed

xl-openai deleted the xl/skills branch December 3, 2025 23:12

github-actions bot locked and limited conversation to collaborators Dec 3, 2025

		match_indices: indices
		.map(\|v\| v.into_iter().map(\|i\| i.saturating_add(1)).collect()),

	.filter(\|(_, cmd)\| *cmd != SlashCommand::Skills)
	.filter(\|(_, cmd)\| skills_enabled \|\| *cmd != SlashCommand::Skills)

feat: Support listing and selecting skills via $ or /skills #7506

feat: Support listing and selecting skills via $ or /skills #7506

Uh oh!

Conversation

xl-openai commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

xl-openai commented Dec 3, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xl-openai commented Dec 3, 2025

Uh oh!

xl-openai commented Dec 3, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pakrym-oai left a comment

Choose a reason for hiding this comment

Uh oh!

xl-openai commented Dec 3, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 3, 2025 •

edited

Loading