New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker - Minor fix for pull requests #286

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Projects
None yet
2 participants
@ppaquette
Contributor

ppaquette commented Aug 11, 2016

  • MUJOCO_KEY_BUNDLE is an empty string in pull requests, rather than being unset.
  • Split py27 and py34 to avoid hitting the 50 mins timeout, and for easier debugging.
  • COPY takes a trailing slash as per documentation
If <dest> does not end with a trailing slash, it will be considered a regular file and the contents of <src> will be written at <dest>.
@gdb

This comment has been minimized.

Show comment
Hide comment
@gdb

gdb Aug 11, 2016

Collaborator

Thanks!

Really need to figure out how to make these builds faster... I was hoping pulling a built image would do it, but doesn't seem to. Maybe next step is to try some explicit export-to-a-cachedir scheme?

Collaborator

gdb commented Aug 11, 2016

Thanks!

Really need to figure out how to make these builds faster... I was hoping pulling a built image would do it, but doesn't seem to. Maybe next step is to try some explicit export-to-a-cachedir scheme?

@ppaquette

This comment has been minimized.

Show comment
Hide comment
@ppaquette

ppaquette Aug 11, 2016

Contributor

The hashes from the build don't match the one you have in cache.

ubuntu:14.04 is periodically updated, and the cached version is 3 months old, vs the current one is 2 weeks old. You should probably create a gym:base image, and change the Dockerfile "FROM" to use that instead.

in cache:

philip@gym-build:~$ docker history quay.io/openai/gym:test
IMAGE               CREATED             CREATED BY                                      SIZE
2e025d13ad07        17 hours ago        /bin/sh -c #(nop) CMD ["tox"]                   0 B
b2aedae4605f        17 hours ago        /bin/sh -c #(nop) ENTRYPOINT ["/usr/local/gym   0 B
a9c89617db32        17 hours ago        /bin/sh -c #(nop) COPY dir:d0a4e5b14641b2a33c   10.75 MB
d77d67cf0381        17 hours ago        bash -c ( while true; do echo '.'; sleep 60;    1.096 GB
9ce6975b3a93        18 hours ago        /bin/sh -c pip install tox                      8.309 MB
d89099e4da29        18 hours ago        /bin/sh -c #(nop) COPY file:0b0ae9f97781dfb3b   946 B
65eb7dfdebb6        19 hours ago        /bin/sh -c #(nop) COPY file:28f1b954e150a7a4f   1.367 kB
31d75e40b092        19 hours ago        /bin/sh -c #(nop) COPY file:6a8531890ed5f454e   60 B
dc7b7f009cfe        19 hours ago        /bin/sh -c #(nop) COPY file:8f240bd22045e1a35   18 B
aae3b1c17513        19 hours ago        /bin/sh -c mkdir gym && touch gym/__init__.py   0 B
616f6b3bffb5        19 hours ago        /bin/sh -c #(nop) WORKDIR /usr/local/gym        0 B
010667335a8c        19 hours ago        /bin/sh -c apt-get update     && apt-get inst   821.3 MB
5513002504a5        3 months ago        /bin/sh -c #(nop) CMD ["/bin/bash"]             0 B
0e23078ccd33        3 months ago        /bin/sh -c sed -i 's/^#\s*\(deb.*universe\)$/   1.895 kB
3fef90246eb1        3 months ago        /bin/sh -c rm -rf /var/lib/apt/lists/*          0 B
b122d4ef87dc        3 months ago        /bin/sh -c set -xe                                                  && echo '#!/bin/sh' > /u   194.5 kB
cea86fd90f0b        3 months ago        /bin/sh -c #(nop) ADD file:b64f702c5b33d12426   187.8 MB

built:

f815ba1a5044        15 hours ago        /bin/sh -c #(nop) CMD ["tox"]                   0 B
10f3f99024b9        15 hours ago        /bin/sh -c #(nop) ENTRYPOINT ["/usr/local/gym   0 B
f83c30cd795a        15 hours ago        /bin/sh -c #(nop) COPY dir:2217bf9a48d3bb54a9   1.046 MB
a80f68618bd1        15 hours ago        bash -c ( while true; do echo '.'; sleep 60;    1.096 GB
6f73833dc9e4        15 hours ago        /bin/sh -c pip install tox                      8.309 MB
28082b147c1d        15 hours ago        /bin/sh -c #(nop) COPY file:7e6e970fe3ee0ad24   946 B
6ce95abf9fd0        15 hours ago        /bin/sh -c #(nop) COPY file:d03c475b31630ec05   1.367 kB
422091aa3f98        15 hours ago        /bin/sh -c #(nop) COPY file:6ca248b37d118c3c3   60 B
4fb6732f3168        15 hours ago        /bin/sh -c #(nop) COPY file:0294c499d0863a6a1   18 B
dcad40bcb963        15 hours ago        /bin/sh -c mkdir gym && touch gym/__init__.py   0 B
c39dd0c5e35a        15 hours ago        /bin/sh -c #(nop) WORKDIR /usr/local/gym        0 B
ec4527f82e56        15 hours ago        /bin/sh -c apt-get update     && apt-get inst   809.1 MB
87d8afb341b5        2 weeks ago         /bin/sh -c #(nop) CMD ["/bin/bash"]             0 B
46e772baf32a        2 weeks ago         /bin/sh -c sed -i 's/^#\s*\(deb.*universe\)$/   1.895 kB
0a7a3b768106        2 weeks ago         /bin/sh -c rm -rf /var/lib/apt/lists/*          0 B
e094bcb9d0fe        2 weeks ago         /bin/sh -c set -xe                                                  && echo
 '#!/bin/sh' > /u   194.6 kB
a16f6804bd85        2 weeks ago         /bin/sh -c #(nop) ADD file:dc3b1b2c44af75026b   187.8 MB
Contributor

ppaquette commented Aug 11, 2016

The hashes from the build don't match the one you have in cache.

ubuntu:14.04 is periodically updated, and the cached version is 3 months old, vs the current one is 2 weeks old. You should probably create a gym:base image, and change the Dockerfile "FROM" to use that instead.

in cache:

philip@gym-build:~$ docker history quay.io/openai/gym:test
IMAGE               CREATED             CREATED BY                                      SIZE
2e025d13ad07        17 hours ago        /bin/sh -c #(nop) CMD ["tox"]                   0 B
b2aedae4605f        17 hours ago        /bin/sh -c #(nop) ENTRYPOINT ["/usr/local/gym   0 B
a9c89617db32        17 hours ago        /bin/sh -c #(nop) COPY dir:d0a4e5b14641b2a33c   10.75 MB
d77d67cf0381        17 hours ago        bash -c ( while true; do echo '.'; sleep 60;    1.096 GB
9ce6975b3a93        18 hours ago        /bin/sh -c pip install tox                      8.309 MB
d89099e4da29        18 hours ago        /bin/sh -c #(nop) COPY file:0b0ae9f97781dfb3b   946 B
65eb7dfdebb6        19 hours ago        /bin/sh -c #(nop) COPY file:28f1b954e150a7a4f   1.367 kB
31d75e40b092        19 hours ago        /bin/sh -c #(nop) COPY file:6a8531890ed5f454e   60 B
dc7b7f009cfe        19 hours ago        /bin/sh -c #(nop) COPY file:8f240bd22045e1a35   18 B
aae3b1c17513        19 hours ago        /bin/sh -c mkdir gym && touch gym/__init__.py   0 B
616f6b3bffb5        19 hours ago        /bin/sh -c #(nop) WORKDIR /usr/local/gym        0 B
010667335a8c        19 hours ago        /bin/sh -c apt-get update     && apt-get inst   821.3 MB
5513002504a5        3 months ago        /bin/sh -c #(nop) CMD ["/bin/bash"]             0 B
0e23078ccd33        3 months ago        /bin/sh -c sed -i 's/^#\s*\(deb.*universe\)$/   1.895 kB
3fef90246eb1        3 months ago        /bin/sh -c rm -rf /var/lib/apt/lists/*          0 B
b122d4ef87dc        3 months ago        /bin/sh -c set -xe                                                  && echo '#!/bin/sh' > /u   194.5 kB
cea86fd90f0b        3 months ago        /bin/sh -c #(nop) ADD file:b64f702c5b33d12426   187.8 MB

built:

f815ba1a5044        15 hours ago        /bin/sh -c #(nop) CMD ["tox"]                   0 B
10f3f99024b9        15 hours ago        /bin/sh -c #(nop) ENTRYPOINT ["/usr/local/gym   0 B
f83c30cd795a        15 hours ago        /bin/sh -c #(nop) COPY dir:2217bf9a48d3bb54a9   1.046 MB
a80f68618bd1        15 hours ago        bash -c ( while true; do echo '.'; sleep 60;    1.096 GB
6f73833dc9e4        15 hours ago        /bin/sh -c pip install tox                      8.309 MB
28082b147c1d        15 hours ago        /bin/sh -c #(nop) COPY file:7e6e970fe3ee0ad24   946 B
6ce95abf9fd0        15 hours ago        /bin/sh -c #(nop) COPY file:d03c475b31630ec05   1.367 kB
422091aa3f98        15 hours ago        /bin/sh -c #(nop) COPY file:6ca248b37d118c3c3   60 B
4fb6732f3168        15 hours ago        /bin/sh -c #(nop) COPY file:0294c499d0863a6a1   18 B
dcad40bcb963        15 hours ago        /bin/sh -c mkdir gym && touch gym/__init__.py   0 B
c39dd0c5e35a        15 hours ago        /bin/sh -c #(nop) WORKDIR /usr/local/gym        0 B
ec4527f82e56        15 hours ago        /bin/sh -c apt-get update     && apt-get inst   809.1 MB
87d8afb341b5        2 weeks ago         /bin/sh -c #(nop) CMD ["/bin/bash"]             0 B
46e772baf32a        2 weeks ago         /bin/sh -c sed -i 's/^#\s*\(deb.*universe\)$/   1.895 kB
0a7a3b768106        2 weeks ago         /bin/sh -c rm -rf /var/lib/apt/lists/*          0 B
e094bcb9d0fe        2 weeks ago         /bin/sh -c set -xe                                                  && echo
 '#!/bin/sh' > /u   194.6 kB
a16f6804bd85        2 weeks ago         /bin/sh -c #(nop) ADD file:dc3b1b2c44af75026b   187.8 MB
@gdb

This comment has been minimized.

Show comment
Hide comment
@gdb

gdb Aug 11, 2016

Collaborator

Ah, good find! Yep, sounds like a plan.

Collaborator

gdb commented Aug 11, 2016

Ah, good find! Yep, sounds like a plan.

@gdb

This comment has been minimized.

Show comment
Hide comment
@gdb

gdb Aug 11, 2016

Collaborator

Looks like your 3.4 failed. Will merge after fixup!

Collaborator

gdb commented Aug 11, 2016

Looks like your 3.4 failed. Will merge after fixup!

@gdb

This comment has been minimized.

Show comment
Hide comment
@gdb

gdb Aug 11, 2016

Collaborator

Looks like there's a deeper issue with performance (build caching like this stopped being supported in 1.10): moby/moby#20316 (comment).

I do have an easy trick still... namely, having a much more built-up "base" image. Will see if I can get that running easily.

Collaborator

gdb commented Aug 11, 2016

Looks like there's a deeper issue with performance (build caching like this stopped being supported in 1.10): moby/moby#20316 (comment).

I do have an easy trick still... namely, having a much more built-up "base" image. Will see if I can get that running easily.

@ppaquette

This comment has been minimized.

Show comment
Hide comment
@ppaquette

ppaquette Aug 12, 2016

Contributor

3.4 is caused by Segmentation fault. Happens ~ 30% of the time. Not sure what env is causing it.

Contributor

ppaquette commented Aug 12, 2016

3.4 is caused by Segmentation fault. Happens ~ 30% of the time. Not sure what env is causing it.

@gdb gdb merged commit ee7ba41 into openai:master Aug 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ppaquette ppaquette deleted the ppaquette:ppaquette-docker-20160811 branch Aug 14, 2016

kevin00036 added a commit to kevin00036/gym that referenced this pull request Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment