New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ffmpeg to dockerfile and fixed test #325

Merged
merged 4 commits into from Aug 29, 2016

Conversation

Projects
None yet
2 participants
@kashif
Contributor

kashif commented Aug 29, 2016

No description provided.

@kashif

This comment has been minimized.

Show comment
Hide comment
@kashif

kashif Aug 29, 2016

Contributor

@jonasschneider will do... i wanted to just see the docker/ubuntu error... i will fix that first

Contributor

kashif commented Aug 29, 2016

@jonasschneider will do... i wanted to just see the docker/ubuntu error... i will fix that first

@jonasschneider

This comment has been minimized.

Show comment
Hide comment
@jonasschneider

jonasschneider Aug 29, 2016

Collaborator

Thanks for the patch. Instead of using the third-party ffmpeg, could you rather install libav-tools to have avconv (which we also support in VideoRecorder)? I'd rather not have the unofficial PPA here, if we have the alternative.

Collaborator

jonasschneider commented Aug 29, 2016

Thanks for the patch. Instead of using the third-party ffmpeg, could you rather install libav-tools to have avconv (which we also support in VideoRecorder)? I'd rather not have the unofficial PPA here, if we have the alternative.

@jonasschneider jonasschneider merged commit ebb2f29 into openai:master Aug 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jonasschneider

This comment has been minimized.

Show comment
Hide comment
@jonasschneider

jonasschneider Aug 29, 2016

Collaborator

Awesome, thank you!

Collaborator

jonasschneider commented Aug 29, 2016

Awesome, thank you!

kevin00036 added a commit to kevin00036/gym that referenced this pull request Nov 20, 2016

added ffmpeg to dockerfile and fixed test (#325)
* added ffmpeg to dockerfile and fixed test

* use ubuntu media repo for ffmpeg

* ffmpeg on travis 🍰

* install libav instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment