New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing dependencies to main Dockerfile #746

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@FirefoxMetzger
Contributor

FirefoxMetzger commented Oct 13, 2017

At the moment a clean (--no-chache) build of the master branch crashes. This PR fixes it by adding the necessary dependencies.

A while back someone had trouble building the gym in docker using

docker build .

in Issue #706 . I had the same issue, fixed it and posted the updated docker file here.

Hopefully, someone from the openAI team has 5 minutes to look into this =) It would be nice to be able to build master from scratch in docker without resorting to workarounds.

@FirefoxMetzger

This comment has been minimized.

Show comment
Hide comment
@FirefoxMetzger

FirefoxMetzger Nov 6, 2017

Contributor

@wojzaremba,
@bmcgrew,

what can I do to get this reviewed and merged?

Contributor

FirefoxMetzger commented Nov 6, 2017

@wojzaremba,
@bmcgrew,

what can I do to get this reviewed and merged?

@wojzaremba

This comment has been minimized.

Show comment
Hide comment
@wojzaremba

wojzaremba Nov 6, 2017

Contributor

LGTM

Contributor

wojzaremba commented Nov 6, 2017

LGTM

@wojzaremba wojzaremba merged commit 0eccce8 into openai:master Nov 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

FirefoxMetzger pushed a commit to FirefoxMetzger/gym that referenced this pull request Nov 6, 2017

FirefoxMetzger
fixed broken Dockerfile (see gist) (openai#746)
fixed broken Dockerfile (see gist) (openai#746)

@FirefoxMetzger FirefoxMetzger deleted the FirefoxMetzger:openai-fixed-build-file branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment