More explicit warning #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzhokhov
reviewed
Jan 3, 2023
multiagent/__init__.py
Outdated
| "support for installation via pip, and numerous other large quality of life improvements. \nWe " | ||
| "encourage researchers to switch to this maintained version for all purposes other than comparing " | ||
| "to results run on this version of the environments. \n") | ||
| input("Please read the raised warning, then press Enter to continue...\n") |
There was a problem hiding this comment.
this would trigger (request user to press Enter) every single time you run the code though, right? I agree with everything except for this
There was a problem hiding this comment.
this would trigger (request user to press Enter) every single time you run the code though, right? I agree with everything except for this
The issue that led to this was that other writes to stdout drowns out this warning. Alternatively, we could use sleep().
What are your thoughts?
There was a problem hiding this comment.
Could also use environment variables instead/as well as pressing Enter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Peter please see my email)