fix: emit agent_end lifecycle event for streaming agents #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix streaming agents not calling agent_end lifecycle hook when completing execution - Add agent_end event emissions in streaming loop to match non-streaming behavior - Add tests to verify agent_end events are emitted for both streaming and non-streaming agents - Resolves issue where users could not collect usage information from streaming agent runs Fixes #371
🦋 Changeset detectedLatest commit: 58cc241 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Added assertion to verify result.finalOutput in agent_end lifecycle test - Resolves ESLint error: 'result' is assigned a value but never used - Makes test more comprehensive by validating both events and return value
Contributor
Author
|
Hi @seratch, I’ve pushed the changes to resolve the CI issues. Could you please review the updates when you have a chance? Thank you. |
seratch
requested changes
Aug 26, 2025
Member
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
I haven't checked if the change is relevant yet, but can you simplify the changeset like I suggest?
Member
|
The code change looks good to me |
seratch
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #371 - Streaming agents do not call the agent_end lifecycle hook
Changes
Problem
Users reported that
agent_endlifecycle hooks work for non-streaming agents but are never called for streaming agents, preventing them from collecting usage information at the end of agent runs.Solution
Added missing
agent_endevent emissions in the streaming implementation (packages/agents-core/src/run.ts) to match the non-streaming behavior. Both the runner and agent instances now emit theagent_endevent when streaming agents complete execution.Testing
agent_endeventsImpact
Fixes #371