fix: check for process.on #9
Conversation
In Cloudflare Workers / the workerd runtime, `process` can be defined, but `process.on()` isn't (yet). This adds a chck for the existence of `process.on` as a function before handing event handlers.
dkundel-openai
left a comment
dkundel-openai
left a comment
There was a problem hiding this comment.
Thanks for the fix! Looks good overall. Could you run pnpm changeset to generate a changeset entry? Will try to get this out ASAP
|
Btw there is a dedicated test for Cloudflare in the integrations-test/ happy to adapt this with some expert feedback |
|
done! btw you can add the changeset bot https://github.com/apps/changeset-bot which adds a comment on a pr if it's missing a changeset (and gives a link to autogenerate one) It looks like this cloudflare/agents#316 (comment) |
|
I've started experimenting here https://github.com/threepointone/openai-cloudflare-agents I'll keep you in the loop. For now, trying to figure out why |
|
Thanks! Yeah waiting for the bot to be added :) |
3 participants
In Cloudflare Workers / the workerd runtime,
processcan be defined, butprocess.on()isn't (yet). This adds a check for the existence ofprocess.onas a function before handing event handlers.(Hi folks! I'm a tech lead on ai agents at Cloudflare. Big fan of y'all! Working on making this package work with all our stuff. There's a separate issue with the node build of
debugbeing loaded, but I don't yet think that's a problem with this package. Working on fixing that separately.)