-
Notifications
You must be signed in to change notification settings - Fork 342
Onboard to test framework #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…openai-dotnet into addtestframeworktake2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR onboards the openai-dotnet library to Microsoft.ClientModel.TestFramework to modernize the testing infrastructure. The migration introduces test proxy support for HTTP recording/playback and standardizes async/sync test patterns.
- Migrates from custom mock implementations to Microsoft.ClientModel.TestFramework mocks
- Adds test proxy integration for HTTP recording/playback with test session records
- Implements automatic sync/async test conversion eliminating manual synchronous test logic
Reviewed Changes
Copilot reviewed 59 out of 580 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SessionRecords/AssistantsTests/FunctionToolsWork.json | New test recording for function tools functionality test |
| tests/SessionRecords/AssistantsTests/FileSearchWorksAsync.json | New test recording for async file search functionality |
| tests/SessionRecords/AssistantsTests/FileSearchWorks.json | New test recording for file search functionality |
| tests/SessionRecords/AssistantsTests/FileSearchStreamingWorksAsync.json | New test recording for async streaming file search |
| tests/SessionRecords/AssistantsTests/FileSearchStreamingWorks.json | New test recording for streaming file search functionality |
| tests/SessionRecords/AssistantsTests/BasicThreadOperationsWorkAsync.json | New test recording for async thread operations |
| tests/SessionRecords/AssistantsTests/BasicThreadOperationsWork.json | New test recording for basic thread operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jsquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't scrutinize each test class, but poking through randoms look like the expected patterns. We'll want to get some additional eyes on, but I think it's pretty low risk to advance this, as the tests aren't super-reliable today.
|
Just pushed commits that:
Tests are all green - lmk if there's any additional feedback!! |
Onboarding openai-dotnet to Microsoft.ClientModel.TestFramework
General changes
Test utility changes
Mock test changes
Recorded test changes
Areas for future improvement