From 532c99e26c8c4388b250b100ab6275ea09905cc9 Mon Sep 17 00:00:00 2001 From: Showmick Das Date: Mon, 27 Oct 2025 21:31:41 -0400 Subject: [PATCH] Fix file handle leak in upload_file_chunked Changed exception-only close() to finally block to ensure file handles are always closed, preventing resource leaks on successful uploads. --- src/openai/resources/uploads/uploads.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/openai/resources/uploads/uploads.py b/src/openai/resources/uploads/uploads.py index 8953256f2a..e8c047bd4f 100644 --- a/src/openai/resources/uploads/uploads.py +++ b/src/openai/resources/uploads/uploads.py @@ -157,9 +157,8 @@ def upload_file_chunked( part = self.parts.create(upload_id=upload.id, data=data) log.info("Uploaded part %s for upload %s", part.id, upload.id) part_ids.append(part.id) - except Exception: + finally: buf.close() - raise return self.complete(upload_id=upload.id, part_ids=part_ids, md5=md5) @@ -465,9 +464,8 @@ async def upload_file_chunked( part = await self.parts.create(upload_id=upload.id, data=data) log.info("Uploaded part %s for upload %s", part.id, upload.id) part_ids.append(part.id) - except Exception: + finally: buf.close() - raise return await self.complete(upload_id=upload.id, part_ids=part_ids, md5=md5)