Skip to content
This repository has been archived by the owner. It is now read-only.

Add Monitor Wrapper #79

Merged
merged 16 commits into from Dec 24, 2016
Merged

Add Monitor Wrapper #79

merged 16 commits into from Dec 24, 2016

Conversation

@nottombrown
Copy link
Contributor

nottombrown commented Dec 23, 2016

Sibling pull request to openai/gym#434

This removed the env.monitor object and replaces it with a Monitor wrapper.

Currently will only monitor the first instance in a vectorized env, and starts upon the call to configure

return [monitor._after_step(o, r, d, i) for monitor, o, r, d, i in zip(self.monitor_n, observation_n, reward_n, done_n, info['n'])]
logger = logging.getLogger(__name__)

def Monitored(directory, video_callable=None, force=False, resume=False,

This comment has been minimized.

@gdb

gdb Dec 23, 2016 Contributor

Let's call the wrapper Monitor BTW

This comment has been minimized.

@nottombrown

nottombrown Dec 23, 2016 Author Contributor

Yeah, the name is just there to distinguish it from the Monitor object. It seems like I could do the following:

1. Rename Monitor to MonitorManager, 
2. Rename Monitored wrapper to Monitor
3. Refactor MonitorManager into 3 wrappers and kill the MonitorManager object
nottombrown added 9 commits Dec 23, 2016
@nottombrown nottombrown changed the title WIP monitor wrapper Add Monitor Wrapper Dec 24, 2016
@nottombrown nottombrown merged commit f637b07 into master Dec 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nottombrown nottombrown deleted the tom-monitor-wrapper branch Dec 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.