Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add person-identifier type: Digital Author Identifier (DAI). #49

Merged
merged 2 commits into from Nov 14, 2018

Conversation

@wilkos-dans
Copy link
Contributor

commented Nov 12, 2018

This PR has not yet implemented the change of #48.

@wilkos-dans wilkos-dans referenced this pull request Nov 12, 2018
@jdvorak001

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

(The CI failure is not connected to the proposed modification.)

@jdvorak001

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

@wilkos-dans , thank you for the suggestion and contribution. It is very welcome.

I'm having a question regarding the regular expression. The article you mention in your patch, https://wiki.surfnet.nl/display/standards/DAI, talks about the NL subspace where the DAI proper seems to be formed from digits only. (Or does the check digit algorithm lead to X as the check digit?)

However, you are proposing a very permissive regexp that allows any sequence of (at least three) alphanumeric characters to be present. In order to ensure quality metadata for the OpenAIRE ingest engine I would prefer a gradual approach here:

  1. Start with a regexp that permits the Dutch DAIs while closely following their syntax.
  2. When the need comes to introduce DAIs from other country subspaces we do this on a one-by-one basis.
    (XML Schema allows more regexp patterns to be specified for a string-based restriction simple type, the input has to match any of them in order to be recognized as valid.)

@wilkos-dans , would this satisfy the requirement you are having at hand?
@joschirr , please step in if you think I am erring on the side of unnecessary overpünktlichkeit here.

@wilkos-dans

This comment has been minimized.

Copy link
Contributor Author

commented Nov 13, 2018

@jdvorak001 Thanks for the feedback.

  1. Start with a regexp that permits the Dutch DAIs while closely following their syntax.

I agree on the the permissive 'end' of the regex. I have updated this.

  1. When the need comes to introduce DAIs from other country subspaces we do this on a one-by-one basis.
    (XML Schema allows more regexp patterns to be specified for a string-based restriction simple type, the input has to match any of them in order to be recognized as valid.)

DAI has been designed to serve other countries as well. So, if you want them to be explicitly defined, that's fine. I'll start with 'nl'. We can extend them with other countries, like: (nl|be|pt) etc. or just add a new one. I have pushed my changes to the PR. Thanks!

@jdvorak001 jdvorak001 merged commit cadf4a6 into openaire:master Nov 14, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jdvorak001

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

@wilkos-dans , thank you very much for your contribution!

(Apologies for the CI checks not working on your branch, they do work on master now.)

@ACz-UniBi

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

@jdvorak001 I can't find the discussion but is there a reason, why does the person identifier is explicitly named as a tagname like
<ORCID>...</ORCID> or <DAI>...</DAI> or ...
? And not as an attribute like this example: <personIdentifier nameIdentifierSchema="ORCID" ..... ?

@jdvorak001

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

Yes, there is: it's the regexp validations that we employ on these identifiers. See the improved description in the current version of the documentation at https://openaire-guidelines-for-cris-managers.readthedocs.io/en/latest/cerif_xml_person_entity.html#orcid onwards.

@ACz-UniBi

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

That makes sense, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.