fix(nfapi): align Aerial FAPI 10.04 packing#9
Open
mud-the-developer wants to merge 1 commit into
Open
Conversation
Fix the Aerial nvIPC/FAPI packing used by the gNB VNF: - do not add an extra FAPI header length to P5 nvIPC messages - widen CONFIG.request TLV lengths to SCF FAPI 10.04 format for Aerial - pack Aerial DL_TTI/TX_DATA fields added by the 10.04 layout Validated with docker build target oai-gnb-aerial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the Aerial nvIPC/FAPI packing used by the gNB VNF when interoperating with NVIDIA Aerial cuPHY builds that use the SCF FAPI 10.04 layout.
The patch addresses three wire-format mismatches observed on the Aerial L2/L1 boundary:
fapi_nr_p5_message_pack()already returns the complete packed FAPI message length, including the FAPI header.CONFIG.requestTLV headers fromtag:u16 + length:u16to the SCF FAPI 10.04tag:u16 + length:u32format for the Aerial nvIPC boundary.DL_TTI.request:testModebyte betweenSlotandnPDUsTX_DATA.request:cw_indexbyte afterPDU_indexTX_DATA.requestTLV lengths as 32-bit values underENABLE_AERIALValidation
git diff --checkDOCKER_BUILDKIT=1 docker build --target oai-gnb-aerial --tag oai-gnb-aerial:pr-aerial-scf-fapi --file docker/Dockerfile.gNB.aerial.ubuntu .Notes
This was validated on an Aerial-enabled gNB build path. The conversion is intentionally limited to the Aerial L2-to-L1
CONFIG.requestnvIPC boundary so the generic FAPI packer layout remains unchanged.