Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in finalize_options in Python 3 #45

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Conversation

pradal
Copy link
Contributor

@pradal pradal commented Mar 25, 2021

I fix an error in the commands due to wrong Py2 to Py3 conversion.

This PR fix #44

@pradal
Copy link
Contributor Author

pradal commented Mar 25, 2021

@mlabadie can you test this PR, please?

@mlabadie
Copy link

@pradal I test PR installing openalea.deploy with setup.py develop on my conda environnement. It seems that HACK work. No error message appear

Copy link
Contributor Author

@pradal pradal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@pradal
Copy link
Contributor Author

pradal commented Mar 29, 2021

Close issue #43 : Remove activate script on Windows.
This will be manage directly by conda packaging rather than automatically by deploy.

@mlabadie mlabadie closed this Mar 29, 2021
@mlabadie
Copy link

Close issue #43 : Remove activate script on Windows.
This will be manage directly by conda packaging rather than automatically by deploy.

Problem are not solve

@mlabadie
Copy link

Problem is solve thank you!!!!!!

@pradal pradal reopened this Mar 29, 2021
@pradal pradal merged commit 6ff178c into openalea:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in setup.py with share_dirs in adel
2 participants