Feature/support header parameters #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 1178 1184 +6
=========================================
+ Hits 1178 1184 +6
Continue to review full report at Codecov.
|
dbanty
requested changes
Aug 10, 2020
Collaborator
dbanty
left a comment
dbanty
left a comment
There was a problem hiding this comment.
Looks good, if you can make oge based on the tasks it's chaining rather than redoing the commands. That way if we change the way one of them works we can just change it in one place.
dbanty
approved these changes
Aug 11, 2020
dbanty
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117 and closes #146