move inline styles to location/_content.scss, add titles to links

openaq · Jul 3, 2019 · 678ea08 · 678ea08
1 parent 437db16
commit 678ea08
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/app/assets/scripts/views/location.js b/app/assets/scripts/views/location.js
@@ -280,12 +280,12 @@ var Location = React.createClass({
 
       switch (sectionIndex) {
         case 0: {
-          propertiesMain.push(<dt key={`${key}-${prop.title}`}>{prop.title}</dt>);
+          propertiesMain.push(<dt key={`${key}-${prop.title}`} className='metadata-detail-title'>{prop.title}</dt>);
           propertiesMain.push(<dd key={`${key}-${prop.title}-val`}>{val}</dd>);
           break;
         }
         case 1: {
-          propertiesSec.push(<dt key={`${key}-${prop.title}`} style={{ marginBottom: 0 }}>{prop.title}</dt>);
+          propertiesSec.push(<dt key={`${key}-${prop.title}`} className='metadata-detail-title'>{prop.title}</dt>);
           propertiesSec.push(<dd key={`${key}-${prop.title}-val`}>{val}</dd>);
           break;
         }
@@ -310,9 +310,9 @@ var Location = React.createClass({
           </div>
 
         </div>
-        <div className='inner' style={{ marginTop: 30 }}>
+        <div className='inner update-metadata-callout'>
           <p>
-            Have more information about this location? <a href={`${config.metadata}/location/${loc.data.id}`}>Update the metadata</a>
+            Have more information about this location? <a href={`${config.metadata}/location/${loc.data.id}`} title="Update the metadata">Update the metadata</a>
           </p>
         </div>
       </section>
@@ -358,7 +358,7 @@ var Location = React.createClass({
               sources[0] && (
                 <div className='col-sec'>
                   {sources[0].description ? <p>{sources[0].description}</p> : null}
-                  For more information contact <a href={`mailto:${sources[0].contacts[0]}`}>{sources[0].contacts[0]}</a>.
+                  For more information contact <a href={`mailto:${sources[0].contacts[0]}`} title={sources[0].contacts[0]}>{sources[0].contacts[0]}</a>.
                 </div>
               )
             }

diff --git a/app/assets/styles/location/_content.scss b/app/assets/styles/location/_content.scss
@@ -115,3 +115,11 @@
     margin-right: calc(50% - 50vw);
   }
 }
+
+.metadata-detail-title {
+  margin-bottom: 0px;
+}
+
+.update-metadata-callout {
+  margin-top: 30px;
+}