diff --git a/include/openbabel/base.h b/include/openbabel/base.h index c814ed0ca8..83ca57473c 100644 --- a/include/openbabel/base.h +++ b/include/openbabel/base.h @@ -28,15 +28,6 @@ GNU General Public License for more details. #include #include -#ifdef UNUSED -#elif (__GNUC__ == 4) -# define UNUSED(x) UNUSED_ ## x __attribute__((unused)) -#elif defined(__LCLINT__) -# define UNUSED(x) /*@unused@*/ x -#else -# define UNUSED(x) x -#endif - namespace OpenBabel { @@ -283,7 +274,7 @@ class OBConversion; //used only as pointer //! \brief Base type does nothing //! Made virtual around r3535 to simplify code which passes around OBBase*. //Currently no title data member in base class. - virtual const char *GetTitle(bool UNUSED(replaceNewlines) = true) const { return "";} + virtual const char *GetTitle(bool /*replaceNewlines*/ = true) const { return ""; } virtual void SetTitle(const char *) {} //! \name Generic data handling methods (via OBGenericData) diff --git a/include/openbabel/chargemodel.h b/include/openbabel/chargemodel.h index 84022e737d..e543ddbe83 100644 --- a/include/openbabel/chargemodel.h +++ b/include/openbabel/chargemodel.h @@ -38,8 +38,8 @@ class OBAPI OBChargeModel : public OBPlugin /// \return whether partial charges were successfully assigned to this molecule /// \note The method should fill m_partialCharges and m_formalCharges as well - virtual bool ComputeCharges(OBMol &m ) { return false; }; - virtual bool ComputeCharges(OBMol &m, const char *args) { return ComputeCharges( m ); } + virtual bool ComputeCharges(OBMol & /*m*/) { return false; }; + virtual bool ComputeCharges(OBMol &m, const char * /*args*/) { return ComputeCharges( m ); } /// \return a vector of the formal charges on each atom, indexed from 0 /// This method returns floating point formal charges since some diff --git a/include/openbabel/depict/asciipainter.h b/include/openbabel/depict/asciipainter.h index 0bd7245c4f..cec97e30b1 100644 --- a/include/openbabel/depict/asciipainter.h +++ b/include/openbabel/depict/asciipainter.h @@ -31,7 +31,7 @@ namespace OpenBabel //@{ void NewCanvas(double width, double height); bool IsGood() const; - void SetFontFamily(const std::string &fontFamily) {} + void SetFontFamily(const std::string &/*fontFamily*/) {} void SetFontSize(int pointSize); void SetFillColor(const OBColor &color); void SetFillRadial(const OBColor &start, const OBColor &end); diff --git a/include/openbabel/depict/cairopainter.h b/include/openbabel/depict/cairopainter.h index 9707ac59fe..fd3dcbd5f7 100644 --- a/include/openbabel/depict/cairopainter.h +++ b/include/openbabel/depict/cairopainter.h @@ -15,7 +15,7 @@ namespace OpenBabel //@{ void NewCanvas(double width, double height); bool IsGood() const; - void SetFontFamily(const std::string &fontFamily) {} // FIXME + void SetFontFamily(const std::string &/*fontFamily*/) {} // FIXME void SetFontSize(int pointSize); void SetFillColor(const OBColor &color); void SetFillRadial(const OBColor &start, const OBColor &end); diff --git a/include/openbabel/depict/commandpainter.h b/include/openbabel/depict/commandpainter.h index 3483d07333..98d781b706 100644 --- a/include/openbabel/depict/commandpainter.h +++ b/include/openbabel/depict/commandpainter.h @@ -31,7 +31,7 @@ namespace OpenBabel //@{ void NewCanvas(double width, double height); bool IsGood() const; - void SetFontFamily(const std::string &fontFamily) {} // FIXME + void SetFontFamily(const std::string &/*fontFamily*/) {} // FIXME void SetFontSize(int pointSize); void SetFillColor(const OBColor &color); void SetFillRadial(const OBColor &start, const OBColor &end); diff --git a/include/openbabel/forcefield.h b/include/openbabel/forcefield.h index e0d7a87a79..a2d3532ee4 100644 --- a/include/openbabel/forcefield.h +++ b/include/openbabel/forcefield.h @@ -912,56 +912,56 @@ const double GAS_CONSTANT = 8.31446261815324e-3 / KCAL_TO_KJ; //!< kcal mol^-1 * OBFF_LOGLVL_MEDIUM: energy for individual energy terms \n * OBFF_LOGLVL_HIGH: energy for individual energy interactions \n */ - virtual double Energy(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double Energy(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Bond stretching energy. * \par Output to log: * see Energy() */ - virtual double E_Bond(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_Bond(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Angle bending energy. * \par Output to log: * see Energy() */ - virtual double E_Angle(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_Angle(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Stretch bending energy. * \par Output to log: * see Energy() */ - virtual double E_StrBnd(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_StrBnd(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Torsional energy. * \par Output to log: * see Energy() */ - virtual double E_Torsion(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_Torsion(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Out-Of-Plane bending energy. * \par Output to log: * see Energy() */ - virtual double E_OOP(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_OOP(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Van der Waals energy. * \par Output to log: * see Energy() */ - virtual double E_VDW(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_VDW(bool /*gradients*/ = true) { return 0.0f; } /*! \param gradients Set to true when the gradients need to be calculated * (needs to be done before calling GetGradient()). * \return Electrostatic energy. * \par Output to log: * see Energy() */ - virtual double E_Electrostatic(bool UNUSED(gradients) = true) { return 0.0f; } + virtual double E_Electrostatic(bool /*gradients*/ = true) { return 0.0f; } //@} ///////////////////////////////////////////////////////////////////////// diff --git a/include/openbabel/kinetics.h b/include/openbabel/kinetics.h index e9418575ce..16cd87b565 100644 --- a/include/openbabel/kinetics.h +++ b/include/openbabel/kinetics.h @@ -41,7 +41,7 @@ class OBRateData : public OBGenericData double TroeParams[4]; std::map Efficiencies; public: - OBGenericData* Clone(OBBase* parent) const override { return new OBRateData(*this); } + OBGenericData* Clone(OBBase* /*parent*/) const override { return new OBRateData(*this); } enum rate_type {A, n, E}; enum reaction_type {ARRHENIUS=55555, LINDERMANN, TROE, SRI, THREEBODY}; reaction_type ReactionType; @@ -141,7 +141,7 @@ class OBNasaThermoData : public OBGenericData OBNasaThermoData(): LoT(300),MidT(1000),HiT(3000),phase('G') { _type = ThermoData; _attr = "Nasa thermo data";} - OBGenericData* Clone(OBBase* parent) const override { return new OBNasaThermoData(*this); } + OBGenericData* Clone(OBBase* /*parent*/) const override { return new OBNasaThermoData(*this); } double GetCoeff(unsigned n) const { diff --git a/include/openbabel/lineend.h b/include/openbabel/lineend.h index f9e1e15054..2bea41d02b 100644 --- a/include/openbabel/lineend.h +++ b/include/openbabel/lineend.h @@ -71,7 +71,7 @@ namespace OpenBabel //Pass the random acess functions to the source rdbuf and synchronize virtual std::streampos seekoff(std::streamoff off, std::ios_base::seekdir way, - std::ios_base::openmode which = std::ios_base::in | std::ios_base::out ) + std::ios_base::openmode /*which*/ = std::ios_base::in | std::ios_base::out ) { setg( &myBuffer , &myBuffer , &myBuffer ) ; //ensure next character is from new position mySource->seekg(off, way); @@ -81,7 +81,7 @@ namespace OpenBabel }; virtual std::streampos seekpos(std::streampos sp, - std::ios_base::openmode which = std::ios_base::in | std::ios_base::out ) + std::ios_base::openmode /*which*/ = std::ios_base::in | std::ios_base::out ) { setg( &myBuffer , &myBuffer , &myBuffer ) ; //slight hack - if mySource has read past the end, won't let us seek diff --git a/include/openbabel/rotor.h b/include/openbabel/rotor.h index 92d9372c1a..94d66f9508 100644 --- a/include/openbabel/rotor.h +++ b/include/openbabel/rotor.h @@ -24,15 +24,6 @@ GNU General Public License for more details. #include #include -#ifdef UNUSED -#elif (__GNUC__ == 4) -# define UNUSED(x) UNUSED_ ## x __attribute__((unused)) -#elif defined(__LCLINT__) -# define UNUSED(x) /*@unused@*/ x -#else -# define UNUSED(x) x -#endif - namespace OpenBabel { class OBRing; @@ -426,7 +417,7 @@ namespace OpenBabel ///@{ /** @deprecated Has no effect. */ OB_DEPRECATED_MSG("Has no effect.") - void SetDelta(double UNUSED(d)) {} + void SetDelta(double) {} /** @deprecated Has no effect. */ OB_DEPRECATED_MSG("Has no effect.") double GetDelta() { return 10.0; } @@ -450,7 +441,7 @@ namespace OpenBabel std::vector &GetResolution() { return _torsionAngles; } /** @deprecated */ OB_DEPRECATED - void SetNumCoords(int UNUSED(nc)) {} + void SetNumCoords(int) {} ///@} ; // Added to workaround https://github.com/swig/swig/issues/1636 diff --git a/include/openbabel/typer.h b/include/openbabel/typer.h index 7ed1dadfd2..0cf80eb1e7 100644 --- a/include/openbabel/typer.h +++ b/include/openbabel/typer.h @@ -43,11 +43,11 @@ class OBAPI OBAtomTyper : public OBGlobalDataBase public: OBAtomTyper(); - OBAtomTyper(const OBAtomTyper& rhs) {abort();} + OBAtomTyper(const OBAtomTyper& /*rhs*/) {abort();} ~OBAtomTyper(); //swig is requiring these, but I can't figure out how to make it not, so definte with abort - const OBAtomTyper& operator=(const OBAtomTyper& rhs) {abort();} + const OBAtomTyper& operator=(const OBAtomTyper& /*rhs*/) {abort();} void ParseLine(const char*) override; //! \return the number of internal hybridization rules diff --git a/include/openbabel/xml.h b/include/openbabel/xml.h index fc071c2ce7..afdb76601f 100644 --- a/include/openbabel/xml.h +++ b/include/openbabel/xml.h @@ -161,8 +161,8 @@ namespace OpenBabel public: ~XMLBaseFormat(){} virtual const char* NamespaceURI()const=0; - virtual bool DoElement(const std::string& ElName){return false;}; - virtual bool EndElement(const std::string& ElName){return false;}; + virtual bool DoElement(const std::string& /*ElName*/){return false;}; + virtual bool EndElement(const std::string& /*ElName*/){return false;}; /// The tag at the end of the chemical object e.g. "/molecule>" virtual const char* EndTag(){return ">";}; diff --git a/src/GUI/OBGUI.cpp b/src/GUI/OBGUI.cpp index 2aa14dcb09..8d0028f6ae 100644 --- a/src/GUI/OBGUI.cpp +++ b/src/GUI/OBGUI.cpp @@ -391,7 +391,7 @@ OBGUIFrame::OBGUIFrame(const wxString& title, wxPoint position, wxSize size) //****************************************************** //********** Event handlers **************************** -void OBGUIFrame::OnClose(wxCloseEvent& event) +void OBGUIFrame::OnClose(wxCloseEvent& /*event*/) { //Save the window size, in and out formats, and various options, for use next time. wxCommandEvent ev; @@ -406,7 +406,7 @@ void OBGUIFrame::OnClose(wxCloseEvent& event) this->Destroy(); } -void OBGUIFrame::OnSaveConfig(wxCommandEvent& event) +void OBGUIFrame::OnSaveConfig(wxCommandEvent& /*event*/) { //Save the window size, in and out formats, and various options, for use next time. wxConfig config(_T("OpenBabelGUI")); @@ -522,7 +522,7 @@ void OBGUIFrame::OnAbout(wxCommandEvent& WXUNUSED(event)) wxMessageBox(msg, _T("About OpenBabelGUI"), wxOK | wxICON_INFORMATION | wxCENTER, this); } -void OBGUIFrame::OnShowDataDir(wxCommandEvent& (event)) +void OBGUIFrame::OnShowDataDir(wxCommandEvent& /*event*/) { wxString dir = wxGetenv(_T("BABEL_DATADIR")); wxDirDialog dia(this, _T("BABEL_DATADIR = ")+ dir, dir, @@ -533,7 +533,7 @@ void OBGUIFrame::OnShowDataDir(wxCommandEvent& (event)) /////////////////////////////////////////// -void OBGUIFrame::OnSelectFormats(wxCommandEvent& event) +void OBGUIFrame::OnSelectFormats(wxCommandEvent& /*event*/) { if(m_ActiveFormats.SelectFormats()) { @@ -542,11 +542,11 @@ void OBGUIFrame::OnSelectFormats(wxCommandEvent& event) GetAvailableFormats(); } } -void OBGUIFrame::OnRestrictFormats(wxCommandEvent& event) +void OBGUIFrame::OnRestrictFormats(wxCommandEvent& /*event*/) { GetAvailableFormats(); } -void OBGUIFrame::OnSetDisplayFile(wxCommandEvent& event) +void OBGUIFrame::OnSetDisplayFile(wxCommandEvent& /*event*/) { wxTextEntryDialog dialog(this, _T("Enter display command and temporary display file on separate lines"), _T("Parameters for structure display"), m_DisplayCmd + _T('\n') + m_DisplayFile, @@ -559,7 +559,7 @@ void OBGUIFrame::OnSetDisplayFile(wxCommandEvent& event) } } -void OBGUIFrame::OnSetMinSize(wxCommandEvent& event) +void OBGUIFrame::OnSetMinSize(wxCommandEvent& /*event*/) { SetSize(872, 249); } @@ -1057,7 +1057,7 @@ BEGIN_EVENT_TABLE(CFilenames,wxTextCtrl) EVT_CHAR(CFilenames::OnKeyPress) END_EVENT_TABLE() -void CFilenames::OnDblClick(wxMouseEvent& event) +void CFilenames::OnDblClick(wxMouseEvent& /*event*/) { //extract double-clicked filename OBGUIFrame* frame = static_cast(GetParent()->GetParent()); diff --git a/src/charges/qeq.cpp b/src/charges/qeq.cpp index 8042b401ae..911a3a109f 100644 --- a/src/charges/qeq.cpp +++ b/src/charges/qeq.cpp @@ -157,7 +157,7 @@ namespace OpenBabel } //!Returns a triple of numbers: electronegativity (in eV), hardness (in eV), and Gaussian exponent (in bohr^-2) - Eigen::Vector3d QEqCharges::GetParameters(unsigned int Z, int Q) + Eigen::Vector3d QEqCharges::GetParameters(unsigned int Z, int /*Q*/) { Eigen::Vector3d P; //For now, completely ignore the formal charge diff --git a/src/charges/qtpie.cpp b/src/charges/qtpie.cpp index 7454734f7f..b1ba976fd2 100644 --- a/src/charges/qtpie.cpp +++ b/src/charges/qtpie.cpp @@ -148,7 +148,7 @@ QTPIECharges theQTPIECharges("qtpie"); //Global instance } } - Eigen::Vector3d QTPIECharges::GetParameters(unsigned int Z, int Q) + Eigen::Vector3d QTPIECharges::GetParameters(unsigned int Z, int /*Q*/) { //Returns a triple of numbers: electronegativity (in eV), hardness (in eV), and Gaussian exponent (in bohr^-2) diff --git a/src/conformersearch.cpp b/src/conformersearch.cpp index bd26ac0115..ede58e7de6 100644 --- a/src/conformersearch.cpp +++ b/src/conformersearch.cpp @@ -55,7 +55,7 @@ namespace OpenBabel { OBConformerFilter::~OBConformerFilter() {} - bool OBStericConformerFilter::IsGood(const OBMol &mol, const RotorKey &key, double *conformer) + bool OBStericConformerFilter::IsGood(const OBMol &mol, const RotorKey & /*key*/, double *conformer) { unsigned int a1 = 0, a2 = 0; unsigned int numAtoms = mol.NumAtoms(); @@ -104,7 +104,7 @@ namespace OpenBabel { OBConformerScore::~OBConformerScore() {} double OBRMSDConformerScore::Score(OBMol &mol, unsigned int index, - const RotorKeys &keys, const std::vector &conformers) + const RotorKeys & /*keys*/, const std::vector &conformers) { unsigned int numAtoms = mol.NumAtoms(); @@ -228,7 +228,7 @@ namespace OpenBabel { } double OBMinimizingRMSDConformerScore::Score(OBMol &mol, unsigned int index, - const RotorKeys &keys, const std::vector &conformers) + const RotorKeys & /*keys*/, const std::vector &conformers) { unsigned int numAtoms = mol.NumAtoms(); double *origCoords = mol.GetCoordinates(); diff --git a/src/depict/asciipainter.cpp b/src/depict/asciipainter.cpp index 5f78976df6..e7ea1b4aca 100644 --- a/src/depict/asciipainter.cpp +++ b/src/depict/asciipainter.cpp @@ -51,24 +51,24 @@ namespace OpenBabel return true; } - void ASCIIPainter::SetFontSize(int pointSize) + void ASCIIPainter::SetFontSize(int /*pointSize*/) { } - void ASCIIPainter::SetFillColor(const OBColor &color) + void ASCIIPainter::SetFillColor(const OBColor &/*color*/) { } - void ASCIIPainter::SetFillRadial(const OBColor &start, const OBColor &end) + void ASCIIPainter::SetFillRadial(const OBColor &/*start*/, const OBColor &/*end*/) { } - void ASCIIPainter::SetPenColor(const OBColor &color) + void ASCIIPainter::SetPenColor(const OBColor &/*color*/) { } - void ASCIIPainter::SetPenWidth(double width) + void ASCIIPainter::SetPenWidth(double /*width*/) { } @@ -77,7 +77,7 @@ namespace OpenBabel return 0.0; } - void ASCIIPainter::DrawLine(double x1, double y1, double x2, double y2, const std::vector & dashes) + void ASCIIPainter::DrawLine(double x1, double y1, double x2, double y2, const std::vector & /*dashes*/) { vector > coords; vector >::iterator vp_it; @@ -103,11 +103,11 @@ namespace OpenBabel DrawLine(vp_it->first, vp_it->second, points.begin()->first, points.begin()->second); } - void ASCIIPainter::DrawCircle(double x, double y, double r) + void ASCIIPainter::DrawCircle(double /*x*/, double /*y*/, double /*r*/) { } - void ASCIIPainter::DrawBall(double x, double y, double r, double opacity) + void ASCIIPainter::DrawBall(double /*x*/, double /*y*/, double /*r*/, double /*opacity*/) { } @@ -121,7 +121,7 @@ namespace OpenBabel } } - OBFontMetrics ASCIIPainter::GetFontMetrics(const std::string &text) + OBFontMetrics ASCIIPainter::GetFontMetrics(const std::string & /*text*/) { OBFontMetrics metrics; // The following line tries to workaround the fact that fontSize is an int diff --git a/src/depict/cairopainter.cpp b/src/depict/cairopainter.cpp index 1474ffc73a..618b77b818 100644 --- a/src/depict/cairopainter.cpp +++ b/src/depict/cairopainter.cpp @@ -99,7 +99,7 @@ namespace OpenBabel cairo_set_source_rgb(m_cairo, color.red, color.green, color.blue); } - void CairoPainter::SetFillRadial(const OBColor &start, const OBColor &end) + void CairoPainter::SetFillRadial(const OBColor & /*start*/, const OBColor &end) { cairo_set_source_rgb(m_cairo, end.red, end.green, end.blue); } @@ -183,7 +183,7 @@ namespace OpenBabel return CAIRO_STATUS_SUCCESS; } - void CairoPainter::DrawBall(double x, double y, double r, double opacity) + void CairoPainter::DrawBall(double /*x*/, double /*y*/, double /*r*/, double /*opacity*/) { } diff --git a/src/depict/commandpainter.cpp b/src/depict/commandpainter.cpp index 3eb72f65ef..b1b8ecbb3f 100644 --- a/src/depict/commandpainter.cpp +++ b/src/depict/commandpainter.cpp @@ -112,7 +112,7 @@ namespace OpenBabel m_ofs << "DrawCircle " << x << " " << y << " radius " << r << endl; } - void CommandPainter::DrawBall(double x, double y, double r, double opacity) + void CommandPainter::DrawBall(double x, double y, double r, double /*opacity*/) { m_ofs << "DrawBall " << x << " " << y << " radius " << r << endl; } @@ -122,7 +122,7 @@ namespace OpenBabel m_ofs << "DrawText " << x << " " << y << " \"" << text << "\"" << endl; } - OBFontMetrics CommandPainter::GetFontMetrics(const std::string &text) + OBFontMetrics CommandPainter::GetFontMetrics(const std::string& /*text*/) { OBFontMetrics metrics; metrics.fontSize = 0; diff --git a/src/depict/depict.cpp b/src/depict/depict.cpp index 20dbdbe71d..a0b052f333 100644 --- a/src/depict/depict.cpp +++ b/src/depict/depict.cpp @@ -893,7 +893,7 @@ namespace OpenBabel end.x() + spacing.x() - offset.x(), end.y() + spacing.y() - offset.y()); } - void OBDepictPrivate::DrawAtom(OBAtom *atom) + void OBDepictPrivate::DrawAtom(OBAtom * /*atom*/) { } @@ -1065,7 +1065,7 @@ namespace OpenBabel } } void OBDepictPrivateBallAndStick::DrawSimpleBond(OBAtom* beginAtom, - OBAtom* endAtom, int order, bool crossed_bond) + OBAtom* endAtom, int order, bool /*crossed_bond*/) { const vector3 begin = beginAtom->GetVector(); const vector3 end = endAtom->GetVector(); @@ -1221,7 +1221,7 @@ OBBitVec& drawnBonds) } } - inline void OBDepictPrivateBallAndStick::DrawAromaticRingBond(OBAtom *prevAtom, OBAtom *beginAtom, OBAtom *endAtom, OBAtom *nextAtom, const vector3 ¢er, double dist) + inline void OBDepictPrivateBallAndStick::DrawAromaticRingBond(OBAtom *prevAtom, OBAtom *beginAtom, OBAtom *endAtom, OBAtom *nextAtom, const vector3 & /*center*/, double /*dist*/) { const vector3 prev = prevAtom->GetVector(); const vector3 begin = beginAtom->GetVector(); diff --git a/src/depict/svgpainter.cpp b/src/depict/svgpainter.cpp index 0c3ec53cf8..00b8f39cc0 100644 --- a/src/depict/svgpainter.cpp +++ b/src/depict/svgpainter.cpp @@ -170,7 +170,7 @@ namespace OpenBabel return metrics; } - void SVGPainter::WriteImage(const std::string &filename) + void SVGPainter::WriteImage(const std::string &/*filename*/) { } diff --git a/src/descriptors/cansmidescriptor.cpp b/src/descriptors/cansmidescriptor.cpp index 78961e18b4..e5e4ad8c6e 100644 --- a/src/descriptors/cansmidescriptor.cpp +++ b/src/descriptors/cansmidescriptor.cpp @@ -39,7 +39,7 @@ class CanSmiles : public OBDescriptor bool _noStereo; }; -bool CanSmiles::Compare(OBBase* pOb, istream& optionText, bool noEval, string* param) +bool CanSmiles::Compare(OBBase* pOb, istream& optionText, bool noEval, string* /*param*/) { string can; GetStringValue(pOb, can); diff --git a/src/descriptors/cmpdfilter.cpp b/src/descriptors/cmpdfilter.cpp index 74661e14c3..51c0bfb1fe 100644 --- a/src/descriptors/cmpdfilter.cpp +++ b/src/descriptors/cmpdfilter.cpp @@ -71,7 +71,7 @@ class CompoundFilter : public OBDescriptor } ///Returns the result of evaluating the conditional expressions in the macrotext - bool Compare(OBBase* pOb, istream&, bool noEval, string* param) override + bool Compare(OBBase* pOb, istream&, bool noEval, string* /*param*/) override { stringstream ss; ss.str(_macroText); diff --git a/src/descriptors/filters.cpp b/src/descriptors/filters.cpp index 572e703016..5c9498586c 100644 --- a/src/descriptors/filters.cpp +++ b/src/descriptors/filters.cpp @@ -32,7 +32,7 @@ class MWFilter : public OBDescriptor { public: MWFilter(const char *ID) : OBDescriptor(ID){}; const char *Description() override { return "Molecular Weight filter"; } - double Predict(OBBase *pOb, string *param = nullptr) override { + double Predict(OBBase *pOb, string * /*param*/ = nullptr) override { OBMol *pmol = dynamic_cast(pOb); if (!pmol) return 0; @@ -46,7 +46,7 @@ class RotatableBondsFilter : public OBDescriptor { public: RotatableBondsFilter(const char *ID) : OBDescriptor(ID){}; const char *Description() override { return "Rotatable bonds filter"; } - double Predict(OBBase *pOb, string *param = nullptr) override { + double Predict(OBBase *pOb, string * /*param*/ = nullptr) override { OBMol *pmol = dynamic_cast(pOb); if (!pmol) return 0; @@ -152,7 +152,7 @@ class FormulaDescriptor : public OBDescriptor { const char *Description() override { return "Chemical formula"; } double GetStringValue(OBBase *pOb, std::string &svalue, - std::string *param = nullptr) override { + std::string * /*param*/ = nullptr) override { OBMol *pmol = dynamic_cast(pOb); if (pmol) svalue = pmol->GetSpacedFormula(1, ""); // actually unspaced diff --git a/src/descriptors/groupcontrib.cpp b/src/descriptors/groupcontrib.cpp index 3fc3c1616f..8173d33e9f 100644 --- a/src/descriptors/groupcontrib.cpp +++ b/src/descriptors/groupcontrib.cpp @@ -125,7 +125,7 @@ namespace OpenBabel } - double OBGroupContrib::Predict(OBBase* pOb, string* param) + double OBGroupContrib::Predict(OBBase* pOb, string* /*param*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/descriptors/smartsdescriptors.cpp b/src/descriptors/smartsdescriptors.cpp index 1d25a4daeb..5952185334 100644 --- a/src/descriptors/smartsdescriptors.cpp +++ b/src/descriptors/smartsdescriptors.cpp @@ -45,7 +45,7 @@ namespace OpenBabel return txt.c_str(); } - double Predict(OBBase* pOb, string* param=nullptr) override + double Predict(OBBase* pOb, string* /*param*/ = nullptr) override { OBMol* pmol = dynamic_cast (pOb); if(!pmol) diff --git a/src/dlhandler_unix.cpp b/src/dlhandler_unix.cpp index 09519cabec..41b1302158 100644 --- a/src/dlhandler_unix.cpp +++ b/src/dlhandler_unix.cpp @@ -72,7 +72,7 @@ bool DLHandler::getConvDirectory(string& convPath) } int DLHandler::findFiles (std::vector & file_list, - const std::string& pattern, + const std::string& /*pattern*/, const std::string& path) { vector paths, vs; diff --git a/src/fingerprints/finger2.cpp b/src/fingerprints/finger2.cpp index 9ed65c000d..26f85db592 100644 --- a/src/fingerprints/finger2.cpp +++ b/src/fingerprints/finger2.cpp @@ -65,7 +65,7 @@ class fingerprint2 : public OBFingerprint For the rest, even when stopped by encountering atoms already visited 0 , atno(1), bo(1)(2), atno(2), bo(2)(3),...atno(n) **/ - std::string DescribeBits(const std::vector fp, bool bSet=true) override + std::string DescribeBits(const std::vector /*fp*/, bool /*bSet*/ = true) override { return _ss.str(); } unsigned int Flags() override { return _flags; } diff --git a/src/fingerprints/fingerecfp.cpp b/src/fingerprints/fingerecfp.cpp index c28687e378..0914bbe588 100644 --- a/src/fingerprints/fingerecfp.cpp +++ b/src/fingerprints/fingerecfp.cpp @@ -50,7 +50,7 @@ class fingerprintECFP : public OBFingerprint bool GetFingerprint(OBBase* pOb, vector&fp, int nbits=0) override; /// \returns fragment info unless SetFlags(OBFingerprint::FPT_NOINFO) has been called before GetFingerprint() called. - std::string DescribeBits(const std::vector fp, bool bSet=true) override + std::string DescribeBits(const std::vector /*fp*/, bool /*bSet*/ =true) override { return _ss.str(); } unsigned int Flags() override { return _flags; } diff --git a/src/forcefield.cpp b/src/forcefield.cpp index e314f002a4..b4e1d9c492 100644 --- a/src/forcefield.cpp +++ b/src/forcefield.cpp @@ -2735,7 +2735,7 @@ namespace OpenBabel delete atom; } - void OBForceField::SteepestDescentInitialize(int steps, double econv, int method) + void OBForceField::SteepestDescentInitialize(int steps, double econv, int /*method*/) { if (!_validSetup) return; @@ -2861,7 +2861,7 @@ namespace OpenBabel } void OBForceField::ConjugateGradientsInitialize(int steps, double econv, - int method) + int /*method*/) { if (!_validSetup || steps==0) return; @@ -3509,7 +3509,7 @@ namespace OpenBabel //cout << "E_{kin_corr} = sum( m_i * v_i^2 ) = " << E_kin2 << endl; } - void OBForceField::MolecularDynamicsTakeNSteps(int n, double T, double timestep, int method) + void OBForceField::MolecularDynamicsTakeNSteps(int n, double T, double timestep, int /*method*/) { if (!_validSetup) return; diff --git a/src/formats/MCDLformat.cpp b/src/formats/MCDLformat.cpp index 6e129a65be..1ff727c3b9 100644 --- a/src/formats/MCDLformat.cpp +++ b/src/formats/MCDLformat.cpp @@ -176,7 +176,7 @@ class MCDLFormat : public OBMoleculeFormat /* Create descriptor connectivity string from connectivity table of fragments */ - string MCDLFormat::constring(int conntab [MAXBONDS][4], char * tstr) + string MCDLFormat::constring(int conntab [MAXBONDS][4], char * /*tstr*/) { int i,j,k,n,nn,icons[6],comma; char line[82],semis[100]; @@ -481,7 +481,7 @@ class MCDLFormat : public OBMoleculeFormat - string MCDLFormat::getMCDL(OBMol* pmol, bool includeCoordinates) { + string MCDLFormat::getMCDL(OBMol* pmol, bool /*includeCoordinates*/) { int i=0; int j=0; int k=0; @@ -947,7 +947,7 @@ class MCDLFormat : public OBMoleculeFormat return data; }; - void MCDLFormat::restoreFullMCDL(string value, OBMol* pmol) { + void MCDLFormat::restoreFullMCDL(string /*value*/, OBMol* /*pmol*/) { }; diff --git a/src/formats/acrformat.cpp b/src/formats/acrformat.cpp index 54d843c718..92195eee56 100644 --- a/src/formats/acrformat.cpp +++ b/src/formats/acrformat.cpp @@ -66,7 +66,7 @@ namespace OpenBabel return READONEONLY | NOTWRITABLE; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/adfformat.cpp b/src/formats/adfformat.cpp index 357579d65a..e3c4b3bea7 100644 --- a/src/formats/adfformat.cpp +++ b/src/formats/adfformat.cpp @@ -280,7 +280,7 @@ namespace OpenBabel { //*** This section identical for most OBMol conversions *** //////////////////////////////////////////////////// /// The "API" interface functions - bool ReadMolecule(OBBase* pOb, OBConversion* pConv) override + bool ReadMolecule(OBBase* /*pOb*/, OBConversion* /*pConv*/) override { return false; } bool WriteMolecule(OBBase* pOb, OBConversion* pConv) override; @@ -685,7 +685,7 @@ class OBT41Format : public OBMoleculeFormat } /// Skip to object: used for multi-object file formats. - int SkipObjects(int n, OBConversion* pConv) override { return 0; } + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } /// Read. bool ReadMolecule(OBBase* pOb, OBConversion* pConv) override; @@ -726,7 +726,7 @@ class OBT41Format : public OBMoleculeFormat /// Add grids from SCF - void AddSCFGrids( istream& is, OBGridData& t41 ) {} + void AddSCFGrids( istream& /*is*/, OBGridData& /*t41*/ ) {} ///Inner class used to hold atomic number, coordinate, charge data struct AtomData @@ -811,7 +811,7 @@ bool OBT41Format::ReadMolecule( OBBase* pOb, OBConversion* pConv ) return ReadASCII(pOb, pConv); } -bool OBT41Format::ReadBinary( OBBase* pOb, OBConversion* pConv ) +bool OBT41Format::ReadBinary(OBBase* /*pOb*/, OBConversion* /*pConv*/) { obErrorLog.ThrowError( __FUNCTION__, "OpenBabel does not currently support the TAPE41 binary format. Please use dmpkf to convert to ASCII.", obError ); return false; diff --git a/src/formats/castepformat.cpp b/src/formats/castepformat.cpp index e2d9191311..f161c558c3 100644 --- a/src/formats/castepformat.cpp +++ b/src/formats/castepformat.cpp @@ -55,7 +55,7 @@ namespace OpenBabel { return READONEONLY | NOTWRITABLE; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/chemdrawcdx.cpp b/src/formats/chemdrawcdx.cpp index f16a5fe7f7..8cc6042012 100644 --- a/src/formats/chemdrawcdx.cpp +++ b/src/formats/chemdrawcdx.cpp @@ -207,7 +207,7 @@ At the end, any OBMol in the map not marked as Used is output as an OBMol. */ -bool ChemDrawBinaryXFormat::ReadMolecule(OBBase* pOb, OBConversion* pConv) +bool ChemDrawBinaryXFormat::ReadMolecule(OBBase* /*pOb*/, OBConversion* pConv) { _molmap.clear(); _graphicmap.clear(); @@ -465,7 +465,7 @@ bool ChemDrawBinaryXFormat::DoFragment(CDXReader& cdxr, OBMol* pmol) } bool ChemDrawBinaryXFormat::DoFragmentImpl(CDXReader& cdxr, OBMol* pmol, - map& atommap, map& updown) + map& atommap, map& /*updown*/) { CDXTag tag; std::vector handleImplicitCarbons; diff --git a/src/formats/gamessukformat.cpp b/src/formats/gamessukformat.cpp index 414f479ed7..76e5d3c48f 100644 --- a/src/formats/gamessukformat.cpp +++ b/src/formats/gamessukformat.cpp @@ -312,7 +312,7 @@ namespace OpenBabel return true; } - bool GAMESSUKFormat::ReadLineZmatrix(OBMol &mol, OBAtom *atom, vector &tokens, double factor, int *zmatLineCount) + bool GAMESSUKFormat::ReadLineZmatrix(OBMol &mol, OBAtom *atom, vector &tokens, double /*factor*/, int *zmatLineCount) { /* * Read a line from a GAMESS-UK input defining an atom in Inernal Coordinates. diff --git a/src/formats/gausscubeformat.cpp b/src/formats/gausscubeformat.cpp index eabe729ad4..22a5c3281e 100644 --- a/src/formats/gausscubeformat.cpp +++ b/src/formats/gausscubeformat.cpp @@ -83,7 +83,7 @@ namespace OpenBabel const char* GetMIMEType() override { return nullptr; } // Skip to object: used for multi-object file formats. - int SkipObjects(int n, OpenBabel::OBConversion* pConv) override { return 0; } + int SkipObjects(int /*n*/, OpenBabel::OBConversion* /*pConv*/) override { return 0; } unsigned int Flags() override { diff --git a/src/formats/gulpformat.cpp b/src/formats/gulpformat.cpp index 344053b0eb..054dc19b59 100644 --- a/src/formats/gulpformat.cpp +++ b/src/formats/gulpformat.cpp @@ -54,7 +54,7 @@ namespace OpenBabel { return READONEONLY | NOTWRITABLE; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/lpmdformat.cpp b/src/formats/lpmdformat.cpp index 9d4b647afe..68812e50a9 100644 --- a/src/formats/lpmdformat.cpp +++ b/src/formats/lpmdformat.cpp @@ -59,7 +59,7 @@ class LpmdFormat : public OBMoleculeFormat //Optional const char* GetMIMEType() override { return "chemical/lpmd"; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } @@ -94,7 +94,7 @@ class LpmdFormat : public OBMoleculeFormat LpmdFormat theLpmdFormat; -bool LpmdFormat::ReadHeader( std::istream &ifs, OBMol &mol ) +bool LpmdFormat::ReadHeader(std::istream &ifs, OBMol & /*mol*/) { //Header Line if( ! ifs.getline(buffer,BUFF_SIZE) ) diff --git a/src/formats/mdffformat.cpp b/src/formats/mdffformat.cpp index af7b112874..90ed3168c8 100644 --- a/src/formats/mdffformat.cpp +++ b/src/formats/mdffformat.cpp @@ -75,7 +75,7 @@ namespace OpenBabel { return READONEONLY; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/mdlformat.cpp b/src/formats/mdlformat.cpp index 2c9dd86318..272150d793 100644 --- a/src/formats/mdlformat.cpp +++ b/src/formats/mdlformat.cpp @@ -953,7 +953,7 @@ namespace OpenBabel // If this atom should be considered an RGroup Alias this function // returns 0 or a positive integer, but -1 otherwise - static int GetNumberedRGroup(OBMol* pmol, OBAtom* atom) + static int GetNumberedRGroup(OBMol* /*pmol*/, OBAtom* atom) { if (atom->GetAtomicNum() == 0) { // Must be a pseudoatom if(atom->HasData(AliasDataType)) { @@ -1417,7 +1417,7 @@ namespace OpenBabel ////////////////////////////////////////////////////// - bool MDLFormat::ReadV3000Block(istream& ifs, OBMol& mol, OBConversion* pConv,bool DoMany) + bool MDLFormat::ReadV3000Block(istream& ifs, OBMol& mol, OBConversion* pConv, bool /*DoMany*/) { bool ret = true; do @@ -1482,7 +1482,7 @@ namespace OpenBabel } ////////////////////////////////////////////////////// - bool MDLFormat::ReadAtomBlock(istream& ifs,OBMol& mol, OBConversion* pConv) + bool MDLFormat::ReadAtomBlock(istream& ifs, OBMol& mol, OBConversion* /*pConv*/) { OBAtom atom; bool chiralWatch=false; @@ -1559,7 +1559,7 @@ namespace OpenBabel } ////////////////////////////////////////////////////// - bool MDLFormat::ReadBondBlock(istream& ifs,OBMol& mol, OBConversion* pConv) + bool MDLFormat::ReadBondBlock(istream& ifs, OBMol& mol, OBConversion* /*pConv*/) { for(;;) { @@ -1600,7 +1600,7 @@ namespace OpenBabel } //////////////////////////////////////////////////////////// - bool MDLFormat::ReadUnimplementedBlock(istream& ifs,OBMol& mol, OBConversion* pConv, string& blockname) + bool MDLFormat::ReadUnimplementedBlock(istream& ifs, OBMol& /*mol*/, OBConversion* /*pConv*/, string& blockname) { //Not currently implemented obErrorLog.ThrowError(__FUNCTION__, @@ -1616,7 +1616,7 @@ namespace OpenBabel } //////////////////////////////////////////////////////////// - bool MDLFormat::ReadRGroupBlock(istream& ifs,OBMol& mol, OBConversion* pConv) + bool MDLFormat::ReadRGroupBlock(istream& ifs, OBMol& /*mol*/, OBConversion* /*pConv*/) { //Not currently implemented obErrorLog.ThrowError(__FUNCTION__, @@ -1633,7 +1633,7 @@ namespace OpenBabel } ////////////////////////////////////////////////////////// - bool MDLFormat::WriteV3000(ostream& ofs,OBMol& mol, OBConversion* pConv) + bool MDLFormat::WriteV3000(ostream& ofs, OBMol& mol, OBConversion* /*pConv*/) { bool chiralFlag = GetChiralFlagFromGenericData(mol); diff --git a/src/formats/moldenformat.cpp b/src/formats/moldenformat.cpp index fbe4b2053a..1df943471e 100644 --- a/src/formats/moldenformat.cpp +++ b/src/formats/moldenformat.cpp @@ -88,7 +88,7 @@ class OBMoldenFormat : public OpenBabel::OBMoleculeFormat } /// Skip to object: used for multi-object file formats. - int SkipObjects(int n, OpenBabel::OBConversion* pConv) override { return 0; } + int SkipObjects(int /*n*/, OpenBabel::OBConversion* /*pConv*/) override { return 0; } /// Read. bool ReadMolecule(OpenBabel::OBBase* pOb, OpenBabel::OBConversion* pConv) override; diff --git a/src/formats/msmsformat.cpp b/src/formats/msmsformat.cpp index 98272f4255..4fed0c2af3 100644 --- a/src/formats/msmsformat.cpp +++ b/src/formats/msmsformat.cpp @@ -83,7 +83,7 @@ class OBMSMSFormat : public OpenBabel::OBMoleculeFormat } /// Skip to object: used for multi-object file formats. - int SkipObjects(int n, OpenBabel::OBConversion* pConv) override { return 0; } + int SkipObjects(int /*n*/, OpenBabel::OBConversion* /*pConv*/) override { return 0; } /// Read: always return false. bool ReadMolecule(OpenBabel::OBBase*, OpenBabel::OBConversion*) override diff --git a/src/formats/opendxformat.cpp b/src/formats/opendxformat.cpp index e369cd9e12..5d1cc67d94 100644 --- a/src/formats/opendxformat.cpp +++ b/src/formats/opendxformat.cpp @@ -67,7 +67,7 @@ namespace OpenBabel const char* GetMIMEType() override { return nullptr; } // Skip to object: used for multi-object file formats. - int SkipObjects(int n, OpenBabel::OBConversion* pConv) override { return 0; } + int SkipObjects(int /*n*/, OpenBabel::OBConversion* /*pConv*/) override { return 0; } unsigned int Flags() override { diff --git a/src/formats/pdbqtformat.cpp b/src/formats/pdbqtformat.cpp index bfdd6b6790..412e1a01c3 100644 --- a/src/formats/pdbqtformat.cpp +++ b/src/formats/pdbqtformat.cpp @@ -117,7 +117,7 @@ namespace OpenBabel //////////////////////////////////////////////////// /// Utility functions - static bool parseAtomRecord(char *buffer, OBMol & mol, int chainNum); + static bool parseAtomRecord(char *buffer, OBMol & mol, int /*chainNum*/); static bool IsRotBond_PDBQT(OBBond * the_bond); static bool IsIn(const vector& vec, const int num); static void OutputAtom(OBAtom* atom, ostream& ofs, unsigned int index); @@ -126,7 +126,7 @@ namespace OpenBabel static bool FindBondedPiece(const vector& root, const vector& branch, unsigned int& root_atom, unsigned int& branch_atom, unsigned int& root_atom_rank, unsigned int& branch_atom_rank, const OBMol& mol, unsigned int & atoms_moved); static bool OutputTree(OBConversion *pConv, OBMol& mol, ostream& ofs, map & tree, unsigned int depth, bool moves_many, bool preserve_original_index); - static void ConstructTree (map & tree, vector > rigid_fragments, unsigned int root_piece, const OBMol& mol, bool flexible); + static void ConstructTree(map & tree, vector> rigid_fragments, unsigned int root_piece, const OBMol& mol, bool /*flexible*/); static bool DeleteHydrogens(OBMol & mol); static bool Separate_preserve_charges(OBMol & mol, vector & result); static unsigned int FindFragments(OBMol mol, vector >& rigid_fragments); @@ -612,7 +612,7 @@ namespace OpenBabel return true; } - void ConstructTree (map & tree, vector > rigid_fragments, unsigned int root_piece, const OBMol& mol, bool flexible) + void ConstructTree(map & tree, vector> rigid_fragments, unsigned int root_piece, const OBMol& mol, bool /*flexible*/) { unsigned int first_atom = 0; unsigned int second_atom = 0; @@ -1056,7 +1056,7 @@ namespace OpenBabel ///////////////////////////////////////////////////////////////////////// - static bool parseAtomRecord(char *buffer, OBMol &mol,int chainNum) + static bool parseAtomRecord(char *buffer, OBMol &mol, int /*chainNum*/) /* ATOMFORMAT "(i5,1x,a4,a1,a3,1x,a1,i4,a1,3x,3f8.3,2f6.2,a2,a2)" */ { string sbuf = &buffer[6]; diff --git a/src/formats/pngformat.cpp b/src/formats/pngformat.cpp index 07849ba433..e3860e4c9b 100644 --- a/src/formats/pngformat.cpp +++ b/src/formats/pngformat.cpp @@ -210,7 +210,7 @@ PNGFormat thePNGFormat; ///////////////////////////////////////////////////////////////// -bool PNGFormat::ReadMolecule(OBBase* pOb, OBConversion* pConv) +bool PNGFormat::ReadMolecule(OBBase* /*pOb*/, OBConversion* pConv) { istream& ifs = *pConv->GetInStream(); if(pConv->IsFirstInput()) diff --git a/src/formats/pointcloudformat.cpp b/src/formats/pointcloudformat.cpp index 1caa56b6ab..219c500bdc 100644 --- a/src/formats/pointcloudformat.cpp +++ b/src/formats/pointcloudformat.cpp @@ -110,7 +110,7 @@ namespace OpenBabel } /// Skip to object: used for multi-object file formats. - int SkipObjects( int n, OpenBabel::OBConversion* pConv ) override { return 0; } + int SkipObjects( int /*n*/, OpenBabel::OBConversion* /*pConv*/ ) override { return 0; } /// Read: always return false. bool ReadMolecule(OpenBabel::OBBase*, OpenBabel::OBConversion*) override diff --git a/src/formats/povrayformat.cpp b/src/formats/povrayformat.cpp index 214a24e924..29cb1c8735 100644 --- a/src/formats/povrayformat.cpp +++ b/src/formats/povrayformat.cpp @@ -166,7 +166,7 @@ namespace OpenBabel //Make an instance of the format class PovrayFormat thePovrayFormat; - void PovrayFormat::OutputHeader(ostream &ofs, OBMol &mol, string prefix) + void PovrayFormat::OutputHeader(ostream &ofs, OBMol &mol, string /*prefix*/) { time_t akttime; /* Systemtime */ char timestr[TIME_STR_SIZE + 1] = ""; /* Timestring */ diff --git a/src/formats/pwscfformat.cpp b/src/formats/pwscfformat.cpp index 63acbc8069..baa239c2dc 100644 --- a/src/formats/pwscfformat.cpp +++ b/src/formats/pwscfformat.cpp @@ -58,7 +58,7 @@ namespace OpenBabel { return READONEONLY | NOTWRITABLE; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/rinchiformat.cpp b/src/formats/rinchiformat.cpp index 96f2d22b5f..2f33dea7ba 100644 --- a/src/formats/rinchiformat.cpp +++ b/src/formats/rinchiformat.cpp @@ -82,7 +82,7 @@ namespace OpenBabel ReactionInChIFormat theReactionInChIFormat; ///////////////////////////////////////////////////////////////// - bool ReactionInChIFormat::ReadMolecule(OBBase* pOb, OBConversion* pConv) + bool ReactionInChIFormat::ReadMolecule(OBBase* /*pOb*/, OBConversion* /*pConv*/) { return true; } diff --git a/src/formats/siestaformat.cpp b/src/formats/siestaformat.cpp index 5c037a5477..9aa7d9c852 100644 --- a/src/formats/siestaformat.cpp +++ b/src/formats/siestaformat.cpp @@ -54,7 +54,7 @@ namespace OpenBabel { return READONEONLY | NOTWRITABLE; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/smilesformat.cpp b/src/formats/smilesformat.cpp index 86efd9332f..59ee44ddef 100644 --- a/src/formats/smilesformat.cpp +++ b/src/formats/smilesformat.cpp @@ -2936,7 +2936,7 @@ namespace OpenBabel { const char* OBMol2Cansmi::GetTetrahedralStereo(OBCanSmiNode *node, vector &chiral_neighbors, - vector &symmetry_classes) + vector & /*symmetry_classes*/) { // If not enough chiral neighbors were passed in, we're done if (chiral_neighbors.size() < 4) @@ -2988,7 +2988,7 @@ namespace OpenBabel { const char* OBMol2Cansmi::GetSquarePlanarStereo(OBCanSmiNode *node, vector &chiral_neighbors, - vector &symmetry_classes) + vector & /*symmetry_classes*/) { // If no chiral neighbors were passed in, we're done if (chiral_neighbors.size() < 4) diff --git a/src/formats/smiley.h b/src/formats/smiley.h index 9d84b2fccd..9fb4f81cb3 100644 --- a/src/formats/smiley.h +++ b/src/formats/smiley.h @@ -646,17 +646,17 @@ namespace Smiley { * Set the chirality for an atom. This method is invoked when the entire * SMILES/SMARTS is parsed. */ - void setChiral(int index, Chirality chirality, const std::vector &chiralNbrs) {} + void setChiral(int /*index*/, Chirality /*chirality*/, const std::vector &/*chiralNbrs*/) {} //@} //@name SMILES /** * Invoked when an atom is completly parsed. */ - void addAtom(int element, bool aromatic, int isotope, int hCount, int charge, int atomClass) {} + void addAtom(int /*element*/, bool /*aromatic*/, int /*isotope*/, int /*hCount*/, int /*charge*/, int /*atomClass*/) {} /** * Invoked once both bon atom are added using addAtom(). */ - void addBond(int source, int target, int order, bool isUp, bool isDown) {} + void addBond(int /*source*/, int /*target*/, int /*order*/, bool /*isUp*/, bool /*isDown*/) {} //@} //@name SMARTS //@{ @@ -664,33 +664,33 @@ namespace Smiley { * Invoked when a unary or binary logical operator is parsed * (i.e. '&', ';' or ','). This method is also invoked for implicit AND. */ - void operation(int type) {} + void operation(int /*type*/) {} /** * Invoked when an unbracketed atom (i.e. organic subset) is parsed. */ - void addOrganicSubsetAtom(int element, bool aromatic) {} + void addOrganicSubsetAtom(int /*element*/, bool /*aromatic*/) {} /** * Invoked when an atom primitive is parsed. */ - void atomPrimitive(int type, int value) {} + void atomPrimitive(int /*type*/, int /*value*/) {} /** * Invoked when a bond primitive is parsed. This method is also invoked for * implicit bonds. */ - void bondPrimitive(int type) {} + void bondPrimitive(int /*type*/) {} /** * Invoked when a branch ends and the next bond should start from a * previously parsed atom expression with specified @p index. */ - void setPrevious(int index) {} + void setPrevious(int /*index*/) {} /** * Invoked when a new ring bond number is parsed. */ - void startRingBond(int number) {} + void startRingBond(int /*number*/) {} /** * Invoked when a prviously found ring bond number is parsed to add the bond. */ - void endRingBond(int number, int index) {} + void endRingBond(int /*number*/, int /*index*/) {} //@} }; @@ -1771,7 +1771,7 @@ namespace Smiley { } bool parseCharNumber(char chr, int type, int &parsedOp, - bool firstPrimitive, bool noDefault = false) + bool firstPrimitive, bool /*noDefault*/ = false) { if (DEBUG) std::cout << "parseCharNumber(" << m_str.substr(m_pos) << ")" << std::endl; diff --git a/src/formats/smileyformat.cpp b/src/formats/smileyformat.cpp index 41173972dc..58dd2487ad 100644 --- a/src/formats/smileyformat.cpp +++ b/src/formats/smileyformat.cpp @@ -61,7 +61,7 @@ namespace OpenBabel // prepare for new SMILES } - void addAtom(int element, bool aromatic, int isotope, int hCount, int charge, int atomClass) + void addAtom(int element, bool aromatic, int isotope, int hCount, int charge, int /*atomClass*/) { // invoked when an atom is completely parsed diff --git a/src/formats/stlformat.cpp b/src/formats/stlformat.cpp index 9946c25566..69ab8677c9 100644 --- a/src/formats/stlformat.cpp +++ b/src/formats/stlformat.cpp @@ -100,7 +100,7 @@ namespace OpenBabel } /// Skip to object: used for multi-object file formats. - int SkipObjects(int n, OpenBabel::OBConversion* pConv) override { return 0; } + int SkipObjects(int /*n*/, OpenBabel::OBConversion* /*pConv*/) override { return 0; } /// Read: always return false. bool ReadMolecule(OpenBabel::OBBase*, OpenBabel::OBConversion*) override diff --git a/src/formats/vaspformat.cpp b/src/formats/vaspformat.cpp index 3bbc96dad2..a65506c2e5 100644 --- a/src/formats/vaspformat.cpp +++ b/src/formats/vaspformat.cpp @@ -123,7 +123,7 @@ namespace OpenBabel { return READONEONLY | WRITEONEONLY; } - int SkipObjects(int n, OBConversion* pConv) override + int SkipObjects(int /*n*/, OBConversion* /*pConv*/) override { return 0; } diff --git a/src/formats/xml/cmlformat.cpp b/src/formats/xml/cmlformat.cpp index 50c19ec9df..d32f59f3b5 100644 --- a/src/formats/xml/cmlformat.cpp +++ b/src/formats/xml/cmlformat.cpp @@ -1161,7 +1161,7 @@ namespace OpenBabel return true; } - bool CMLFormat::TransferElement(cmlArray& arr) + bool CMLFormat::TransferElement(cmlArray& /*arr*/) { //Reads the attributes of the current node, e.g. //pushes each of them as a pairs into each of the members of the array @@ -2368,7 +2368,7 @@ namespace OpenBabel } - bool CMLFormat::WriteScalarProperty(OBMol& mol, + bool CMLFormat::WriteScalarProperty(OBMol& /*mol*/, const char* title, double value, const char* dictref, const char* units, const char* convention) { static const xmlChar C_PROPERTY[] = "property"; diff --git a/src/isomorphism.cpp b/src/isomorphism.cpp index 7f5bbce15d..02c7afa17b 100644 --- a/src/isomorphism.cpp +++ b/src/isomorphism.cpp @@ -312,7 +312,7 @@ namespace OpenBabel { /** * The depth-first isomorphism algorithm. */ - void MapNext(State &state, OBQueryAtom *queryAtom, OBAtom *queriedAtom) + void MapNext(State &state, OBQueryAtom * /*queryAtom*/, OBAtom * /*queriedAtom*/) { if (time(nullptr) - m_startTime > m_timeout) return; diff --git a/src/mcdlutil.cpp b/src/mcdlutil.cpp index d4a174c0aa..912071ac17 100644 --- a/src/mcdlutil.cpp +++ b/src/mcdlutil.cpp @@ -2163,7 +2163,7 @@ namespace OpenBabel { }; void TSimpleMolecule::redraw(const std::vectorlistAtomClean, const std::vectorlistBondClean, - int atomClean, int & bondClean, int spn, int sCHA1, int sCHB1, bool iOPT7) { + int atomClean, int & bondClean, int spn, int sCHA1, int sCHB1, bool /*iOPT7*/) { /* the arrays are the priority list for clean. Minimal element of record has the maximal priority. Each element of record contains: @@ -3677,7 +3677,7 @@ namespace OpenBabel { static int determineBondsOrder(const std::vector iA1, const std::vector iA2, const std::vector nH, const std::vector maxValency,std::vector& bondOrder, - std::vector& hydrogenValency, int nAtoms, int nBonds, bool oddEvenViolate) { + std::vector& hydrogenValency, int nAtoms, int nBonds, bool /*oddEvenViolate*/) { //On input BortOrder has to be initialized. Real bond orders have to be putted. 0 means this order should be determined //MaxValency and HydrogenValency and NH are required only for those atoms, which are included in BondOrder=0 @@ -7260,7 +7260,7 @@ namespace OpenBabel { }; - int canonizeMCDL(const std::string atomBlock, std::vector & structureList) { + int canonizeMCDL(const std::string /*atomBlock*/, std::vector& /*structureList*/) { return 0; }; diff --git a/src/mol.cpp b/src/mol.cpp index 6de810b848..199225a4cc 100644 --- a/src/mol.cpp +++ b/src/mol.cpp @@ -2386,7 +2386,7 @@ namespace OpenBabel - bool OBMol::AssignSpinMultiplicity(bool NoImplicitH) + bool OBMol::AssignSpinMultiplicity(bool /*NoImplicitH*/) { // TODO: The following functions simply returns true, as it has been made // redundant by changes to the handling of implicit hydrogens, and spin. diff --git a/src/ops/addfilename.cpp b/src/ops/addfilename.cpp index 0c5891ed82..f59d831cc9 100644 --- a/src/ops/addfilename.cpp +++ b/src/ops/addfilename.cpp @@ -33,7 +33,7 @@ class OpAddFileName : public OBOp "Any path is removed from the filename\n" ; } - bool WorksWith(OBBase* pOb) const override { return true; } // all OBBase objects + bool WorksWith(OBBase* /*pOb*/) const override { return true; } // all OBBase objects bool Do(OBBase* pOb, const char* OptionText=nullptr, OpMap* pOptions=nullptr, OBConversion* pConv=nullptr) override; }; @@ -41,7 +41,7 @@ class OpAddFileName : public OBOp OpAddFileName theOpAddFileName("addfilename"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpAddFileName::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpAddFileName::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* pConv) { if(!pConv) return true; //do not stop any conversion but do nothing diff --git a/src/ops/addinindex.cpp b/src/ops/addinindex.cpp index 7e740e611a..79cbeb5ee8 100644 --- a/src/ops/addinindex.cpp +++ b/src/ops/addinindex.cpp @@ -32,7 +32,7 @@ class OpAddInIndex : public OBOp "Append input index to title\n" "These are objects before filtering. Use AddOutIndex for objects after filtering\n"; } - bool WorksWith(OBBase* pOb) const override { return true; } // all objects + bool WorksWith(OBBase* /*pOb*/) const override { return true; } // all objects bool Do(OBBase* pOb, const char*, OpMap*, OBConversion* pConv=nullptr) override; }; @@ -40,7 +40,7 @@ class OpAddInIndex : public OBOp OpAddInIndex theOpAddInIndex("AddInIndex"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpAddInIndex::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpAddInIndex::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* pConv) { int count = pConv->GetCount(); if(count>=0) // add nothing unless Convert interface of OBConversion is being used diff --git a/src/ops/addnonpolarh.cpp b/src/ops/addnonpolarh.cpp index 89873c1d67..5fc89b51db 100644 --- a/src/ops/addnonpolarh.cpp +++ b/src/ops/addnonpolarh.cpp @@ -38,7 +38,7 @@ class OpAddNonPolarH : public OBOp OpAddNonPolarH theOpAddNonPolarH("AddNonPolarH"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpAddNonPolarH::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpAddNonPolarH::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/addpolarh.cpp b/src/ops/addpolarh.cpp index 8b0f3acac3..88a4ef89d2 100644 --- a/src/ops/addpolarh.cpp +++ b/src/ops/addpolarh.cpp @@ -38,7 +38,7 @@ class OpAddPolarH : public OBOp OpAddPolarH theOpAddPolarH("AddPolarH"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpAddPolarH::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpAddPolarH::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/canonical.cpp b/src/ops/canonical.cpp index 05b77aa96b..36907a114a 100644 --- a/src/ops/canonical.cpp +++ b/src/ops/canonical.cpp @@ -40,7 +40,7 @@ class OpCanonical : public OBOp OpCanonical theOpCanonical("canonical"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpCanonical::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpCanonical::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/changecell.cpp b/src/ops/changecell.cpp index 1eac5e42b2..8d6a2d7078 100644 --- a/src/ops/changecell.cpp +++ b/src/ops/changecell.cpp @@ -54,7 +54,7 @@ class OpChangeCell : public OBOp OpChangeCell theOpChangeCell("ChangeCell"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpChangeCell::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpChangeCell::Do(OBBase* pOb, const char* OptionText, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { std::vector vcr; tokenize(vcr, OptionText, ";"); diff --git a/src/ops/conformer.cpp b/src/ops/conformer.cpp index 0be285bfbf..8a6c4a0748 100644 --- a/src/ops/conformer.cpp +++ b/src/ops/conformer.cpp @@ -102,7 +102,7 @@ namespace OpenBabel } ////////////////////////////////////////////////////////// - bool OpConformer::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion*) + bool OpConformer::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* pmap, OBConversion*) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/delnonpolarh.cpp b/src/ops/delnonpolarh.cpp index 15b330853c..5978f2e5ef 100644 --- a/src/ops/delnonpolarh.cpp +++ b/src/ops/delnonpolarh.cpp @@ -38,7 +38,7 @@ class OpDelNonPolarH : public OBOp OpDelNonPolarH theOpDelNonPolarH("DelNonPolarH"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpDelNonPolarH::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpDelNonPolarH::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/delpolarh.cpp b/src/ops/delpolarh.cpp index 461733284d..2c2d054fce 100644 --- a/src/ops/delpolarh.cpp +++ b/src/ops/delpolarh.cpp @@ -38,7 +38,7 @@ class OpDelPolarH : public OBOp OpDelPolarH theOpDelPolarH("DelPolarH"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpDelPolarH::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpDelPolarH::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/fillUC.cpp b/src/ops/fillUC.cpp index 5c37c3f504..d4bcee09fe 100644 --- a/src/ops/fillUC.cpp +++ b/src/ops/fillUC.cpp @@ -112,7 +112,7 @@ bool areDuplicateAtoms2(vector3 v1, vector3 v2) ///////////////////////////////////////////////////////////////// -bool OpFillUC::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpFillUC::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/forcefield.cpp b/src/ops/forcefield.cpp index fb69b00f19..12ff31839b 100644 --- a/src/ops/forcefield.cpp +++ b/src/ops/forcefield.cpp @@ -74,7 +74,7 @@ namespace OpenBabel OpEnergy theOpEnergy("energy"); //Global instance ////////////////////////////////////////////////////////// - bool OpEnergy::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion*) + bool OpEnergy::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* pmap, OBConversion*) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) @@ -171,7 +171,7 @@ namespace OpenBabel OpMinimize theOpMinimize("minimize"); //Global instance ////////////////////////////////////////////////////////// - bool OpMinimize::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion*) + bool OpMinimize::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* pmap, OBConversion*) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/gen2D.cpp b/src/ops/gen2D.cpp index 16960ec7cf..09261b756d 100644 --- a/src/ops/gen2D.cpp +++ b/src/ops/gen2D.cpp @@ -47,7 +47,7 @@ class OpGen2D : public OBOp OpGen2D theOpGen2D("gen2D"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpGen2D::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpGen2D::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/gen3d.cpp b/src/ops/gen3d.cpp index 900ab5eb2f..8317c12a3a 100644 --- a/src/ops/gen3d.cpp +++ b/src/ops/gen3d.cpp @@ -45,7 +45,7 @@ class OpGen3D : public OBOp OpGen3D theOpGen3D("gen3D"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpGen3D::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpGen3D::Do(OBBase* pOb, const char* OptionText, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/largest.cpp b/src/ops/largest.cpp index 68798125c9..f0e8cf2544 100644 --- a/src/ops/largest.cpp +++ b/src/ops/largest.cpp @@ -76,7 +76,7 @@ class OpLargest : public OBOp OpLargest theOpLargest("largest"); //Global instances OpLargest theOpSmallest("smallest"); ///////////////////////////////////////////////////////////////// -bool OpLargest::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpLargest::Do(OBBase* pOb, const char* OptionText, OpMap* /*pOptions*/, OBConversion* pConv) { if(!strcmp(OptionText, "inactive")) return true; diff --git a/src/ops/neutralize.cpp b/src/ops/neutralize.cpp index 5ca8dad833..7fd0dc8ebf 100644 --- a/src/ops/neutralize.cpp +++ b/src/ops/neutralize.cpp @@ -64,7 +64,7 @@ class OpNeutralize : public OBOp OpNeutralize theOpNeutralize("neutralize"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpNeutralize::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpNeutralize::Do(OBBase* pOb, const char* OptionText, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/opalign.cpp b/src/ops/opalign.cpp index e325fb7c37..3070ebbbb2 100644 --- a/src/ops/opalign.cpp +++ b/src/ops/opalign.cpp @@ -88,7 +88,7 @@ class OpAlign : public OBOp OpAlign theSecondOpAlign("align"); ///////////////////////////////////////////////////////////////// -bool OpAlign::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpAlign::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* pmap, OBConversion* pConv) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/opconfab.cpp b/src/ops/opconfab.cpp index 2eb322f7cd..bcdf98d3a3 100644 --- a/src/ops/opconfab.cpp +++ b/src/ops/opconfab.cpp @@ -88,7 +88,7 @@ namespace OpenBabel ////////////////////////////////////////////////////////// - bool OpConfab::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv=nullptr) + bool OpConfab::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* pmap, OBConversion* pConv = nullptr) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/ophighlight.cpp b/src/ops/ophighlight.cpp index aef446e3db..eb98b4d494 100644 --- a/src/ops/ophighlight.cpp +++ b/src/ops/ophighlight.cpp @@ -63,7 +63,7 @@ class OpHighlight : public OBOp OpHighlight theOpHighlight("highlight"); //Global instance ////////////////////////////////////////////////////////////////// -bool OpHighlight::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpHighlight::Do(OBBase* pOb, const char* OptionText, OpMap* /*pmap*/, OBConversion* pConv) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/opisomorph.cpp b/src/ops/opisomorph.cpp index 02190fef14..ef0b394f7c 100644 --- a/src/ops/opisomorph.cpp +++ b/src/ops/opisomorph.cpp @@ -162,7 +162,7 @@ OpNewS theOpNewS("s"); //Global instances OpNewS theOpNewV("v"); ////////////////////////////////////////////////////////////////// -bool OpNewS::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpNewS::Do(OBBase* pOb, const char* OptionText, OpMap* /*pmap*/, OBConversion* pConv) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/opsplit.cpp b/src/ops/opsplit.cpp index c4fc990fae..f56c3d7690 100644 --- a/src/ops/opsplit.cpp +++ b/src/ops/opsplit.cpp @@ -68,7 +68,7 @@ class OpSplit : public OBOp "cannot be changed. So if you don't like .smiles, use a dummy filename.\n\n" ; } - bool WorksWith(OBBase* pOb) const override { return true; } // all OBBase objects + bool WorksWith(OBBase* /*pOb*/) const override { return true; } // all OBBase objects bool Do(OBBase* pOb, const char* OptionText=nullptr, OpMap* pOptions=nullptr, OBConversion* pConv=nullptr) override; private: @@ -82,7 +82,7 @@ class OpSplit : public OBOp OpSplit theOpSplit("split"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpSplit::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpSplit::Do(OBBase* pOb, const char* OptionText, OpMap* /*pOptions*/, OBConversion* pConv) { if(!strcmp(OptionText, "inactive")) { diff --git a/src/ops/optransform.cpp b/src/ops/optransform.cpp index 0ca38f5beb..b1261ed3b7 100644 --- a/src/ops/optransform.cpp +++ b/src/ops/optransform.cpp @@ -105,7 +105,7 @@ void OpTransform::ParseLine(const char *buffer) } } } -bool OpTransform::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpTransform::Do(OBBase* pOb, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* /*pConv*/) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/partialcharges.cpp b/src/ops/partialcharges.cpp index 4bdbc07bf7..5bb3580963 100644 --- a/src/ops/partialcharges.cpp +++ b/src/ops/partialcharges.cpp @@ -48,7 +48,7 @@ class OpPartialCharge : public OBOp OpPartialCharge theOpPartialCharge("partialcharge"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpPartialCharge::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpPartialCharge::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* /*pConv*/) { char *arg = nullptr; const char *tok1= nullptr; diff --git a/src/ops/readconformers.cpp b/src/ops/readconformers.cpp index b7d37327ac..1394fe9ace 100644 --- a/src/ops/readconformers.cpp +++ b/src/ops/readconformers.cpp @@ -46,7 +46,7 @@ class OpReadConformers : public OBOp OpReadConformers theOpReadConformers("readconformer"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpReadConformers::Do(OBBase* pOb, const char* OptionText, OpMap* pOptions, OBConversion* pConv) +bool OpReadConformers::Do(OBBase* /*pOb*/, const char* /*OptionText*/, OpMap* /*pOptions*/, OBConversion* pConv) { //Make a deferred format and divert the output to it if(pConv && pConv->IsFirstInput()) diff --git a/src/ops/sort.cpp b/src/ops/sort.cpp index 12b235bbd2..cd7a120867 100644 --- a/src/ops/sort.cpp +++ b/src/ops/sort.cpp @@ -68,7 +68,7 @@ class OpSort : public OBOp OpSort theOpSort("sort"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpSort::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpSort::Do(OBBase* /*pOb*/, const char* OptionText, OpMap* /*pmap*/, OBConversion* pConv) { if(pConv && pConv->IsFirstInput()) { diff --git a/src/ops/unique.cpp b/src/ops/unique.cpp index b603b0526c..0b19b03997 100644 --- a/src/ops/unique.cpp +++ b/src/ops/unique.cpp @@ -75,7 +75,7 @@ class OpUnique : public OBOp OpUnique theOpUnique("unique"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpUnique::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpUnique::Do(OBBase* pOb, const char* OptionText, OpMap* /*pmap*/, OBConversion* pConv) { OBMol* pmol = dynamic_cast(pOb); if(!pmol) diff --git a/src/ops/xout.cpp b/src/ops/xout.cpp index 20b9cbe6b8..5690656c41 100644 --- a/src/ops/xout.cpp +++ b/src/ops/xout.cpp @@ -133,7 +133,7 @@ class OpExtraOut : public OBOp OpExtraOut theOpExtraOut("0xout"); //Global instance ///////////////////////////////////////////////////////////////// -bool OpExtraOut::Do(OBBase* pOb, const char* OptionText, OpMap* pmap, OBConversion* pConv) +bool OpExtraOut::Do(OBBase* /*pOb*/, const char* OptionText, OpMap* /*pmap*/, OBConversion* pConv) { /* OptionText contains an output filename with a format extension. diff --git a/src/tautomer.cpp b/src/tautomer.cpp index 04d9535120..61e97b88b8 100644 --- a/src/tautomer.cpp +++ b/src/tautomer.cpp @@ -400,7 +400,7 @@ namespace OpenBabel { return bondTypes; } - bool IsPropagationValid(OBMol *mol, const std::vector &atomTypes, const std::vector &bondTypes, int depth) + bool IsPropagationValid(OBMol *mol, const std::vector &atomTypes, const std::vector &bondTypes, int /*depth*/) { FOR_ATOMS_OF_MOL (atom, mol) { // Count atom's bond types @@ -747,7 +747,7 @@ namespace OpenBabel { } #endif - static void DecrementImplicitHCount(OBAtom* atom, int indent) + static void DecrementImplicitHCount(OBAtom* atom, int /*indent*/) { atom->SetImplicitHCount(atom->GetImplicitHCount() - 1); #ifdef DEBUG diff --git a/test/canonfragmenttest.cpp b/test/canonfragmenttest.cpp index 6b7ea9da4a..df9a363269 100644 --- a/test/canonfragmenttest.cpp +++ b/test/canonfragmenttest.cpp @@ -32,7 +32,7 @@ void test_smiles_fragment(const std::string &orig_smiles, const std::string &fra OB_COMPARE(smiles, ref_smiles); } -int canonfragmenttest(int argc, char *argv[]) +int canonfragmenttest(int /*argc*/, char * /*argv*/[]) { // Define location of file formats for testing diff --git a/test/canonstabletest.cpp b/test/canonstabletest.cpp index c605bbf88d..679121b549 100644 --- a/test/canonstabletest.cpp +++ b/test/canonstabletest.cpp @@ -13,7 +13,7 @@ using std::endl; using namespace OpenBabel; -int canonstabletest(int argc, char *argv[]) +int canonstabletest(int /*argc*/, char * /*argv*/[]) { // Define location of file formats for testing diff --git a/test/implicitHtest.cpp b/test/implicitHtest.cpp index 4157bb3d1f..cc85d4808d 100644 --- a/test/implicitHtest.cpp +++ b/test/implicitHtest.cpp @@ -33,7 +33,7 @@ void testLossOfHydrogen(string filename) } -int implicitHtest(int argc, char* argv[]) +int implicitHtest(int /*argc*/, char* /*argv*/[]) { // Define location of file formats for testing #ifdef FORMATDIR diff --git a/test/obtest.cpp b/test/obtest.cpp index 8be38f922f..18780a945b 100644 --- a/test/obtest.cpp +++ b/test/obtest.cpp @@ -1,7 +1,7 @@ #include #include -void report_error(const char* msg, const char* file, int line, const char* func_name, bool require) +void report_error(const char* msg, const char* file, int line, const char* /*func_name*/, bool require) { std::cout << file << ":" << line << ": " << msg << " (FAIL)" << std::endl; if (require) diff --git a/test/obtest.h b/test/obtest.h index 3a35d19a9a..428979b519 100644 --- a/test/obtest.h +++ b/test/obtest.h @@ -17,7 +17,7 @@ void report_error(const char* msg, const char* file, int line, const char* func_name, bool require = false); template -void ob_compare(T1 a, T2 b, const char *expr, const char *file, int line, const char *func_name) +void ob_compare(T1 a, T2 b, const char *expr, const char *file, int line, const char * /*func_name*/) { if (!(a == b)) std::cout << file << ":" << line << ": " << expr << " [" << a << " == " << b << "] (FAIL)" << std::endl; diff --git a/test/stereotest.cpp b/test/stereotest.cpp index d14965e824..5fa4146b35 100644 --- a/test/stereotest.cpp +++ b/test/stereotest.cpp @@ -174,7 +174,7 @@ std::vector< std::vector > DepUnits(const OBStereoUnitS bool doStereoPerception3(OBMol &mol, const OBStereoUnitSet &refUnits = OBStereoUnitSet(), - const OBStereoUnitSetOfSets refInterdependent = + const OBStereoUnitSetOfSets /*refInterdependent*/ = OBStereoUnitSetOfSets()) { std::vector atoms; diff --git a/test/tetranonplanartest.cpp b/test/tetranonplanartest.cpp index b1e9e78b48..ffad69a76d 100644 --- a/test/tetranonplanartest.cpp +++ b/test/tetranonplanartest.cpp @@ -24,7 +24,7 @@ bool hasSameWinding(const OBStereo::Refs &refs1, const OBStereo::Refs &refs2) // 4 -int tetranonplanartest(int argc, char* argv[]) +int tetranonplanartest(int /*argc*/, char* /*argv*/[]) { OBTetrahedralStereo::Config cfg; diff --git a/test/tetraplanartest.cpp b/test/tetraplanartest.cpp index 53f9b5a7ab..b01b8c7b42 100644 --- a/test/tetraplanartest.cpp +++ b/test/tetraplanartest.cpp @@ -13,7 +13,7 @@ using namespace OpenBabel; // 4 -int tetraplanartest(int argc, char* argv[]) +int tetraplanartest(int /*argc*/, char* /*argv*/[]) { OBCisTransStereo::Config cfg; diff --git a/tools/obmm.cpp b/tools/obmm.cpp index 7561a7222a..c078a7d51d 100644 --- a/tools/obmm.cpp +++ b/tools/obmm.cpp @@ -64,7 +64,7 @@ GNU General Public License for more details. using namespace std; using namespace OpenBabel; -int main(int argc,char **argv) +int main() { OBForceField* pFF = OBForceField::FindForceField("MMFF94"); pFF->SetLogFile(&cout); diff --git a/tools/obspectrophore.cpp b/tools/obspectrophore.cpp index 1486ad8092..c4de1e4378 100644 --- a/tools/obspectrophore.cpp +++ b/tools/obspectrophore.cpp @@ -536,7 +536,7 @@ showHelp(const char* cmd) void -showImplementationDetails(const char* cmd) +showImplementationDetails(const char* /*cmd*/) { std::cout << "\n*******************************************\n"; std::cout << "SPECTROPHORE(TM) CALCULATOR: OBSPECTROPHORE\n"; diff --git a/tools/obtautomer.cpp b/tools/obtautomer.cpp index 84631088ce..e30dc1a378 100644 --- a/tools/obtautomer.cpp +++ b/tools/obtautomer.cpp @@ -34,7 +34,7 @@ using namespace std; class Functor : public OpenBabel::UniqueTautomerFunctor { public: - void operator()(OpenBabel::OBMol *mol, const std::string &smiles) override + void operator()(OpenBabel::OBMol * /*mol*/, const std::string &smiles) override { std::cout << smiles << std::endl; }