{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":159212910,"defaultBranch":"master","name":"dbus-sensors","ownerLogin":"openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-11-26T18:15:22.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13670043?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716219983.0","currentOid":""},"activityList":{"items":[{"before":"394f0c525355fead2f997c6d9a2096d1fb88b1f0","after":"40c4d6856ffefb5c1e8a8d4eac9b4889bc5854d1","ref":"refs/heads/master","pushedAt":"2024-05-21T01:22:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"fansensor: add compatible string for ast2600 tach\n\nAdd `aspeed,ast2600-pwm-tach` as compatible string for ast2600 pwm tach\ndriver.\n\nThis commit relies on the kernel patch below.\n[1] https://lore.kernel.org/all/20240221104025.1306227-1-billy_tsai@aspeedtech.com/\n\nTested on Bletchley.\n\nChange-Id: Ia2fcf6cd8856edfb15871a3b68a8ffbc13b8025d\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"fansensor: add compatible string for ast2600 tach"}},{"before":"a9c1bec4de191352b9c681bb60c6439ac50a483b","after":"394f0c525355fead2f997c6d9a2096d1fb88b1f0","ref":"refs/heads/master","pushedAt":"2024-04-29T17:00:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"ipmbsensor: add support for an Ampere SMPro on an IPMB\n\nOn ADLINK systems, the SMPro can be reached via the MMC (Module\nManagement Controller), which is a second BMC. It sits on an IPMB\nbus.\n\nAdd support for reading power, voltage, current and temperature values\nfrom the SMPro.\n\nTested: built ipmbsensor and ran new ipmb unit tests.\n\nChange-Id: Ib9862486a18f77fb58d3acd59de7686750029b56\nSigned-off-by: Rebecca Cran ","shortMessageHtmlLink":"ipmbsensor: add support for an Ampere SMPro on an IPMB"}},{"before":"ef85e0bb4559d9162b58f2102f867d5c9cce160a","after":"a9c1bec4de191352b9c681bb60c6439ac50a483b","ref":"refs/heads/master","pushedAt":"2024-04-19T15:25:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"hwmontempsensor: update PercentRH unit string\n\nchange PercentRH unit string to follow the definition in\nphosphor-dbus-interface.\n\nTest Result:\n```\nroot@bmc:~# busctl get-property xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/humidity/FRONT_PANEL_HUMIDTY xyz.openbmc_project.Sensor.Value Unit -j\n{\n \"type\" : \"s\",\n \"data\" : \"xyz.openbmc_project.Sensor.Value.Unit.PercentRH\"\n}\n```\n\nChange-Id: I2967ee5d804eaa6f7ab28c9f39789bc58317e210\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"hwmontempsensor: update PercentRH unit string"}},{"before":"b1e74cd3442723c2cfa0a0ba8f7d68322cf28c4b","after":"ef85e0bb4559d9162b58f2102f867d5c9cce160a","ref":"refs/heads/master","pushedAt":"2024-04-15T05:08:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Utils: change OS state busname and objpath\n\nChange the busname and object path of OS state interface.\n\nThis commit relies on the patch below:\n[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/69589\n\nChange-Id: If2180db4a26a548934ef62fb4a16a6f2ed6f41eb\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"Utils: change OS state busname and objpath"}},{"before":"9142343b772cf14194fc6d7d2f190e049c6f08e8","after":"b1e74cd3442723c2cfa0a0ba8f7d68322cf28c4b","ref":"refs/heads/master","pushedAt":"2024-04-13T15:30:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Add new tidy checks\n\nChange-Id: Ibe7eb340603a6c5228997d314c20fe872e91fe58\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Add new tidy checks"}},{"before":"7c2e7c9d9b047bcfa964e249ebe61ee0197c01de","after":"9142343b772cf14194fc6d7d2f190e049c6f08e8","ref":"refs/heads/master","pushedAt":"2024-04-12T06:26:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Enable cppcoreguidelines-rvalue-reference-param-not-moved\n\nand fix the one failure.\n\nChange-Id: I62ddb9e3520b4f16331f605441740da5831ade51\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Enable cppcoreguidelines-rvalue-reference-param-not-moved"}},{"before":"de366c82dca19377dc73747ec87279c7c862027a","after":"7c2e7c9d9b047bcfa964e249ebe61ee0197c01de","ref":"refs/heads/master","pushedAt":"2024-04-09T18:15:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"psusensor: Fix memory leak\n\nRemove the psuProperties vector since older params are not being used.\nUse a temp copy of the psuProperty for customization per label match.\nThis change fix the memory leak when createSensors is called\nrepeatedly.\n\nTested:\nMemory stay stable with overnight cold reset test.\n\nSigned-off-by: Zhikui Ren \nChange-Id: If4ec633fd533fdb90c7fc9f655e82bef2616e3f3","shortMessageHtmlLink":"psusensor: Fix memory leak"}},{"before":"f3fd52480a2529733ee73763c8d770e31374c281","after":"de366c82dca19377dc73747ec87279c7c862027a","ref":"refs/heads/master","pushedAt":"2024-04-05T01:07:22.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Enable readability-container-data-pointer\n\nClang tidy check, and fix the one case.\n\nChange-Id: I0935eb6403fd3b2e1a66d9e097febd292f61d70d\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Enable readability-container-data-pointer"}},{"before":"72b3911656bebd8140831a71033bf9880cf92472","after":"f3fd52480a2529733ee73763c8d770e31374c281","ref":"refs/heads/master","pushedAt":"2024-04-05T01:05:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Enable bugprone-unused-local-non-trivial-variable\n\nAnd fix the two problems.\n\nChange-Id: Ib91625d66e42fe8b14aaf1ef33761f9084564de9\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Enable bugprone-unused-local-non-trivial-variable"}},{"before":"a327923d4ba7b47b8ff07fe42ccb025fd9c894b9","after":"72b3911656bebd8140831a71033bf9880cf92472","ref":"refs/heads/master","pushedAt":"2024-04-05T00:46:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Enable bugprone-assignment-in-if-condition\n\nAnd fix the one violation.\n\nChange-Id: I8b844d0e987827527c82e3351efd40c1bfd692db\nSigned-off-by: Ed Tanous ","shortMessageHtmlLink":"Enable bugprone-assignment-in-if-condition"}},{"before":"b2a0f2e0bfb5bc28fce737339f67df6a842cb726","after":"a327923d4ba7b47b8ff07fe42ccb025fd9c894b9","ref":"refs/heads/master","pushedAt":"2024-03-27T15:27:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"add hysteresis param to parseThresholdsFromAttr()\n\nParameter 'hysteresis' with a default = NaN, is added to the header for\nparseThresholdsFromAttr(), and existing calls to it now explicitly\nspecify a hysteresis value.\n\nThis is an alternative to having calls to parseThresholdFromAttr() use\na hardcoded Intel-specific value of '0.'\n\nThe 'NaN' value was chosen as default because it reflects the value\nthat was being written before a device-specific value was hardcoded in\nto solve a specific issue.\n\nChange was created based on the discussion here:\nhttps://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/61744/comments/38f6a\n221_58a39817a\n\nTested: Confirmed the code builds and doesn't throw errors with OBMC\n'local CI' testing. I believe heavier testing with actual Intel HW\nisn't needed because this change simple moves where a value is specified\n(from hardcode in function body to passed-in parameter) without\naffecting any existing in-use functionality.\n\nChange-Id: I1240b951d6e37adc1aad5ad3b19144f6baa64998\nSigned-off-by: Chris Sides ","shortMessageHtmlLink":"add hysteresis param to parseThresholdsFromAttr()"}},{"before":"fb011cc45d691316b07793a7ac35015b76736d98","after":"b2a0f2e0bfb5bc28fce737339f67df6a842cb726","ref":"refs/heads/master","pushedAt":"2024-03-14T00:56:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"PSUSensor: add sbrmi support\n\nAdd device sbrmi for power reading support.\n\nTest result:\n- check sensor creation\n```\nroot@bmc:~# busctl tree xyz.openbmc_project.PSUSensor |grep SBRMI\n | `- /xyz/openbmc_project/State/Decorator/SBRMI_OperationalStatus\n `- /xyz/openbmc_project/sensors/power/SBRMI_Output_Power\n```\n\nChange-Id: I4a86071e4bf01ccd473441d395221f565bb15519\nSigned-off-by: Cosmo Chou ","shortMessageHtmlLink":"PSUSensor: add sbrmi support"}},{"before":"43847a8c61887dba6f0904e5cfb148e3fb360c1d","after":"fb011cc45d691316b07793a7ac35015b76736d98","ref":"refs/heads/master","pushedAt":"2024-03-06T17:17:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"HwmonTempSensor: Add support for PT5161L\n\nAdd support for PT5161L temperature sensor.\n\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=1b2ca93cd0592b1fcbc6f8b64e02552bc15f4bb4\n\nTested Result:\n- MB_RETIMER0_TEMP_C sensor config from harma_mb.json\n```\n{\n \"Address\": \"0x24\",\n \"Bus\": 12,\n \"Name\": \"MB_RETIMER0_TEMP_C\",\n \"PowerState\": \"On\",\n \"Thresholds\": [\n {\n \"Direction\": \"greater than\",\n \"Name\": \"upper critical\",\n \"Severity\": 1,\n \"Value\": 107\n },\n {\n \"Direction\": \"greater than\",\n \"Name\": \"upper non critical\",\n \"Severity\": 0,\n \"Value\": 105\n },\n {\n \"Direction\": \"less than\",\n \"Name\": \"lower non critical\",\n \"Severity\": 0,\n \"Value\": 5\n },\n {\n \"Direction\": \"less than\",\n \"Name\": \"lower critical\",\n \"Severity\": 1,\n \"Value\": -7\n }\n ],\n \"Type\": \"PT5161L\"\n}\n```\n\n- MB_RETIMER0_TEMP_C sensor reading\n```\nroot@bmc:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/MB_RETIMER0_TEMP_C\nNAME TYPE SIGNATURE RESULT/VALUE FLAGS\norg.freedesktop.DBus.Introspectable interface - - -\n.Introspect method - s -\norg.freedesktop.DBus.Peer interface - - -\n.GetMachineId method - s -\n.Ping method - - -\norg.freedesktop.DBus.Properties interface - - -\n.Get method ss v -\n.GetAll method s a{sv} -\n.Set method ssv - -\n.PropertiesChanged signal sa{sv}as - -\nxyz.openbmc_project.Association.Definitions interface - - -\n.Associations property a(sss) 1 \"chassis\" \"all_sensors\" \"/xyz/openbmc… emits-change\nxyz.openbmc_project.Sensor.Threshold.Critical interface - - -\n.CriticalAlarmHigh property b false emits-change\n.CriticalAlarmLow property b false emits-change\n.CriticalHigh property d 107 emits-change writable\n.CriticalLow property d -7 emits-change writable\nxyz.openbmc_project.Sensor.Threshold.Warning interface - - -\n.WarningAlarmHigh property b false emits-change\n.WarningAlarmLow property b false emits-change\n.WarningHigh property d 105 emits-change writable\n.WarningLow property d 5 emits-change writable\nxyz.openbmc_project.Sensor.Value interface - - -\n.MaxValue property d 127 emits-change\n.MinValue property d -128 emits-change\n.Unit property s \"xyz.openbmc_project.Sensor.Value.Unit.… emits-change\n.Value property d 55.6 emits-change writable\nxyz.openbmc_project.State.Decorator.Availability interface - - -\n.Available property b true emits-change writable\nxyz.openbmc_project.State.Decorator.OperationalStatus interface - - -\n.Functional property b true emits-change\n```\n\nChange-Id: Ie0e7e9603c2e201a06a64de7c265500b73b5156d\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"HwmonTempSensor: Add support for PT5161L"}},{"before":"495aba1f384458dd91e3abf64137e6a1dd0c7d7b","after":"43847a8c61887dba6f0904e5cfb148e3fb360c1d","ref":"refs/heads/master","pushedAt":"2024-02-28T00:48:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"PSUSensor: add ltc4286/ltc4287 support\n\nAdd device ltc4286/ltc4287 reading support.\n\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/drivers/hwmon/pmbus/ltc4286.c?id=0c459759ca971ee49a313b19ba50fc499c6cf8ca\n\nTest result:\n- check sensors creation of CMM_HSC device config from minerva_cmm.json\n```\nroot@bmc:~# busctl tree xyz.openbmc_project.PSUSensor | grep CMM_HSC\n │ ├─ /xyz/openbmc_project/State/Decorator/CMM_HSC_OperationalStatus\n │ ├─ /xyz/openbmc_project/sensors/current/CMM_HSC_CURR_A\n │ ├─ /xyz/openbmc_project/sensors/power/CMM_HSC_PWR_W\n ├─ /xyz/openbmc_project/sensors/voltage/CMM_HSC_VIN_VOLT_V\n ├─ /xyz/openbmc_project/sensors/voltage/CMM_HSC_VOUT_VOLT_V\n```\n\nChange-Id: I945a26ea1ee98cb0ccd9978c2f43d729a9d4cdeb\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"PSUSensor: add ltc4286/ltc4287 support"}},{"before":"16d6f17bec38b6c095dfb6bed224f17d941fb9b3","after":"495aba1f384458dd91e3abf64137e6a1dd0c7d7b","ref":"refs/heads/master","pushedAt":"2024-02-08T21:56:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"meson: remove Boost TS executors\n\nBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT enables the older Networking TS\nexecutors instead of the newer \"Standard Executors\" and is not\nnecessary for io_uring. Remove this option to use the newer execution\nmodel.\n\nTested:\n\nConfirmed the io_uring interfaces are still being used.\n```\n (gdb) bt\n #0 0x00007ffff7dfba47 in ?? () from /usr/lib64/liburing.so.2\n #1 0x00007ffff7dfbca2 in __io_uring_get_cqe () from /usr/lib64/liburing.so.2\n #2 0x000055555556dd72 in io_uring_wait_cqe_nr (ring=0x555555807c30, cqe_ptr=0x7fffffffd9f0, wait_nr=1)\n at /usr/include/liburing.h:1175\n #3 0x000055555556df08 in io_uring_wait_cqe (ring=0x555555807c30, cqe_ptr=0x7fffffffd9f0)\n at /usr/include/liburing.h:1248\n #4 0x000055555557ff4f in boost::asio::detail::io_uring_service::run (this=0x555555807bf0, usec=-1, ops=...)\n at ../subprojects/boost_1_83_0/boost/asio/detail/impl/io_uring_service.ipp:437\n #5 0x000055555557e7a4 in boost::asio::detail::scheduler::do_run_one (this=0x555555806020, lock=...,\n this_thread=..., ec=...) at ../subprojects/boost_1_83_0/boost/asio/detail/impl/scheduler.ipp:477\n #6 0x000055555557e27a in boost::asio::detail::scheduler::run (this=0x555555806020, ec=...)\n at ../subprojects/boost_1_83_0/boost/asio/detail/impl/scheduler.ipp:210\n #7 0x0000555555581725 in boost::asio::io_context::run (this=0x7fffffffdc90)\n at ../subprojects/boost_1_83_0/boost/asio/impl/io_context.ipp:64\n #8 0x0000555555573af0 in main () at ../src/HwmonTempMain.cpp:643\n```\n\nRan QEMU for Bletchley and observed HwmonTempSensor still works:\n```\nroot@bletchley:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/SLED1_THERM_LOCAL xyz.openbmc_project.Sensor.Value\nNAME TYPE SIGNATURE RESULT/VALUE FLAGS\n.MaxValue property d 127 emits-change\n.MinValue property d -128 emits-change\n.Unit property s \"xyz.openbmc_project.Sensor.Value.Uni... emits-change\n.Value property d 0 emits-change writable\n```\n\nChecking strace yields lots of io_uring related calls:\n```\nroot@bletchley:~# strace -p 960\nstrace: Process 960 attached\nio_uring_enter(4, 0, 1, IORING_ENTER_GETEVENTS, NULL, 8) = 0\nclock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=810659232}) = 0\nclock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=813407042}) = 0\nio_uring_enter(4, 2, 0, 0, NULL, 8) = 2\nclock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=816897328}) = 0\nio_uring_enter(4, 0, 1, IORING_ENTER_GETEVENTS, NULL, 8) = 0\nclock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=822788059}) = 0\nclock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=824535222}) = 0\n```\n\nSigned-off-by: Patrick Williams \nChange-Id: I0eb1d732a9bc3bb25e625b9f8fe3eeeaf8ae3143","shortMessageHtmlLink":"meson: remove Boost TS executors"}},{"before":"be53d6b95dce7a6c42c94d833242cd0ea9e6f116","after":"16d6f17bec38b6c095dfb6bed224f17d941fb9b3","ref":"refs/heads/master","pushedAt":"2024-01-31T17:18:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Utils: Remove unused getSensorConfiguration method\n\nSince dbus sensor only uses the getSensorConfiguration method with the\n`useCache` parameter, this patch removes the getSensorConfiguration\nmethod that does not use the `useCache` parameter.\n\nTested: built dbus-sensors successfully and it works fine with this\npatch.\n\nSigned-off-by: George Liu \nChange-Id: I1730df517e115de0625cfcca561f08af1d053b46","shortMessageHtmlLink":"Utils: Remove unused getSensorConfiguration method"}},{"before":"5b3542ead70094b79aadcbba51205f48ba0cd8e7","after":"be53d6b95dce7a6c42c94d833242cd0ea9e6f116","ref":"refs/heads/master","pushedAt":"2024-01-23T20:55:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"adcsensor: add some documentation\n\nRecently dug into utilizing the adcsensor feature so figured my notes\ncould be useful to others who want to utilize this feature.\n\nChange-Id: I56fa1b3f79a353987af89dbcac2335240ba4d1c4\nSigned-off-by: Andrew Geissler ","shortMessageHtmlLink":"adcsensor: add some documentation"}},{"before":"bcb062a07898594b0dae8f0b961bfee7875cd16f","after":"5b3542ead70094b79aadcbba51205f48ba0cd8e7","ref":"refs/heads/master","pushedAt":"2024-01-22T16:17:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"psusensor: Optimize the naming of some variables\n\nSome variable declarations and parameter types use\n`boost::container::flat_map`. The long type names make it difficult\nfor other developers to read.\n\nThis commit makes some minor optimizations, using `using` to declare\nan alias to increase the readability of the code.\n\nTested: built psusensor successfully and works fine.\n\nSigned-off-by: George Liu \nChange-Id: I9b632c27fc67694d2de384f6e7c88bf66b97f78e","shortMessageHtmlLink":"psusensor: Optimize the naming of some variables"}},{"before":"6e6561d6bd693fdb138c131ee811aabc982e4efc","after":"bcb062a07898594b0dae8f0b961bfee7875cd16f","ref":"refs/heads/master","pushedAt":"2024-01-19T02:21:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Set exitAirSensor to null before creating sensor\n\nIf the configuration for the current ExitAirTempSensor is changed the\nservice will crash because it will re-create its DBus interfaces. To\nprevent this set exitAirSensor to nullptr before creating a new sensor.\n\nTested:\nChange a property of the ExitAirTempSensor to something new to\nre-trigger createSensors(), e.g.\nbusctl set-property xyz.openbmc_project.EntityManager\n/xyz/openbmc_project/inventory/system/chassis/R4000_Chassis/Exit_Air_Temp\nxyz.openbmc_project.Configuration.ExitAirTempSensor.Thresholds0 Value d 93\n\nWithout the fix the service would crash:\nwith the error: \"exitairtempsensor: what(): sd_bus_add_object_vtable:\norg.freedesktop.DBus.Error.FileExists: File exists\". With the fix the\nservice doesn't crash and the property change holds.\n\nChange-Id: I288140a8bd7ebb7119726720e0c829f3677a8aca\nSigned-off-by: Matt Simmering ","shortMessageHtmlLink":"Set exitAirSensor to null before creating sensor"}},{"before":"a47e082e2180e995648d8241844c9db7392d70f8","after":"6e6561d6bd693fdb138c131ee811aabc982e4efc","ref":"refs/heads/master","pushedAt":"2024-01-15T21:53:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"tachsensor: Fix 'Associations' capitalization to register associations\n\nBefore patch:\n```\n# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.Association.Definitions\nNAME TYPE SIGNATURE RESULT/VALUE FLAGS\n.associations property a(sss) 1 \"sensors\" \"inventory\" \"/xyz/openbmc... emits-change\n\n# busctl tree xyz.openbmc_project.ObjectMapper | grep Fan1_0\n | | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0\n | | | `- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/chassis\n```\n\nAfter patch:\n```\n# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.Association.Definitions\nNAME TYPE SIGNATURE RESULT/VALUE FLAGS\n.Associations property a(sss) 1 \"sensors\" \"inventory\" \"/xyz/openbmc... emits-change\n\n# busctl tree xyz.openbmc_project.ObjectMapper | grep Fan1_0\n | |- /xyz/openbmc_project/inventory/Fan1_0\n | | `- /xyz/openbmc_project/inventory/Fan1_0/sensors\n | | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0\n | | | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/chassis\n | | | `- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/inventory\n\n```\n\nChange-Id: Ie7fd69a4dc7216fb2dcfb1fdccc2b7885c7511ee\nSigned-off-by: Glukhov Mikhail ","shortMessageHtmlLink":"tachsensor: Fix 'Associations' capitalization to register associations"}},{"before":"ae4639667132e9bca62277815f0dca5c77c0b887","after":"a47e082e2180e995648d8241844c9db7392d70f8","ref":"refs/heads/master","pushedAt":"2024-01-12T01:49:07.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"subprojects: Bump boost to 1.83\n\nBump to avoid issues such as the following:\n\n```\nIn file included from ../src/Utils.hpp:3,\n from ../src/Thresholds.hpp:3,\n from ../src/sensor.hpp:6,\n from ../src/PwmSensor.hpp:3,\n from ../src/PwmSensor.cpp:17:\n../src/VariantVisitors.hpp:18:10: fatal error: boost/type_index.hpp: No such file or directory\n 18 | #include \n | ^~~~~~~~~~~~~~~~~~~~~~\n```\n\n1.83 is used by openbmc/openbmc@43471c8c565d346c1727ba2360db373035234c26\n\nWith the bump I can now successfully build dbus-sensors on Debian\nBookworm with `meson setup --cross-file=gcc-13 build`[1], even if boost\nlibraries and headers of varying version are installed via `apt`.\n\n[1]: https://amboar.github.io/notes/2023/09/12/unstable-gcc-on-debian-stable.html\n\nChange-Id: I43cb95167ede3271cc6ce6ea6ea5421911b575c0\nSigned-off-by: Andrew Jeffery ","shortMessageHtmlLink":"subprojects: Bump boost to 1.83"}},{"before":"0df80a1defa16686bc9ac3f61c2cd87b6ab60219","after":"ae4639667132e9bca62277815f0dca5c77c0b887","ref":"refs/heads/master","pushedAt":"2024-01-04T16:28:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"hwmontempsensor: Handle failure to canonicalize device path\n\nstd::filestream::canonical(const std::filesystem::path& p) can throw\nexception if the path does not exist. hwmontempsensor would crash with:\nwhat(): filesystem error: cannot make canonical path:\nNo such file or directory [/sys/class/hwmon/hwmon38/device]\n\nReplace with canonical(const std::filesystem::path& p,\nstd::error_code& ec) which captures error code without exception.\n\nThis call still may throw std::bad_alloc if memory allocation fails.\nBut there is no good way to resolve system OOM from this service,\nleave it unhandled and let the service exit.\n\nTested:\nSame hwmontemp sensors are created with the change.\n\nSigned-off-by: Zhikui Ren \nChange-Id: I0cf98950faf44b35dc71387a653ba1feeb375cc1","shortMessageHtmlLink":"hwmontempsensor: Handle failure to canonicalize device path"}},{"before":"15a39dfd553a3f454cedf4a2231e662b1ee46ecf","after":"0df80a1defa16686bc9ac3f61c2cd87b6ab60219","ref":"refs/heads/master","pushedAt":"2024-01-03T22:35:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Add debounce timer to intrusion sensor rescan\n\nGPIO based intrusion sensors were failing with rapid fire configuration\nchanges. Added a debounce timer to ensure multiple rescans can coalesce\ninto a single call to createSensorsFromConfig.\n\nTested: Ran change on Akamai Crow server and observed the GPIO Intrusion\nSensor being created properly at boot.\n\nChange-Id: I789838a31575b80d839bdb9812d23ad0d71505a9\nSigned-off-by: Ian Woloschin ","shortMessageHtmlLink":"Add debounce timer to intrusion sensor rescan"}},{"before":"4cfa64f53967b31c6a200fadf5e2b1ecfc6bd6ca","after":"15a39dfd553a3f454cedf4a2231e662b1ee46ecf","ref":"refs/heads/master","pushedAt":"2024-01-01T23:53:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"PSUSensor: add max11607 support\n\nAdd iio device max11607 reading support\n\nSigned-off-by: Joseph Fu \nChange-Id: I38dec4c01e41657f5ccb9270d41530182c76b019","shortMessageHtmlLink":"PSUSensor: add max11607 support"}},{"before":"f47c2b48f6be734972c06b3460cfe2f40c641ac6","after":"4cfa64f53967b31c6a200fadf5e2b1ecfc6bd6ca","ref":"refs/heads/master","pushedAt":"2023-12-22T06:14:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"PSUSensor: add mp2856/mp2867 support\n\nAdd support for MPS Multi-phase mp2856/mp2857 controller.\n\nThe driver is applied in linux-staging.git.\nLink: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=db79be9d970740b2310b1eece69c34bcea06c340\n\nChange-Id: I0d8e6222c70e8f7de749bdccb74d3eab93b46871\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"PSUSensor: add mp2856/mp2867 support"}},{"before":"28b88233a598ff64c073e2aaf5d178da17e31b91","after":"f47c2b48f6be734972c06b3460cfe2f40c641ac6","ref":"refs/heads/master","pushedAt":"2023-12-22T05:35:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"OWNERS: Update Andrew's preferred email\n\nWe're having some grief with non-preferred emails in Gerrit[1]. I now\nprefer project-related content goes to my work email address, so use my\nnon-preferred email to implement the switch.\n\n[1]: https://issues.gerritcodereview.com/issues/317345953\n\nChange-Id: Ib85e754f834f356f0dbd26180529a75be6f47f0c\nSigned-off-by: Andrew Jeffery ","shortMessageHtmlLink":"OWNERS: Update Andrew's preferred email"}},{"before":"7f2b77dd5bbe48553780e5c787e4c09f19491bd7","after":"28b88233a598ff64c073e2aaf5d178da17e31b91","ref":"refs/heads/master","pushedAt":"2023-12-14T22:51:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"HwmonTempSensor: Add support for MCP9600\n\nAdd support for mcp9600 temperature sensor.\n\nChange-Id: I5cd5b91cd339f203a914bc982584d32d04afc15e\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"HwmonTempSensor: Add support for MCP9600"}},{"before":"278e177f35c710349f4b9c8766aa95dc9f4189f9","after":"7f2b77dd5bbe48553780e5c787e4c09f19491bd7","ref":"refs/heads/master","pushedAt":"2023-12-13T22:21:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"PSUSensor: Add support for MP5990\n\nAdd support for MPS Multi-phase mp5990.\n\nChange-Id: I05fb65356512931b8276d88979fe2848af72c790\nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"PSUSensor: Add support for MP5990"}},{"before":"819eb3230820b0babf49b71586176f6cd414f8cf","after":"278e177f35c710349f4b9c8766aa95dc9f4189f9","ref":"refs/heads/master","pushedAt":"2023-12-13T21:57:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"HwmonTempMain: revert the type of bus and address back to uint64_t\n\nIn I546e967abae7c0fb9fca645867e3037046037647, the type of bus and\naddress in HwmonTempMain were updated to size_t.\n\nHowever, in some systems using i3c, the device name is composed by bus\nnumber and the provisioned ID [1]. The provisioned ID is a 48-bit value\n(MIPI I3C Basic, v1.1.1, section 5.1.4.1.1), which is greater than the\nrange of size_t on e.g. 32-bit ARM platforms. Thus, reverting the type\nback to uint64_t.\n\n[1] Linux in-turn uses this Provisioned ID to identify the device, and\nexposes the Provisioned ID in the device name:\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i3c/master.c?h=v6.6#n1521\n\nTested:\n- added unit test passed.\n- can read temperature of the i3c devices from our system.\n\nChange-Id: I6f0e73aaf5f8d28e4bdedbe85646373463f6707f\nSigned-off-by: Tom Tung ","shortMessageHtmlLink":"HwmonTempMain: revert the type of bus and address back to uint64_t"}},{"before":"d37e1db52d10b49186561ee930086722bbbdce37","after":"819eb3230820b0babf49b71586176f6cd414f8cf","ref":"refs/heads/master","pushedAt":"2023-12-11T04:21:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Correct the ending of Chassis On state\n\nAs defined in PDI the \"CurrentPowerState\" property of \"Chassis\"\ninterface has 4 options[1]:\n- On\n- Off\n- TransitioningToOn\n- TransitioningToOff\n\n[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/2794e9510f3d7872fc7485da793b50d02e0580a7/yaml/xyz/openbmc_project/State/Chassis.interface.yaml\n\nIf the ending of \"CurrentPowerState\" property is \"On\", it can be \"On\" or\n\"TransitioningToOn\" option. Therefore, the ending of \"CurrentPowerState\"\nproperty has to be \".On\" to indicate that Chassis's state is On.\n\nChange-Id: Idaede2f433542ba0332667bef48aad723ca55c99\nSigned-off-by: Thang Tran ","shortMessageHtmlLink":"Correct the ending of Chassis On state"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAET1Nf6AA","startCursor":null,"endCursor":null}},"title":"Activity · openbmc/dbus-sensors"}