Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement attrs= gc_ocde:attrs for OCPL #346

Closed
following5 opened this issue Sep 14, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@following5
Copy link
Contributor

commented Sep 14, 2015

OC.pl has adopted the OCDE GPX attribute system for the OC-only-Attribute, which is exported as GPX attribute 106 now by all up-to-date OC installations. This is because GSAK now supports the OConly attribute ID 106.

I suggest to enable the gc_ocde:attrs option for OCPL code, restricted to no. 106 / A1.

@wrygiel

This comment has been minimized.

Copy link
Member

commented Oct 18, 2015

I am indifferent in that matter. I will leave it up to you.

BTW - I am not so sure that OCPL has really adopted the "oc only" attribute. I could not find any reference to it in the GUI.

@following5

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2016

Right, this attribute is not available at OC.pl. But according to OKAPI's attribute-definitions.xml it is available at OC.nl. I confused these sites.

@harrieklomp

This comment has been minimized.

Copy link
Member

commented Jan 16, 2016

As far as i know, oc.pl is the only OC site without this "oc-only" attribute. No one ever told me or others why this is?

@following5

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2016

Actually, I do not see any refernce to this attribute in the OCPL source code. E.g. there is no oc-only icon here or there, and it is not in the cache-attrib table. So I wonder how this works at all at opencaching.nl. You must have some local extensions to the OCPL code and database ...?

@harrieklomp

This comment has been minimized.

Copy link
Member

commented Jan 16, 2016

When oc.nl started using the Polish code i have added this icon in the cache-attrib table with ID 6. I never notice that oc.pl did not use this attribute.... until a view months ago ;-) . Because i liked our attributes we used before i did edit the links in the cache-attribute table to the nl directory.

@following5

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2016

Okay. I think it will be fine to enable this single attribute in GPX files now via gc_ocde:attrs switch. But the implementation is not trivial and I will leave it up to someone else.

@following5

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2017

When opencaching/opencaching-pl#1242 is solved, I would like to enable gc_ocde:attrs for OCPL. As this solution must divert from the "+100" scheme and introduce individual mappings, we will need some global table for the gc_ocde:attrs mapping.

I think attribute-definitions.xml would be a good place for that. E.g. we could add an element which resembles <groundspeak>, but contains the OC pseudo-groundspeak IDs. So it could technically deal with the (very rare) case that Groundspeak adopts an OC attribute.

@following5

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2017

Now there are consistent GPX ID/inc mappings defined for all OC attributes. The reference tables are currently in OCPL code. I will try to add this information to OKAPI attribute-definitions.xml, so that gc_ocde:attrs can be implemented for OCPL (will issue a PR for review).

following5 added a commit to following5/okapi that referenced this issue Oct 11, 2017

following5 added a commit that referenced this issue Oct 26, 2018

Merge pull request #522 from following5/feature/gc-ocde-attrs
implemented attrs=gc_ocde:attrs for OCPL; updates #346

@following5 following5 closed this Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.