New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Normal -> Regular size and Quiz -> Puzzle cache type #853
Comments
Should be okay. |
I think it would be better, and even more important to be consistent. I was involved in the translation, but I was doing it with no context for what I was translating, which made it rather awkward. |
Please keep in mind that translations/changes also has to be done in the database. Some parts of the code are still collecting data from database. |
@Amberel Can you do it yourself or do i have to change it? This can be done in English translation file. |
@harrieklomp - not only in translation file, but we should change some data in database also. |
Sorry for the delay Harry, been away the last couple of days, will take a look at the database today |
@harrieklomp could you prepare sql alter file? |
UPDATE |
OC PL and OC UK already has "Regular", so it is not necessary to change DB. BUT we should also change Quiz -> Puzzle in cache_type table (@harrieklomp) |
I checked ours this evening, and they were all already correct, i.e. Micro, Small, Regular, Large, Very Large, No container Unknown type, Traditional, Multicache, Virtual, Webcam, Event, Puzzle, Moving, Podcast cache, Own cache Rgds, Andy |
UPDATE |
@andrixnet Did you change cache_size and cache_type? Can we close this issue? |
I have asked the person who initially raised this matter if they can check it again now. The problem wasn't just that the words used were not ideal, it was that different words were used in different places, indicating that the code uses different sources of data in different places. |
OC RO updated. |
OC UK proposed to change EN translations of "Normal size" to "Regular size" and "Quiz cache" to "Puzzle cache".
What do you think about it?
The text was updated successfully, but these errors were encountered: