Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Normal -> Regular size and Quiz -> Puzzle cache type #853

Closed
deg-pl opened this issue Jan 14, 2017 · 16 comments
Closed

Change Normal -> Regular size and Quiz -> Puzzle cache type #853

deg-pl opened this issue Jan 14, 2017 · 16 comments

Comments

@deg-pl
Copy link
Member

deg-pl commented Jan 14, 2017

OC UK proposed to change EN translations of "Normal size" to "Regular size" and "Quiz cache" to "Puzzle cache".
What do you think about it?

@harrieklomp
Copy link
Member

Should be okay.

@Amberel
Copy link

Amberel commented Jan 14, 2017

I think it would be better, and even more important to be consistent. I was involved in the translation, but I was doing it with no context for what I was translating, which made it rather awkward.

@harrieklomp
Copy link
Member

Please keep in mind that translations/changes also has to be done in the database. Some parts of the code are still collecting data from database.

@harrieklomp
Copy link
Member

For example on the search page. (this i have changed in DB of oc.nl)
selectie_071

@harrieklomp
Copy link
Member

@Amberel Can you do it yourself or do i have to change it? This can be done in English translation file.

@deg-pl
Copy link
Member Author

deg-pl commented Jan 17, 2017

@harrieklomp - not only in translation file, but we should change some data in database also.

@harrieklomp
Copy link
Member

@Amberel @deg-pl Changes are done in English translation file. Now each node has to change it in DB too (if they want ;-) )

@Amberel
Copy link

Amberel commented Jan 18, 2017

Sorry for the delay Harry, been away the last couple of days, will take a look at the database today

@deg-pl
Copy link
Member Author

deg-pl commented Jan 18, 2017

@harrieklomp could you prepare sql alter file?

@harrieklomp
Copy link
Member

UPDATE cache_size SET en = 'Regular' WHERE cache_size.id = 4;

@deg-pl
Copy link
Member Author

deg-pl commented Jan 18, 2017

OC PL and OC UK already has "Regular", so it is not necessary to change DB.

BUT we should also change Quiz -> Puzzle in cache_type table (@harrieklomp)

@Amberel
Copy link

Amberel commented Jan 18, 2017

I checked ours this evening, and they were all already correct, i.e.

Micro, Small, Regular, Large, Very Large, No container

Unknown type, Traditional, Multicache, Virtual, Webcam, Event, Puzzle, Moving, Podcast cache, Own cache

Rgds, Andy

@harrieklomp
Copy link
Member

UPDATE cache_type SET en = 'Puzzle cache' WHERE cache_type.id = 7;

@deg-pl
Copy link
Member Author

deg-pl commented Jan 19, 2017

@andrixnet Did you change cache_size and cache_type? Can we close this issue?
(OC PL and OC UK is ready)

@Amberel
Copy link

Amberel commented Jan 19, 2017

I have asked the person who initially raised this matter if they can check it again now. The problem wasn't just that the words used were not ideal, it was that different words were used in different places, indicating that the code uses different sources of data in different places.

@andrixnet
Copy link
Contributor

OC RO updated.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants