Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointless? #1

Closed
Matt-Deacalion opened this issue Jun 18, 2012 · 3 comments
Closed

Pointless? #1

Matt-Deacalion opened this issue Jun 18, 2012 · 3 comments

Comments

@Matt-Deacalion
Copy link

This repository is redundant if it's not going to be updated. It's been almost a year – is this the official SVN clone?

@opencart
Copy link
Collaborator

no the official one is here:

http://code.google.com/p/opencart/

i'm tryign to learn to use git.

On Tue, Jun 19, 2012 at 2:47 AM, Matt Stevens <
reply@reply.github.com

wrote:

This repository is redundant if it's not going to be updated. It's been
almost a year – is this the official SVN clone?


Reply to this email directly or view it on GitHub:
#1

@Matt-Deacalion
Copy link
Author

Ah ok, I see. Great! :)

@iign
Copy link

iign commented Jun 24, 2012

I hope you can manage to migrate and accept collaborations from the community! :)

@opencart opencart reopened this Jul 25, 2012
opencart pushed a commit that referenced this issue Jun 7, 2013
jamesallsup added a commit that referenced this issue Sep 5, 2014
danielkerr pushed a commit that referenced this issue Oct 16, 2014
Update code with OC updates
danielkerr pushed a commit that referenced this issue Aug 19, 2015
Contact POST url with regards to SSL
davidteal pushed a commit that referenced this issue Jan 19, 2016
danielkerr pushed a commit that referenced this issue Feb 23, 2016
Update worldpay.php - fix total sent to payment processor
Asif-Mahmood referenced this issue in Asif-Mahmood/opencart Mar 3, 2016
Some SMTP servers respond with 220 code before responding with 250 response code. Hence, we need to ignore 220 response string if its sent from server before 250 and keep reading for the next empty space at 4th location of SMTP response string line. Look at the sample response below from one of the server, now, when existing code parse the below strings, it breaks in the "while" loop after reading line "220 and/or bulk e-mail." from server. Hence, the next "if" statement fails when it doesn't get the code "250" in the variable $reply as it contains 220 in this case. Now, in this example, 220 is a valid response that "Server is Ready" and the next response code is "250" but existing code is failing to cater this. Hence proposing a change which should just ignore the 220 response as its not an Error response from SMTP server and code should look for the next response code which can unexpectedly be 250.
Sample response below

220-coney.arvixe.com ESMTP Exim 4.86_1 #1 Thu, 03 Mar 2016 12:19:59 -0800 
220-We do not authorize the use of this system to transport unsolicited, 
220 and/or bulk e-mail.
250-coney.arvixe.com Hello ec2-52-21-221-150.compute-1.amazonaws.com [52.21.221.150]
250-SIZE 52428800
250-8BITMIME
250-PIPELINING
250-AUTH PLAIN LOGIN
250-STARTTLS
250 HELP
opencarteli pushed a commit that referenced this issue Jun 15, 2016
Search in categories not only by starting text
mmsaaa1 added a commit to mmsaaa1/opencart that referenced this issue Nov 29, 2022
This line 108 giving error:
Unknown: html_entity_decode(): Passing null to parameter opencart#1 ($string) of
type string is deprecated in
/home/upload/catalog/controller/product/category.php on line 108

When i asked Journal theme support they suggested  these changes adding these ( ?? ''  before  , ENT 

if ($category_info['image'] && is_file(DIR_IMAGE . html_entity_decode($category_info['image'], ENT_QUOTES, 'UTF-8'))) {
with

if ($category_info['image'] && is_file(DIR_IMAGE . html_entity_decode($category_info['image'] ?? '', ENT_QUOTES, 'UTF-8'))) {

and now this is working.
ppalashturov pushed a commit to opencartbulgaria/opencart that referenced this issue Jul 17, 2023
ppalashturov pushed a commit to opencartbulgaria/opencart that referenced this issue Jul 17, 2023
ppalashturov pushed a commit to opencartbulgaria/opencart that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants