Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Modification-class more similar to VQmod #1183

Closed
mhcwebdesign opened this issue Feb 4, 2014 · 9 comments

Comments

Projects
None yet
3 participants
@mhcwebdesign
Copy link

commented Feb 4, 2014

Please make the system/engine/modification.php more similar to VQmod, this will make it easier to port 1.5.x VQmod XML scripts to 2.0.

In particular, the following attributes should be supported:
modification/file : attribute error
modification/file/operation : attribute error
modification/file/operation/search : attribute offset
modification/file/operation/search : attribute regex
modification/file/operation/search : attribute trim
modification/file/operation/add : attribute trim

Also, the 'name' attribute for the 'modification/file' should support a wildcard (*) character for dynamic path building.

@mhcwebdesign

This comment has been minimized.

Copy link
Author

commented Feb 15, 2014

Further to this subject: The XML syntax expected by the Modification is quite different from VQmod, it basically is a simple inline search/replace for 'before', 'after' and 'replace' positions. VQmod XML files won't work!

Hence, I have added full VQmod 2.4.1 XML support to the Modification class in order to port my old 1.5.x VQmod XML files to OpenCart 2.0. VQmod has way more features than OpenCart 2.0 modification XML. Daniel, if you are interested to integrate it into the core 'system/engine/modification.php' file, I'd be happy to create a pull-request for this, otherwise I can release it as a free extension. Let me know.

P.S.: The modified files to include support for VQmod can be found here:
https://github.com/mhcwebdesign/opencart-oe/blob/master/upload/system/engine/modification.php
https://github.com/mhcwebdesign/opencart-oe/blob/master/upload/admin/controller/extension/installer.php

@sabitertan

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2014

I agree with mhcwebdesign we should use vqmod syntax(and sorry about my issue report it is almost same with this issue #1224, this is why i closed that).
On the other hand what about using vqmod as helper?

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2014

mhcwebdesign your code is a lot clear then vqmod normal is. is it ok to use?

@mhcwebdesign

This comment has been minimized.

Copy link
Author

commented Mar 13, 2014

Yes, please feel free to use it under the normal GPLv3 license.

@DS-Matt DS-Matt referenced this issue Apr 4, 2014

Closed

damianb #1286

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2014

was this tested because it has some file path issues

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2014

to be honest this is not even a working version, my own version is much simpler and clear to use.

@mhcwebdesign

This comment has been minimized.

Copy link
Author

commented Apr 10, 2014

What error exactly did you encounter? I tested it on my local server back in February.

@mhcwebdesign

This comment has been minimized.

Copy link
Author

commented Apr 10, 2014

OK, since you have done quite a few changes to OpenCart 2.0 (master branch) since February, I'll grab the latest OpenCart code and add the VQmod modification to it this weekend, I'll then test it again with a number of VQmod XML files.

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2014

i just reverted the code back. look at my last 2 commits, most of the code has been doen and fixed..

the problem also is vqmod, i just don't like how there are a lot of unnecessary features.

one is where you can have a path and filename.

im going to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.