Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Make Modification-class more similar to VQmod #1183
Please make the system/engine/modification.php more similar to VQmod, this will make it easier to port 1.5.x VQmod XML scripts to 2.0.
In particular, the following attributes should be supported:
Also, the 'name' attribute for the 'modification/file' should support a wildcard (*) character for dynamic path building.
Further to this subject: The XML syntax expected by the Modification is quite different from VQmod, it basically is a simple inline search/replace for 'before', 'after' and 'replace' positions. VQmod XML files won't work!
Hence, I have added full VQmod 2.4.1 XML support to the Modification class in order to port my old 1.5.x VQmod XML files to OpenCart 2.0. VQmod has way more features than OpenCart 2.0 modification XML. Daniel, if you are interested to integrate it into the core 'system/engine/modification.php' file, I'd be happy to create a pull-request for this, otherwise I can release it as a free extension. Let me know.
P.S.: The modified files to include support for VQmod can be found here:
i just reverted the code back. look at my last 2 commits, most of the code has been doen and fixed..
the problem also is vqmod, i just don't like how there are a lot of unnecessary features.
one is where you can have a path and filename.
im going to close this issue