Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.2.0] UPS doesn't work #5783

Closed
ClearThinking opened this issue Jul 23, 2017 · 8 comments
Closed

[3.0.2.0] UPS doesn't work #5783

ClearThinking opened this issue Jul 23, 2017 · 8 comments

Comments

@ClearThinking
Copy link

@ClearThinking ClearThinking commented Jul 23, 2017

The issue is the same as the USPS issue, which is the wrong code when retrieving a config variable. The fix is this:

IN:
/catalog/model/extension/shipping/ups.php

REPLACE:
$this->config->get('ups_

WITH:
$this->config->get('shipping_ups_
danielkerr added a commit that referenced this issue Oct 11, 2017
@danielkerr danielkerr closed this Oct 11, 2017
@syedfaisalraza
Copy link

@syedfaisalraza syedfaisalraza commented Sep 23, 2018

Thank you so much for help. Its working fine.

@kashifmahmood86
Copy link

@kashifmahmood86 kashifmahmood86 commented Jan 30, 2019

IN 3.0.3.1 the same issue still exist , i d'nt know why you close the issues if they come in the next release

@Nodws
Copy link

@Nodws Nodws commented Apr 1, 2019

Well was looking for this for the longest time, OC never again 🚫

@danielkerr
Copy link
Contributor

@danielkerr danielkerr commented Apr 2, 2019

I just did a mass search for $this->config->get('ups_ and there is non on the master branch.

@jolguin87
Copy link

@jolguin87 jolguin87 commented Apr 18, 2019

@danielkerr The file /catalog/model/extension/shipping/ups.php in the 3.0.3.1 and 3.0.3.2 download bundles differ from the master branch GitHub repo.

@ghost
Copy link

@ghost ghost commented Apr 3, 2020

Is there a reason why ups shipping extension are not included in master branch and does it mean it will not be part of the next release ?
Thx

@danielkerr
Copy link
Contributor

@danielkerr danielkerr commented Apr 3, 2020

all 3rd party extensiuon will be listed but not in the code. they will be downloaded if the code is not there.

@D-whitten
Copy link

@D-whitten D-whitten commented May 7, 2020

May of 2020 and this is still a problem with the stock OC UPS and FedEx shipping modules..

this is just sloppy coding at best... did anyone even test this at all before releasing this?

This fix works.. around line 267 in catalog/model/extension/shipping/ups.php

same issue on line 104 admin/view/template/extension/shipping/fedex.twig

The issue is the same as the USPS issue, which is the wrong code when retrieving a config variable. The fix is this:

IN:
/catalog/model/extension/shipping/ups.php

REPLACE:
$this->config->get('ups_

WITH:
$this->config->get('shipping_ups_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants