Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC 3.0.2.0 Extension Installer bug #5830

Closed
mhcwebdesign opened this issue Jul 31, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@mhcwebdesign
Copy link

commented Jul 31, 2017

The OpenCart extension installer has this following subtle issue:

Assuming I install 3 different module extensions via the admin backend at

Extensions > Installer > Upload

where each module extension creates the same folder (highlighted in bold):

  1. admin/model/extension/module/my-module-1.php
  2. admin/model/extension/module/my-module-2.php
  3. admin/model/extension/module/my-module-3.php

If I then uninstall the first extension module via

Extensions > Installer > Uninstall

it will then remove the folder module

  1. admin/model/extension/module

leaving the 2nd and 3rd extension with a missing folder and its file.

In general, the OpenCart extension installer should keep a count of newly introduced folders and only remove them in the uninstaller when all extensions using them have been uninstalled.

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2017

this should not happen since it only adds a this to a directory if it does not exists.

ok i will ad something to check if the directory is empty.

@danielkerr danielkerr closed this Aug 25, 2017

danielkerr added a commit that referenced this issue Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.