Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.3.1] Unnecessary variable (%s) in customer account (wishlist)-Not fixed #7130

Closed
condor2 opened this Issue Jan 7, 2019 · 7 comments

Comments

Projects
None yet
4 participants
@condor2
Copy link
Contributor

condor2 commented Jan 7, 2019

Still show ugly Wishlist (%s) in Customers account.

#6721

@danielkerr

This comment has been minimized.

Copy link
Contributor

danielkerr commented Jan 7, 2019

its fixed in the master branch

@danielkerr

This comment has been minimized.

Copy link
Contributor

danielkerr commented Jan 7, 2019

also this looks like a language file issue.

@danielkerr danielkerr closed this Jan 7, 2019

@condor2

This comment has been minimized.

Copy link
Contributor Author

condor2 commented Jan 7, 2019

Yes, I know.

But why relased 3.0.3.1 as "bugs fixed 3.0.2.0" ?

@danielkerr

This comment has been minimized.

Copy link
Contributor

danielkerr commented Jan 7, 2019

it does not have all bug fixes but enough to make the system still compatible with the last version.

@condor2

This comment has been minimized.

Copy link
Contributor Author

condor2 commented Jan 7, 2019

Then on Released notes should write something like this.

"Not all bugs was fixed"
"May contain bugs"

That people know if they want to upgrade to 3.0.3.1 or keep 3.0.2.0 :)

@trueliarx

This comment has been minimized.

Copy link

trueliarx commented Feb 2, 2019

It's not a "language file" issue since the problem resides in the wrong loading of the language in the controller.

The previously linked "solution" is just adding the sprintf() to add the nr or items in the wishlist ignoring the fact that the strings are just overridden by different language files.

$_['text_wishlist'] string in (catalog) account/account that appears in the menu is the ones that are loaded from the language files of header, footer, column_left (or right) with the account menu.
for ex.:
en/gb/common/header.php
and not (as expected) from
en/gb/account/account.php

Also other language variables are overriden.

As a Workaround I moved

$data['column_left'] = $this->load->controller('common/column_left'); $data['column_right'] = $this->load->controller('common/column_right'); $data['content_top'] = $this->load->controller('common/content_top'); $data['content_bottom'] = $this->load->controller('common/content_bottom'); $data['footer'] = $this->load->controller('common/footer'); $data['header'] = $this->load->controller('common/header');

BEFORE

$this->load->language('account/account');

and now it correctly loads the string from en-gb/account/account.php (overriding the previously loaded variables/strings)

Note that also REloading the (necessary) language file by adding

$this->load->language('account/account'); //any language

AFTER

$data['header'] = $this->load->controller('common/header');

can work (as a workaround but not as a solution)

The same problem affects several other files.

@stanislavdavid

This comment has been minimized.

Copy link

stanislavdavid commented Feb 18, 2019

looks like duplicate of #6068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.