Update encryption.php #1594

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@sarciszewski

MCRYPT_RIJNDAEL_256 is not AES. AES is specifically only a 128-bit block cipher.

Note: There are numerous other issues here. ECB for payment data? No IV or authentication? Will revisit later.

Update encryption.php
MCRYPT_RIJNDAEL_256 is not AES. AES is specifically only a 128-bit block cipher.

Note: There are numerous other issues here. ECB for payment data? No IV or authentication? Will revisit later.
@Ayrx

This comment has been minimized.

Show comment
Hide comment
@Ayrx

Ayrx Jun 27, 2014

#1279 is relevant. Apparently Daniel does not consider this a problem.

Ayrx commented Jun 27, 2014

#1279 is relevant. Apparently Daniel does not consider this a problem.

@danielkerr

This comment has been minimized.

Show comment
Hide comment
@danielkerr

danielkerr Jun 27, 2014

Contributor

I can change it but is pointless because there is nothing to decypt from the customer or admin side

Contributor

danielkerr commented Jun 27, 2014

I can change it but is pointless because there is nothing to decypt from the customer or admin side

@sarciszewski

This comment has been minimized.

Show comment
Hide comment
@sarciszewski

sarciszewski Jun 27, 2014

Why not remove it then? :)

Why not remove it then? :)

@danielkerr

This comment has been minimized.

Show comment
Hide comment
@danielkerr

danielkerr Jun 27, 2014

Contributor

because its my project and ill do what ever I want!

just tell me which one to use instead!

Contributor

danielkerr commented Jun 27, 2014

because its my project and ill do what ever I want!

just tell me which one to use instead!

@sarciszewski

This comment has been minimized.

Show comment
Hide comment
@sarciszewski

sarciszewski Jun 27, 2014

because its my project and ill do what ever I want!
just tell me which one to use instead! idiot!

Wow, okay, I'm closing this ticket.

because its my project and ill do what ever I want!
just tell me which one to use instead! idiot!

Wow, okay, I'm closing this ticket.

@sarciszewski sarciszewski deleted the sarciszewski:patch-1 branch Jun 27, 2014

@aitowerscart

This comment has been minimized.

Show comment
Hide comment
@aitowerscart

aitowerscart Jun 27, 2014

I wish to be removed effective immediately from this unprofessional, non-commercial application, subscription, blog, logs, or anything else related to this company.

Sergio DeLima, Developer / Support Engineer
https://by2prd0412.outlook.com/owa/redir.aspx?C=fwHf3VPx70a5KHtsa5dyDCAvQib_zc8IbYX8kg0foGJFKPftVDNNoJ5lCWBHziOYc-f6a5KaLL8.&URL=http%3a%2f%2fwww.aitowers.com%2f
https://by2prd0412.outlook.com/owa/redir.aspx?C=fwHf3VPx70a5KHtsa5dyDCAvQib_zc8IbYX8kg0foGJFKPftVDNNoJ5lCWBHziOYc-f6a5KaLL8.&URL=mailto%3asergio.delima%40aitowers.com


From: Scott Arciszewski notifications@github.com
Sent: Friday, June 27, 2014 1:21 PM
To: opencart/opencart
Subject: Re: [opencart] Update encryption.php (#1594)

because its my project and ill do what ever I want!
just tell me which one to use instead! idiot!

Wow, okay, I'm closing this ticket.

Reply to this email directly or view it on GitHubhttps://github.com/opencart/opencart/pull/1594#issuecomment-47383404.

I wish to be removed effective immediately from this unprofessional, non-commercial application, subscription, blog, logs, or anything else related to this company.

Sergio DeLima, Developer / Support Engineer
https://by2prd0412.outlook.com/owa/redir.aspx?C=fwHf3VPx70a5KHtsa5dyDCAvQib_zc8IbYX8kg0foGJFKPftVDNNoJ5lCWBHziOYc-f6a5KaLL8.&URL=http%3a%2f%2fwww.aitowers.com%2f
https://by2prd0412.outlook.com/owa/redir.aspx?C=fwHf3VPx70a5KHtsa5dyDCAvQib_zc8IbYX8kg0foGJFKPftVDNNoJ5lCWBHziOYc-f6a5KaLL8.&URL=mailto%3asergio.delima%40aitowers.com


From: Scott Arciszewski notifications@github.com
Sent: Friday, June 27, 2014 1:21 PM
To: opencart/opencart
Subject: Re: [opencart] Update encryption.php (#1594)

because its my project and ill do what ever I want!
just tell me which one to use instead! idiot!

Wow, okay, I'm closing this ticket.

Reply to this email directly or view it on GitHubhttps://github.com/opencart/opencart/pull/1594#issuecomment-47383404.

@sarciszewski

This comment has been minimized.

Show comment
Hide comment
@sarciszewski

sarciszewski Jul 1, 2014

@Dvir-Julius I've made an attempt to notify OpenCart users about this: http://forum.opencart.com/viewtopic.php?f=10&t=127530

@Dvir-Julius I've made an attempt to notify OpenCart users about this: http://forum.opencart.com/viewtopic.php?f=10&t=127530

@Daniel15 Daniel15 referenced this pull request in nikolas/github-drama Apr 4, 2018

Merged

Added OpenCART drama #57

nikolas added a commit to nikolas/github-drama that referenced this pull request Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment