Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Show warning <td> from Affiliate form #196

Closed
wants to merge 1 commit into from

Conversation

@khflab
Copy link

khflab commented Oct 18, 2012

Signed-off-by: Kayo Hamid lab@kayohamid.net

Signed-off-by: Kayo Hamid <lab@kayohamid.net>
@khflab

This comment has been minimized.

Copy link
Author

khflab commented Oct 18, 2012

The title is not helping I think. The goal is simple to show the "Warning" if user forgot to fill all the form.

@ghost

This comment has been minimized.

Copy link
Collaborator

ghost commented Oct 19, 2012

wasting my time

@opencart opencart closed this Oct 19, 2012
@khflab

This comment has been minimized.

Copy link
Author

khflab commented Oct 19, 2012

Why? I think this helps to make patterns. Do you think this is not good? Or the project/application do not need them? If is the case, why use jQuery? Let's go to stone age and use changes static and so on!

For me this help to make patterns and to guide better the user.

Sorry to make you wasting your time again.

@ghost

This comment has been minimized.

Copy link
Collaborator

ghost commented Oct 19, 2012

which file are you talking about?

On Fri, Oct 19, 2012 at 9:17 PM, khflab notifications@github.com wrote:

Why? I think this helps to make patterns. Do you think this is not good?
Or the project/application do not need them? If is the case, why use
jQuery? Let's go to stone age and use changes static and so on!

For me this help to make patterns and to guide better the user.

Sorry to make you wasting your time again.


Reply to this email directly or view it on GitHubhttps://github.com//pull/196#issuecomment-9600564.

@khflab

This comment has been minimized.

Copy link
Author

khflab commented Oct 19, 2012

I'm talking about this pull request/commit.

That is my time that I used to make the error response from Affiliate form equal to Product form

And the question now is, this is not valuable?

savage4pro pushed a commit to savage4pro/opencart that referenced this pull request Feb 25, 2016
AUTO_INCREMENT in some tables leads to disruption of data integrity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.