New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache $(this) and use jQuery dom obj for dropdown #4288

Merged

danielkerr merged 2 commits into opencart:master from pine3ree:patch-33

Apr 25, 2016

Contributor

pine3ree commented Apr 25, 2016

calling $(selector) or even $(this) will create new jQuery object for each call.
on is the recommended method to handle events: it superseeded live and delegate since jquery v 1.7:

$(alwaysPresentWrapperElementSelector).on(events, dynamicOrNotInnerElementsSelector, handler);

maks feltrin added 2 commits

April 25, 2016 05:40


          cache $(this) and use jQuey dom el for dropdown

bc0f65e


          Update common.js

886d272

danielkerr merged commit 995fab0 into opencart:master

pine3ree deleted the patch-33 branch

December 24, 2016 15:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment