Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AUTO_INCREMENT in product_advertise table #7137

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Arthom
Copy link

commented Jan 9, 2019

Issue #7133 fix

@aironike

This comment has been minimized.

Copy link

commented Feb 8, 2019

Nice thanks!

@straightlight

This comment has been minimized.

Copy link

commented May 3, 2019

@danielkerr: This solution should be added in the system/helper/db_schema.php file on the master branch since the release OC v3.0.3.2 already in evaluation process.

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

there is no product_advertise table in the db_schema. its in the google shopping install code.

this has already been fixed and should be in the latest stable release 3.0.3.2

@danielkerr danielkerr closed this May 3, 2019

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

ahh i see it in the 3.3.xxxbbranch.

the fix has been added already

product_advertise_google_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,

@danielkerr danielkerr reopened this May 3, 2019

@danielkerr danielkerr closed this May 3, 2019

@straightlight

This comment has been minimized.

Copy link

commented May 3, 2019

However, when going to the code tab: https://github.com/opencart/opencart/blob/master/upload/system/helper/db_schema.php , we type: advertise and the keyword does not come up as compared to the official release of OC v3.0.3.2 .

@straightlight

This comment has been minimized.

Copy link

commented May 3, 2019

From the official release, obviously, the advertise keywords do come up in the install/opencart.sql file.

@danielkerr

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

the dev who created it will at some point will add it to the master branch once its ready for release.

a few things left to do.

product varaiants then fixing as many issues as i can. maybe the next few releases will soly be fix updates.

@straightlight

This comment has been minimized.

Copy link

commented May 3, 2019

Ok, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.