Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC 3.1.0.0-b: Twig fixes for issues #7152, #7151, #7149 #7153

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mhcwebdesign
Copy link

mhcwebdesign commented Jan 17, 2019

Hi Daniel,

Please find attached pull request for issues #7152, #7151, #7149

It basically makes OC 3.1.0.0 backward compatible for view/*/before events.
And it solves the problems with Twig caching, including auto-refresh, cooperates nicely with the theme editor changes. There is no more need for cumbersome lambda functions. And last not least, it can now automatically detect whether a template is twig or php before rendering. Finally, the rendering time, therefore the overall page load time, is now faster, too.

mhcwebdesign added some commits Jan 17, 2019

@mhcwebdesign mhcwebdesign changed the title Twig fixes for issues #7152, #7151, #7149 OC 3.1.0.0-b: Twig fixes for issues #7152, #7151, #7149 Jan 17, 2019

@straightlight

This comment has been minimized.

Copy link

straightlight commented Mar 3, 2019

For this file: bbd109f,

This line: $parts = explode('/', substr($dir,1));

should be replaced with: $parts = explode('/', rtrim(str_replace('\\', '/', $dir)));

@danielkerr danielkerr self-assigned this Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.