Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFIX for schema or host agnostic web sites (e.g. multiple domain setup) #762
Conversation
Hello Daniel.
I've made and tested this quick fix to allow schema or host agnostic webs. This is really useful when having multiple domains for the same client.
It already worked without SEO_URLs but it complained when activating, so I fixed it.
It doesn't break normal usage, it's just a verification of key existence before usage.
After this patch, these configurations are valid on the config.php file (the new default could be '/' for less installation steps!):
// Scheme agnostic website (Note: the '//' is required):
define('HTTP_SERVER', '//www.domain.com/');
// Domain agnostic website:
define('HTTP_SERVER', '/');
| @@ -112,10 +112,10 @@ public function rewrite($link) { | |||
| } | |||
| } | |||
|
|
|||
| return $url_info['scheme'] . '://' . $url_info['host'] . (isset($url_info['port']) ? ':' . $url_info['port'] : '') . str_replace('/index.php', '', $url_info['path']) . $url . $query; | |||
| return (array_key_exists('host', $url_info) ? (array_key_exists('scheme', $url_info) ? $url_info['scheme'] . '://' : '//') . $url_info['host'] . (array_key_exists('port', $url_info) ? ':' . $url_info['port'] : '') : '/') . str_replace('/index.php', '', $url_info['path']) . $url . $query; | |||
This comment has been minimized.
This comment has been minimized.
maddes
Jul 10, 2013
Author
Really don't know the difference between array_key_exists('host', $url_info) and isset($url_info['host']) but array_key_exists looked more standard.
This comment has been minimized.
This comment has been minimized.
ghost
commented
Jul 11, 2013
|
Stacking a bunch of ternary operators really hurts readability, IMO. |
This comment has been minimized.
This comment has been minimized.
|
well, I just used them to keep it on a single line just as it was.
|
This comment has been minimized.
This comment has been minimized.
|
So.. should I edit it and make an if/else version? |
maddes commentedJul 10, 2013
Hello Daniel.
I've made and tested this quick fix to allow schema or host agnostic webs. This is really useful when having multiple domains for the same client.
It already worked without SEO_URLs but it complained when activating, so I fixed it.
It doesn't break normal usage, it's just a verification of key existence before usage.
After this patch, these configurations are valid on the config.php file (the new default could be '/' for less installation steps!):
// Scheme agnostic website (Note: the '//' is required):
define('HTTP_SERVER', '//www.domain.com/');
// Domain agnostic website:
define('HTTP_SERVER', '/');
ps: the $url_data to $url_info renaming on last version almost lost me.