Permalink
Show file tree
Hide file tree
1 change: 1 addition & 0 deletions
1
modules/common/src/main/java/org/opencastproject/mediapackage/identifier/Id.java
11 changes: 9 additions & 2 deletions
11
modules/common/src/main/java/org/opencastproject/mediapackage/identifier/IdImpl.java
7 changes: 5 additions & 2 deletions
7
...est-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Limit Characters Allowed In Ids
Opencast allows almost arbitrary identifiers for media packages and elements to be used. This can be problematic for operation and security since such identifiers are sometimes used for file system operations which may lead to attacker being able to escape working directories and write files to other locations. In addition, Opencast's `Id.toString(…)` vs `Id.compact(…)` behavior, the latter trying to mitigate some of the file system problems, can cause errors due to identifier mismatch since an identifier may unintentionally change. This patch limits the characters allowed to be used in identifiers to ensure no unsafe operations are possible and no mismatch may happen.
- Loading branch information
Showing
3 changed files
with
15 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters