Updates Service Registry dispatch interval property name and time unit #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkiesow
requested changes
Oct 5, 2019
There was a problem hiding this comment.
Hi @cartucciam, thanks for the patch. Can you please add an explanation of what you are doing and reasoning why you are doing this to the pull request's description?
Also, changing the dispatch interval's property name can easily cause problems if people miss this when upgrading. This does not necessarily mean that we cannot make that change but we should be pretty clear in the upgrade documentation about this.
|
Hi @lkiesow, that's a good point and makes me wondering if this change is really needed. Can you point me at the correct upgrade documentation? |
|
I guess docs/guides/admin/docs/upgrade.md would be the right place to announce a change like this. |
smarquard
reviewed
Oct 6, 2019
cartucciam
commented
Oct 13, 2019
|
Thanks for helping out with this → merged. |
LinqLover
pushed a commit
to LinqLover/opencast
that referenced
this pull request
Nov 24, 2020
opencast#1120) * Updates Service Registry dispatch interval property name and time unit To be consistent with heartbeat interval ones Fixes opencast#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing dispatch interval property name and time unit to be consistent with the other settings (as per #1117).
Closes #1117