Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1123 TEMP FIX for Paella Player Build error #1131

Merged

Conversation

karendolan
Copy link
Member

@karendolan karendolan commented Oct 8, 2019

  • have a concise title
  • close an accompanying issue if one exists
  • be against the correct branch (features can only go into develop)
  • include migration scripts and documentation, if appropriate
  • pass automated testing
  • have a clean commit history
  • have proper commit messages (title and body) for all commits
  • have appropriate tags applied

This pull is TEMP FIX for the CI error with engage-paella-player. If the Paella player repo accepts the npm-shrinkwrap.json the this pull can be adjusted to just keep the npm ci changes.
Ref: polimediaupv/paella#448
Closes Issue #1123
Originating trigger: olivernn/lunr.js#420

@lkiesow lkiesow self-assigned this Oct 8, 2019
@karendolan karendolan force-pushed the t/Issue1123-PaellaBuildIssue-8x branch from ba9405c to a467aeb Compare October 8, 2019 14:15
@lkiesow lkiesow added the bug label Oct 8, 2019
lkiesow added a commit that referenced this pull request Oct 8, 2019
…t-contrib into r/8.x

Pull request #1131
  Issue1123 TEMP FIX for Paella Player Build error
@lkiesow lkiesow merged commit a467aeb into opencast:r/8.x Oct 8, 2019
@lkiesow
Copy link
Member

lkiesow commented Oct 8, 2019

Merged into r/8.x and develop

@karendolan
Copy link
Member Author

Long term issue resolved via #1547
An npm-shrinkwrap file would have solved lib dependency issues but would not have solved the hidden babel build config file issue.

@miesgre miesgre mentioned this pull request May 22, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants