New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-12387 - Fix CAS #350

Merged
merged 4 commits into from Sep 15, 2018

Conversation

Projects
None yet
3 participants
@miesgre
Copy link
Contributor

miesgre commented Jul 17, 2018

In commit 132065b opensaml library was update to 2.6.4 version. That change broke CAS.

This PR fix CAS.

miesgre added some commits Jul 17, 2018

@gregorydlogan gregorydlogan changed the title NOJIRA - Fix CAS MH-12387 - Fix CAS Jul 17, 2018

@lkiesow lkiesow self-assigned this Jul 17, 2018

@gregorydlogan gregorydlogan added the bug label Jul 23, 2018

@lkiesow

This comment has been minimized.

Copy link
Member

lkiesow commented Jul 25, 2018

I've asked on list if anyone can help to test this since I have no CAS set-up. If no one speaks up, I'll just do a best-effort review early next week.

@lkiesow

This comment has been minimized.

Copy link
Member

lkiesow commented Jul 26, 2018

Andrew Wilson from Manchester agreed to test this, yay:

Hi Lars
i'll review this pull request, it may take me a little bit to get going
thanks
-andy

@lkiesow lkiesow merged commit f93965e into opencast:r/5.x Sep 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lkiesow added a commit that referenced this pull request Sep 15, 2018

@miesgre miesgre deleted the miesgre:f/NOJIRA_Fix_CAS branch Sep 15, 2018

@miesgre

This comment has been minimized.

Copy link
Contributor

miesgre commented Sep 15, 2018

Thanks for merging this. Will this be merged into develop or Do I have to make another PR to develop branch?

@lkiesow

This comment has been minimized.

Copy link
Member

lkiesow commented Sep 15, 2018

By now, it's already in develop. The release branches are merged downwards on a regular basis (r/4.xr/5.xdevelop) and I've just done that today. So you only need to provide a patch once.

Btb. I've tested this patch as you instructed and had no problems at all to get it running. Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment