Copy Mediapackage elements from the publication to mediapackage #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtneug
reviewed
Mar 29, 2022
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
lkiesow
requested changes
Mar 29, 2022
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
| .forEach(element -> tracks.add(element)); | ||
| Arrays.stream(publication.get().getTracks()) | ||
| .filter(element -> configuredSourceFlavors.contains(element.getFlavor())) | ||
| .filter(Objects::nonNull) |
There was a problem hiding this comment.
same here
Suggested change
| .filter(Objects::nonNull) |
| .filter(Objects::nonNull) | ||
| .forEach(element -> catalogs.add(element)); | ||
|
|
||
| catalogs.stream().forEach(mediaPackageElement -> mediaPackageElement.addTag(configuredTargetTagsAsString)); |
...c/main/java/org/opencastproject/workflow/handler/workflow/PublicationChannelToWorkspace.java
Outdated
Show resolved
Hide resolved
| Collection<MediaPackageElement> catalogs = new ArrayList<MediaPackageElement>(); | ||
| Arrays.stream(publication.get().getCatalogs()) | ||
| .filter(element -> element.containsTag(configuredSourceTags)) | ||
| .filter(Objects::nonNull) |
| .forEach(element -> catalogs.add(element)); | ||
| Arrays.stream(publication.get().getCatalogs()) | ||
| .filter(element -> configuredSourceFlavors.contains(element.getFlavor())) | ||
| .filter(Objects::nonNull) |
CGreweling
commented
Jun 1, 2022
CGreweling
force-pushed
the
publication-channel-to-workspace
branch
from
7ef5726
to
ed0e3b1
Compare
|
I did a rebase, now Workflow-tests does not fail any more. |
…blication channel to the mediapackage.
tags ar added one by one not as complete string
CGreweling
force-pushed
the
publication-channel-to-workspace
branch
from
ed0e3b1
to
b6a523e
Compare
|
I said I'd review this, but for whatever reason my Opencast can't find the workflow handler, so I can't really test. Code seems fine though. |
|
The test failures are likely due to the tests which were broken a few weeks ago. Likely just rebasing or merging the current |
Arnei
approved these changes
Jun 14, 2022
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
docs/guides/admin/docs/workflowoperationhandlers/publication-to-workspace-woh.md
Outdated
Show resolved
Hide resolved
…o-workspace-woh.md Co-authored-by: Arne Wilken <Arnei@users.noreply.github.com>
…o-workspace-woh.md Co-authored-by: Arne Wilken <Arnei@users.noreply.github.com>
…o-workspace-woh.md Co-authored-by: Arne Wilken <Arnei@users.noreply.github.com>
lkiesow
added a commit
that referenced
this pull request
Jun 15, 2022
This adds pull request #3554 which got merged in last minute.
7 tasks
lkiesow
added a commit
that referenced
this pull request
Jun 15, 2022
This adds pull request #3554 which got merged in last minute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OC11 all publicationchannel metadata ist also stored in the mediapackage.
With this pr it is possible to copy this information from a selected
publication channel to the mediapackage in the workspace.
So it is possible to pull Publication elements to the archive.
You can clone/export/manipulate plublished material without reencoding.
Steps to do in the Workflow for example:
-> select elements by tags or flavors
-> tag elements as archive
-> download these elements to workspace
-> archive the elements
What is not implemented
Im not sure, when i would have time to do this last steps.
If someone want`s it in as it is, feel free to merge.