New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-13190, Factor out JpaGroupRoleProvider JaxRs REST to mitigate load cycle race #520

Merged
merged 3 commits into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@karendolan
Copy link
Contributor

karendolan commented Oct 25, 2018

  • Move JpaGroupRoleProvider's REST concerns into a separate class to simplify the load of the JpaGroupRoleProvider OSGI service, simply the Group Role REST component, and mitigate the opencast-userdirectory getService load cycle race condition with JaxRsServiceTracker.addingService (/groups).
  • Give external-api control of its API response

This pull does not add or remove any existing functionality. However, it forces the admin-ui, external-api, and index service to take resonsibility of their own REST API Response handling from now on.

Karen Dolan
MH-13190, Refactor JpaGroupRoleProvider JaxRs REST concerns into a se…
…parate class

          Mitigate opencast-userdirectory getService cycle (load race condition with JaxRsServiceTracker.addingService)
          Give external-api control of its API response

@staubesv staubesv self-requested a review Oct 25, 2018

@staubesv staubesv self-assigned this Oct 25, 2018

Karen Dolan

@karendolan karendolan force-pushed the harvard-dce:t/MH-13190-ImplRestRefactor-userdirectory-load-cycle-5x branch from 11e0560 to f05308b Oct 25, 2018

Karen Dolan

@karendolan karendolan force-pushed the harvard-dce:t/MH-13190-ImplRestRefactor-userdirectory-load-cycle-5x branch from f05308b to 2f5f023 Oct 25, 2018

@staubesv staubesv merged commit e2b6973 into opencast:r/5.x Oct 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment