New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-13211 engage-ui: Fix live schedule bug: event available before schedule #547

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@mliradelc
Copy link
Contributor

mliradelc commented Nov 5, 2018

The bug fix in this PR is to avoid the behaviour of allow users to access to the live stream before an event starts.

The problem was the check algorithm only worked if the data.mediapackage.media.track variable had an array type. The live streaming events have type dict. Thus the for statement never started.

The fix makes an immediate check considering that the live stream only have live tracks.

@mliradelc mliradelc changed the title engage-ui: Fix live schedule bug: event availabe before schedule [MH-13211] engage-ui: Fix live schedule bug: event available before schedule Nov 5, 2018

@mliradelc mliradelc changed the title [MH-13211] engage-ui: Fix live schedule bug: event available before schedule MH-13211 engage-ui: Fix live schedule bug: event available before schedule Nov 5, 2018

@lkiesow lkiesow merged commit ac70667 into opencast:r/5.x Nov 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lkiesow added a commit that referenced this pull request Nov 6, 2018

Merge branch 't/MH-13211-live-engage-stream-bug' of mliradelc/opencas…
…t into r/5.x

Pull request #547
  MH-13211 engage-ui: Fix live schedule bug: event available before schedule
@lkiesow

This comment has been minimized.

Copy link
Member

lkiesow commented Nov 6, 2018

Looks good now. Thanks for the additional changes. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment