Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-13474 Change the default composer job load from 0.8 to 1.5 #816

Merged

Conversation

smarquard
Copy link
Contributor

Based on production experience, the default composer job load of 0.8 is too low.

@wsmirnow wsmirnow self-assigned this Apr 1, 2019
@wsmirnow
Copy link
Contributor

wsmirnow commented Apr 1, 2019

@mtneug
Copy link
Member

mtneug commented Apr 1, 2019

All values were changed below 1.0 for 5.x (see #272 (comment)). Maybe @lkiesow could provide the context for the decision?

@smarquard
Copy link
Contributor Author

I think there may have been some discussion about the implications of higher job load values on test systems with very small resources?

Maybe the problem is that this default is not configurable. I don't quite recall exactly why we needed to change it in code, but there seemed to be cases where the job load was still 0.8 despite setting explicit job load values wherever we could.

@gregorydlogan
Copy link
Member

@smarquard it can be overridden on a per-encoding settings basis, so perhaps that's just being missed?

I'm fine with increasing it to 1.0, but 1.5 might cause issues with low-end systems configured not accept oversize jobs.

@gregorydlogan gregorydlogan added the maintenance This pull request is addressing maintenance issues label Apr 1, 2019
@wsmirnow
Copy link
Contributor

If the job load exceed the max load of the server, then you will see a warning message. But the job will be processed anyway. This is fine for me.

@wsmirnow wsmirnow merged commit 3dcd90a into opencast:develop Apr 16, 2019
@mtneug
Copy link
Member

mtneug commented Apr 16, 2019

@wsmirnow not that this is only the default configuration (see org.opencastproject.job.load.acceptexceeding=true).

smarquard added a commit that referenced this pull request Apr 30, 2019
Updating docs to match the code change in the PR.
LinqLover pushed a commit to LinqLover/opencast that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This pull request is addressing maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants