Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fixed critical upload vulnerability (#552)
Co-authored-by: Nicholas Ferreira <nickguitar.dll@hotmail.com>
- Loading branch information
1 parent
8c82b8a
commit b1af3bd
Showing
1 changed file
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1af3bdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nickguitar , @RussH
It doesn't work for me as expected.
With this change each uploaded files (even with extension from the whitelist) gets "txt" extension appended at the end of the filename
I'm currently applying such workaround for this commit
b1af3bdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alt37 thank you - verified your findings and am applying your revision. Sorry - had verified the original fix caught 'bad' extensions, but hadn't checked it actually permitted 'good' extensions to pass!