Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude INSTALL_BLOCK file from release package #194

Merged
merged 2 commits into from Jan 6, 2017

Conversation

@skrchnavy
Copy link
Contributor

commented Dec 24, 2016

fixes #193

@skrchnavy skrchnavy requested review from mlespiau and cptr13 Dec 24, 2016

Sveto Krchnavy
@mlespiau

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2017

I approve the change to solve the problem as for now, but it's quite a lot of complexity for a simple problem. Moving forward I'll make a proposal to keep track of the installation status in the DB.

@mlespiau mlespiau merged commit 7f918bc into opencats:master Jan 6, 2017

1 of 2 checks passed

codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cptr13

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

You guys will have to forgive me, because I may not understand the scope of what's happening here.
opencats-downloads

From my perspective, not having the slightest idea of everything involved, this is my understanding and why I brought this up.

The image is the download options linked from the top of the OpenCATS.org site.

End users (including me) don't know which file to download....if they download a Travis file (which has INSTALL_BLOCK in it, then they can't install opencats.

The two links with the red arrows are the travis files which have install blocks. The to without red arrows do not have the INSTALL_BLOCK.

There's nothing to fix.....but please for the love of anything. JUST...RELABEL...the downloads. So non-technical end-users (like me) know which one to get.

That's it?

Now, if there's something more to this that I'm missing...I'm sorry. I yield to y'alls experience for sure. But this is the only problem as I see it.

@cptr13

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

If re-labeling is not an option, then maybe point the download link on the main site to the source.zip file.

@RussH

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

@cptr13

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

Awesome thanks. The third one of the four in the picture. I figure the zip file is better for windows users. I'm not sure if windows by default can untar files.

@skrchnavy skrchnavy deleted the AnritsuSolutionsSK:exclude_install_block branch Jan 8, 2017

@skrchnavy skrchnavy added this to the 0.9.3-next milestone Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.