New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address vulnerabilities #440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable entity loading.
|
Can we Kindly request to get this important fix part of test-php-7.x too? |
|
well the intention would normally be that test-php-v-7.x would be merged
back into master prior to release - but if you're actually building against
test, then sure I'll add it in there, too
…----
Russ
On Tue, 2 Jul 2019 at 01:37, Shant Adam ***@***.***> wrote:
Can we Kindly request to get this important fix part of test-php-7.x too?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#440?email_source=notifications&email_token=AACFA7GRKUJSY6JB4LUUNADP5KPMJA5CNFSM4H4GA3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7W6WA#issuecomment-507473752>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACFA7CUWU4Y5TDFP3ELJGDP5KPMJANCNFSM4H4GA3TA>
.
|
|
indeed, Russ, I am building on top of test-php-v-7.x.
If you can give me a hand with the security fix merge to the later branch, you would help me focus on advancing enhancements in that branch.
Much appreciated, Russ. Thanks.
Regards,
Shant Adam
--
DISCLAIMER - This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission.
From: RussH <notifications@github.com>
Reply-To: opencats/OpenCATS <reply@reply.github.com>
Date: Tuesday, July 2, 2019 at 4:33 AM
To: opencats/OpenCATS <OpenCATS@noreply.github.com>
Cc: Shant Adam <shant.adam@mxcgi.com>, Comment <comment@noreply.github.com>
Subject: Re: [opencats/OpenCATS] Address vulnerabilities (#440)
well the intention would normally be that test-php-v-7.x would be merged
back into master prior to release - but if you're actually building against
test, then sure I'll add it in there, too
----
Russ
On Tue, 2 Jul 2019 at 01:37, Shant Adam ***@***.***> wrote:
Can we Kindly request to get this important fix part of test-php-7.x too?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#440?email_source=notifications&email_token=AACFA7GRKUJSY6JB4LUUNADP5KPMJA5CNFSM4H4GA3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7W6WA#issuecomment-507473752>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACFA7CUWU4Y5TDFP3ELJGDP5KPMJANCNFSM4H4GA3TA>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#440?email_source=notifications&email_token=AA53AVO7TP2Q2QLQT4R7I3TP5MHEHA5CNFSM4H4GA3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAQJTY#issuecomment-507577551>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA53AVK3LX6ZPADMMY2Y663P5MHEHANCNFSM4H4GA3TA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
To address the XXE vulnerability raised by Reginald Dodd.