Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in session data model #479

Closed
pfurio opened this issue Jan 4, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@pfurio
Copy link
Member

commented Jan 4, 2017

Related with #475, if we now remove the session object each time a user logs out, the logout parameter will not making sense anymore. Therefore, we plan to do these changes in the session data model:

  • Remove the logout parameter.
  • Rename the login parameter for date.
  • Add a type parameter to know whether the session was created by the user when logging in or if the user has been created by the system for analysis purposes (running jobs).

These changes will be internal ones. In order not to break any old client, we will now be returning the whole session object plus the old legacy sessionId parameter. Regarding the logout, we were not returning anything when logging out, so we are safe to return the session object itself.

@pfurio pfurio added this to the v1.0.0-rc3 milestone Jan 4, 2017

@pfurio pfurio self-assigned this Jan 4, 2017

@imedina imedina closed this in b501de6 Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.