Enhancement: Extract IndexAction from ForgotController #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
localheinz
commented
Dec 17, 2017
| /** @var FormFactoryInterface $formFactory */ | ||
| $formFactory = $app['form.factory']; | ||
|
|
||
| $resetForm = $formFactory->createBuilder(ForgotForm::class)->getForm(); |
There was a problem hiding this comment.
I believe we don't need to inject the entire FormFactory if all we need is an actual form.
localheinz
force-pushed
the
feature/forgot-index-action
branch
from
799add5
to
1f308dd
Compare
localheinz
commented
Dec 18, 2017
| bind: | ||
| $resetForm: '@OpenCFP\Http\Form\ForgotForm' | ||
|
|
||
| OpenCFP\Http\Form\ForgotForm: |
There was a problem hiding this comment.
Since I believe you are the one who has the most experience with Symfony, can you take a look and suggest a better way to wire up an actual form from a form type, if you can think of one?
classes/Http/Form/ForgotFormType.php
Outdated
| @@ -19,7 +19,7 @@ | |||
| use Symfony\Component\Form\FormBuilderInterface; | |||
| use Symfony\Component\Validator\Constraints as Assert; | |||
|
|
|||
| class ForgotForm extends AbstractType | |||
| final class ForgotFormType extends AbstractType | |||
There was a problem hiding this comment.
Renamed this class as it's not actually a form, but a definition of a form, right?
There was a problem hiding this comment.
Since this change is unrelated to the rest of the PR, maybe move it to another PR?
localheinz
force-pushed
the
feature/forgot-index-action
branch
from
1f308dd
to
85562c2
Compare
localheinz
force-pushed
the
feature/forgot-index-action
branch
from
85562c2
to
0e25ba0
Compare
chartjes
previously requested changes
Dec 18, 2017
| $formType = $this->faker()->word; | ||
|
|
||
| $form = $this->createMock(Form\FormInterface::class); | ||
|
|
There was a problem hiding this comment.
Shouldn't this be done with Prophecy?
localheinz
force-pushed
the
feature/forgot-index-action
branch
from
0e25ba0
to
438a59e
Compare
|
Thank you, @chartjes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
IndexActionfrom theForgotControllerFollows #912.