-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra inclusion of __FUNCTION__ and __LINE__, since they are already included in DEBUG() output by default. #143
Conversation
already included in DEBUG() output by default.
There are lot of Actually some of those I have to figure this out and then I'll be more than happy to unify DEBUG macros and remove all those |
Ah, that makes sense. I was wondering why those macros had been added in the first place. :-) I'll see if I can add a flag to Samba to include the location by default when writing logs to standard out in interactive mode. |
As far as I recall, Samba prints timestamp only when using syslog On Mon, Dec 1, 2014 at 8:47 PM, Jelmer Vernooij notifications@github.com
|
@kamenim also when it directly writes to logfiles, but not when it writes to standard out. |
|
On Tue, Dec 02, 2014 at 02:12:42AM -0800, Jesús García Sáez wrote:
Yeah. I'd like to change that to still not output the full header Cheers, jelmer Jelmer Vernooij jelmer@openchange.org - https://jelmer.uk/ |
377f3b3
to
dd35bf6
Compare
What is the status of this pull request now that we have OC_DEBUG implemented? |
Once we migrate all instances of DEBUG over, this pull request will be obsolete. On 24 March 2015 9:56:27 am GMT+00:00, Julien Kerihuel notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
so let's close this |
Merge from openchange repo
already included in DEBUG() output by default.