-
Notifications
You must be signed in to change notification settings - Fork 95
Add CUDA support to feature mapping and review #107
Copy link
Copy link
Open
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.
Metadata
Metadata
Assignees
Labels
P2Normal priority bug or improvement with limited blast radius.Normal priority bug or improvement with limited blast radius.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Hi @steipete, proposing first-class CUDA support in clawpatch.
clawpatch's C/C++ mapper handles generic project shapes today, and CUDA is not covered:
.cu/.cuhsources are not recognized, so CUDA projects map with little coverage, and the review prompt has no CUDA-specific guidance so a kernel is reviewed with the same checklist as any other file.Proposed scope:
Mapping (
src/mappers/,src/detect.ts):.cu/.cuhacross standalonemain()files, CMakeadd_executable/add_library(including the legacyFindCUDAcuda_add_executable/cuda_add_librarycommands), and autotools targetscudaprojectsCMakeLists.txt,CMakePresets.json, andconfigure.acas config featuresMakefilecheck/testtarget, or aCMakePresets.jsonbuild workflow); otherwise stay nullconcurrencytrust boundaryReview (
src/prompt.ts):.cu/.cuhsources, add a CUDA hazard checklist to the review prompt (default mode) and the fix prompt: kernel races and synchronization, unchecked CUDA runtime calls, host/device pointer confusion, memory-access hazards, and device-memory leaksI am opening a pull request with the implementation alongside this issue. It is based on the current
main, includes focused tests for every behavior change, and the full CI sequence passes locally.