speed up - sample_spatial_and_temporal_locations_for_examples

[peterdudfield]

Pull Request

Description

• use multiprocess to get spatial locations for examples

Fixes #304

How Has This Been Tested?

normal unittests, which do cover this function

• No
• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[peterdudfield]

Move dback to a draft as #375 might be better

[JackKelly]

I've skim-read the code and this looks good but I agree, let's work on the assumption that #375 will be sufficient 🙂 If #375 isn't sufficient then let's revisit parellising Manager.sample_spatial_and_temporal_locations_for_examples(). Is that what you had in mind?

[peterdudfield]

I've skim-read the code and this looks good but I agree, let's work on the assumption that #375 will be sufficient 🙂 If #375 isn't sufficient then let's revisit parellising Manager.sample_spatial_and_temporal_locations_for_examples(). Is that what you had in mind?

Yea, hoepfully #375 will be enough, if not can revisit this.
Perhaps I could close this PR for now, so that its not confusing

[JackKelly]

Perhaps I could close this PR for now, so that its not confusing

Sounds good! (But thank you anyway for writing this PR; it does look great!)