Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@peterdudfield
Copy link
Contributor

Pull Request

Description

Keep nwp as float32s

Fixes #370

How Has This Been Tested?

normal unittests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Nov 16, 2021
Copy link
Contributor

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@peterdudfield peterdudfield merged commit e077609 into main Nov 16, 2021
@peterdudfield peterdudfield deleted the issue/370-nwp-float-32 branch November 16, 2021 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't convert NWPs to float16! Converting to float16 results in infinities in dswrf

3 participants