Skip to content

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Mar 18, 2022

Pull Request

Description

moved 'Location' to models/gsp.py

  • add gsp yield
  • added migrations

Fixes #10

How Has This Been Tested?

added unittests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Mar 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #11 (9fce8af) into main (46de7d6) will decrease coverage by 0.99%.
The diff coverage is 94.85%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   98.61%   97.61%   -1.00%     
==========================================
  Files          11       16       +5     
  Lines         360      503     +143     
==========================================
+ Hits          355      491     +136     
- Misses          5       12       +7     
Impacted Files Coverage Δ
nowcasting_datamodel/read/read.py 100.00% <ø> (ø)
nowcasting_datamodel/connection.py 93.75% <80.00%> (+4.86%) ⬆️
nowcasting_datamodel/models/gsp.py 88.13% <88.13%> (ø)
nowcasting_datamodel/migrations/app.py 96.87% <96.87%> (ø)
nowcasting_datamodel/__init__.py 100.00% <100.00%> (ø)
nowcasting_datamodel/fake.py 100.00% <100.00%> (ø)
nowcasting_datamodel/models/__init__.py 100.00% <100.00%> (ø)
nowcasting_datamodel/models/base.py 100.00% <100.00%> (ø)
nowcasting_datamodel/models/models.py 100.00% <100.00%> (ø)
nowcasting_datamodel/models/pv.py 100.00% <100.00%> (ø)
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peterdudfield peterdudfield marked this pull request as ready for review March 21, 2022 07:20
pre-commit-ci bot and others added 26 commits March 21, 2022 11:56
# Conflicts:
#	tests/test_read.py
#	tests/test_read_pv.py
…del into add-gsp

# Conflicts:
#	tests/test_read_pv.py
@peterdudfield peterdudfield merged commit 53794fb into main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 database into 1

3 participants