Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a build option to disable mape and it's required GTK dependencies #75

Open
tgurr opened this issue Sep 24, 2018 · 2 comments
Open

Comments

@tgurr
Copy link

tgurr commented Sep 24, 2018

You've removed the USE_GTK b7359e0 option, however the checks for gtk stuff are still there and are currently automagic. As they're still required for the mape editor.

Having an editor/mape CMake option with all the GTK stuff behind would allow us to introduce an editor option to our downstream package which would reduce the required dependencies for users only wanting to play the game.

@lluchs
Copy link
Member

lluchs commented Sep 25, 2018

Yes, the current system where features are turned on/off implicitly depending on whether dependencies are available is not very good. It makes people building manually miss out on features like the editor and it makes packaging harder because package managers often don't sandbox the building process.

We should add explicit options for most things that needs additional dependencies and have the build fail if these aren't available. This includes:

  • mape (needs GTK)
  • the editor (needs Qt)
  • sound (needs OpenAL)
  • maybe UPnP (needs miniupnpc)

Enabling mape should then also include mape in the install target. Similarly, we're currently always building openclonk-server, but don't install it. Not sure what to do there. We already break it accidentally often enough, disabling it per default would make this worse.

@jcaesar
Copy link
Member

jcaesar commented Nov 28, 2018

The experimental meson build I made does this, mostly… Now you have me wonder whether I should continue that project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants