Fix same object being removed multiple times (#2048) #108
Assume you have an object with action "AbortAction" that has an AbortCall="RemoveObject", or an abort call that removes the object. Then, removing the object while it has "AbortAction" will remove it twice, reducing the Def->Count by 2, while only one object was removed. This does not do very much, but if you have only one object of that type and later check for object count after you create a new one, then creating the new object increases the Def->Count from -1 to 0 and the new object is not found by Find_ID(), even though it exists.
These were necessary before, because the object could be deleted in each callback. Now we make sure that the function runs without the object being deleted a second time, so the callbacks could be removed. With the less bloated code the recently introduced function FinishRemoval became unnecessary.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.